I also have a breaking issue with the MSSQL 2008 driver which I would fix in this weekend, and I couldn't still finish my testing with my existing mapfiles against 5.6.2.<br><br>I suggest to prepare a release during the next week.<br>
<br><br>Best regards,<br><br>Tamas<br> <br><br><br><div class="gmail_quote">2010/3/4 Lime, Steve D (DNR) <span dir="ltr"><<a href="mailto:Steve.Lime@state.mn.us">Steve.Lime@state.mn.us</a>></span><br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
I'd like to take a peek at the isValidItem() issue before doing a 5.6.2...<br>
<div><div></div><div class="h5"><br>
-----Original Message-----<br>
From: <a href="mailto:mapserver-dev-bounces@lists.osgeo.org">mapserver-dev-bounces@lists.osgeo.org</a> [mailto:<a href="mailto:mapserver-dev-bounces@lists.osgeo.org">mapserver-dev-bounces@lists.osgeo.org</a>] On Behalf Of Alan Boudreault<br>
Sent: Wednesday, March 03, 2010 3:47 PM<br>
To: <a href="mailto:mapserver-dev@lists.osgeo.org">mapserver-dev@lists.osgeo.org</a><br>
Subject: Re: [mapserver-dev] The legendary story of mapObj.zoomRectangle (a cabaret show)<br>
<br>
Tamas,<br>
<br>
Someone also reported on IRC that problem (IIRC, 2-3 weeks ago). My change was<br>
a misinterpretation and shouldn't have been done. I had not understood why<br>
this part of the code was different of the php similar function. As you said<br>
on IRC "treating maxy >= miny as a failure is semantically irregular", but<br>
this commit changed the behavior of the function that exists for a long time.<br>
I would suggest to revert it and backport it in branch 5.6.<br>
<br>
Perhaps it would be a good opportunity to release 5.6.2 ? Are there enough<br>
important fixes in the branch?<br>
<br>
regards,<br>
Alan<br>
<br>
On March 3, 2010 03:49:54 pm Tamas Szekeres wrote:<br>
> Folks,<br>
><br>
> Upon upgrading my existing application to 5.6.1 I'm getting frustrated<br>
> about the changes of the rectangle check in mapObj.zoomRectangle. So let<br>
> me summarize how the related code have changed within the past 5 years.<br>
><br>
> - 2004-06-26 The stuff has been committed by sean in r3294 mapzoom.i Ln 280<br>
> if (poPixRect->maxy >= poPixRect->miny)<br>
> {<br>
> msSetError(MS_MISCERR, "Georeferenced coordinates miny <=<br>
> maxy", "mapscript::mapObj::zoomRectangle()");<br>
> return MS_FAILURE;<br>
> }<br>
><br>
> - 2006-05-30 First attempt to swap miny and maxy by umberto in r5472<br>
><br>
> - 2006-07-24 The change have been reverted by hobu in r5542<br>
><br>
> - 2006-12-13 Second attempt to swap miny and maxy by sdlime in r5859<br>
><br>
> - 2006-12-13 Reverted the change by sdlime in r5864<br>
><br>
> - 2009-10-12 Third attempt to swap miny and maxy by aboudreault in r9444<br>
><br>
> There have been a couple of tickets related to this issue like:<br>
> <a href="http://trac.osgeo.org/mapserver/ticket/1817" target="_blank">http://trac.osgeo.org/mapserver/ticket/1817</a><br>
> <a href="http://trac.osgeo.org/mapserver/ticket/1982" target="_blank">http://trac.osgeo.org/mapserver/ticket/1982</a><br>
> <a href="http://trac.osgeo.org/mapserver/ticket/1988" target="_blank">http://trac.osgeo.org/mapserver/ticket/1988</a><br>
> <a href="http://trac.osgeo.org/mapserver/ticket/3286" target="_blank">http://trac.osgeo.org/mapserver/ticket/3286</a><br>
><br>
><br>
> While I'm a bit lost with the reason of these reverts it seems we don't<br>
> have solid standpoint on how this consistency check should be done. I<br>
> would anticipate I'm not against this change, however I would not want to<br>
> alter my existing scipts (like now) in every release in order to have my<br>
> code working.<br>
><br>
> Could someone confirm this change won't be reverted in the future releases?<br>
><br>
><br>
> Best regards,<br>
><br>
> Tamas<br>
><br>
<br>
--<br>
Alan Boudreault<br>
Mapgears<br>
<a href="http://www.mapgears.com" target="_blank">http://www.mapgears.com</a><br>
</div></div>_______________________________________________<br>
mapserver-dev mailing list<br>
<a href="mailto:mapserver-dev@lists.osgeo.org">mapserver-dev@lists.osgeo.org</a><br>
<a href="http://lists.osgeo.org/mailman/listinfo/mapserver-dev" target="_blank">http://lists.osgeo.org/mailman/listinfo/mapserver-dev</a><br>
_______________________________________________<br>
mapserver-dev mailing list<br>
<a href="mailto:mapserver-dev@lists.osgeo.org">mapserver-dev@lists.osgeo.org</a><br>
<a href="http://lists.osgeo.org/mailman/listinfo/mapserver-dev" target="_blank">http://lists.osgeo.org/mailman/listinfo/mapserver-dev</a><br>
</blockquote></div><br>