Steve,<br><br>I just wanted to make sure whether a thread safe approach of passing in stuff to the parser is doable at this stage or not? By looking a the proposed mapparser.y it doesn't seem to be implemented with the current version. I recall Frank has suggested to take a look into the recent parser enhancement in gdal with a reasonable approach: <a href="http://trac.osgeo.org/gdal/browser/sandbox/warmerdam/gdal-rfc28/gdal/ogr/swq_parser.y">http://trac.osgeo.org/gdal/browser/sandbox/warmerdam/gdal-rfc28/gdal/ogr/swq_parser.y</a><br>
<br>In case if we follow this version would this be such a big deal (and require to wait for a subsequent major release) if we would want to switch to a thread safe implementation in the future?<br><br>Do we have any reason to alter the original RFC number from 59 to 64?<br>
<br><br>Best regards,<br><br>Tamas<br><br><br><br><br><div class="gmail_quote">2010/11/29 Lime, Steve D (DNR) <span dir="ltr"><<a href="mailto:Steve.Lime@state.mn.us" target="_blank">Steve.Lime@state.mn.us</a>></span><br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">It's been a week with little comment, not sure how that should be interpreted. I know it's a long RFC. I feel a little uncomfortable declaring it "passed" based on only two votes though.<br>
<font color="#888888"><br>
Steve<br>
</font><div><div></div><div><br>
-----Original Message-----<br>
From: <a href="mailto:mapserver-dev-bounces@lists.osgeo.org" target="_blank">mapserver-dev-bounces@lists.osgeo.org</a> [mailto:<a href="mailto:mapserver-dev-bounces@lists.osgeo.org" target="_blank">mapserver-dev-bounces@lists.osgeo.org</a>] On Behalf Of Lime, Steve D (DNR)<br>
Sent: Monday, November 22, 2010 11:38 AM<br>
To: Stephen Woodbridge; <a href="mailto:mapserver-dev@lists.osgeo.org" target="_blank">mapserver-dev@lists.osgeo.org</a><br>
Subject: RE: [mapserver-dev] RFC 64 - Call for a vote...<br>
<br>
1) Thread safety. At the moment I use thread locks as we always have. So there's no regression there. I'd like to try and make things thread safe (at least for parser, as opposed to flex for mapfiles) for 6.0.<br>
<br>
2) I would like to push the IN operator optimization off (unless someone is motivated now). I don't think it's trivial exercise since we need to support both string and numeric lists on the right-hand side.<br>
<br>
Steve<br>
<br>
-----Original Message-----<br>
From: <a href="mailto:mapserver-dev-bounces@lists.osgeo.org" target="_blank">mapserver-dev-bounces@lists.osgeo.org</a> [mailto:<a href="mailto:mapserver-dev-bounces@lists.osgeo.org" target="_blank">mapserver-dev-bounces@lists.osgeo.org</a>] On Behalf Of Stephen Woodbridge<br>
Sent: Monday, November 22, 2010 11:19 AM<br>
To: <a href="mailto:mapserver-dev@lists.osgeo.org" target="_blank">mapserver-dev@lists.osgeo.org</a><br>
Subject: Re: [mapserver-dev] RFC 64 - Call for a vote...<br>
<br>
On 11/22/2010 11:39 AM, Lime, Steve D (DNR) wrote:<br>
> Need to act on RFC 64 one way or another so I'll call for a vote.<br>
><br>
> <a href="http://mapserver.org/development/rfc/ms-rfc-64.html" target="_blank">http://mapserver.org/development/rfc/ms-rfc-64.html</a><br>
<br>
Steve,<br>
<br>
What are you thoughts on the TODO list? Are these getting pushed out<br>
post 6.0?<br>
<br>
Are you planning to put thread locks around the parser global usage so<br>
you don not break thread safety? As opposed to making the code thread<br>
safe now? I do not think you can regress thread-safety and break that.<br>
<br>
For the IN optimization, if the IN list is large, load the tokens into a<br>
btree structure and search will be very fast. I believe this is how<br>
postgres does it internally.<br>
<br>
Unless there are some serious concerns from others on issues I'm not<br>
seeing, this seems like a huge amount of value for relatively low risk,<br>
other than changing a lot of code. I think this needs to go into 6.0.<br>
<br>
+1 for 6.0<br>
<br>
-Steve W<br>
_______________________________________________<br>
mapserver-dev mailing list<br>
<a href="mailto:mapserver-dev@lists.osgeo.org" target="_blank">mapserver-dev@lists.osgeo.org</a><br>
<a href="http://lists.osgeo.org/mailman/listinfo/mapserver-dev" target="_blank">http://lists.osgeo.org/mailman/listinfo/mapserver-dev</a><br>
<br>
<br>
_______________________________________________<br>
mapserver-dev mailing list<br>
<a href="mailto:mapserver-dev@lists.osgeo.org" target="_blank">mapserver-dev@lists.osgeo.org</a><br>
<a href="http://lists.osgeo.org/mailman/listinfo/mapserver-dev" target="_blank">http://lists.osgeo.org/mailman/listinfo/mapserver-dev</a><br>
<br>
<br>
_______________________________________________<br>
mapserver-dev mailing list<br>
<a href="mailto:mapserver-dev@lists.osgeo.org" target="_blank">mapserver-dev@lists.osgeo.org</a><br>
<a href="http://lists.osgeo.org/mailman/listinfo/mapserver-dev" target="_blank">http://lists.osgeo.org/mailman/listinfo/mapserver-dev</a><br>
</div></div></blockquote></div><br><div style="padding: 0px; margin-left: 0px; margin-top: 0px; overflow: hidden; word-wrap: break-word; color: black; font-size: 10px; text-align: left; line-height: 130%;">
</div>
<div style="visibility: hidden; left: -5000px; position: absolute; z-index: 9999; padding: 0px; margin-left: 0px; margin-top: 0px; overflow: hidden; word-wrap: break-word; color: black; font-size: 10px; text-align: left; line-height: 130%;" id="avg_ls_inline_popup">
</div>