<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Thomas,
<blockquote
cite="mid:CAOM3y2jwn0k+S50+OeHB=FjZfRUgOsxzHepOpNWbtJ0B9RrWmA@mail.gmail.com"
type="cite">
<pre wrap="">PS: can you open an issue for this ?
</pre>
</blockquote>
Done:
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
<a href="https://github.com/mapserver/mapserver/issues/4393">https://github.com/mapserver/mapserver/issues/4393</a><br>
<blockquote
cite="mid:CAOM3y2jwn0k+S50+OeHB=FjZfRUgOsxzHepOpNWbtJ0B9RrWmA@mail.gmail.com"
type="cite">
<blockquote type="cite">
<pre wrap="">
Augmenting the buffer size isn't an appropriate fix imho. We can have
two different fixes:
- char requestBuffer = msSmallMalloc(strlen(metadata)+1); instead of
char requestBuffer[32]; This has the inconvenience of calling a
malloc.</pre>
</blockquote>
</blockquote>
The function is actually called quite often, and using dynamic
memory allocation may result in a worse performance.<br>
<blockquote
cite="mid:CAOM3y2jwn0k+S50+OeHB=FjZfRUgOsxzHepOpNWbtJ0B9RrWmA@mail.gmail.com"
type="cite">
<blockquote type="cite">
<pre wrap="">
- The code there seems quite complicated, and if I understand
correctly what it's trying to do can be replaced with some calls to
strcasestr. As Alan is absent this week, I'd be willing to implement
and apply a patch provided you can help validate it doesn't have
side-effects I did not foresee?</pre>
</blockquote>
</blockquote>
That would be great! I'm willing to help on the validation and
testing.<br>
<blockquote
cite="mid:CAOM3y2jwn0k+S50+OeHB=FjZfRUgOsxzHepOpNWbtJ0B9RrWmA@mail.gmail.com"
type="cite">
<blockquote type="cite">
<pre wrap="">
As for 6.0.4 there are no immediate plans I think. Can you package
6.0.3 + a patch for the liveDVD?</pre>
</blockquote>
</blockquote>
Actually we use the pre-installed version of MapServer on the
liveDVD, I'm not yet sure how we can solve the issue for us. Perfect
would be a 6.0.4 release on UbuntuGIS, but I'm afraid that won't
happen in time :)<br>
<br>
Thanks a lot,<br>
Fabian<br>
</body>
</html>