<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">Tamas,<br>
if I understand correctly you are talking about connection
strings like:<br>
<br>
CONNECTIONTYPE OGR
<br>
TILEINEX "PG:dbname='PN2010_0911' host='thinkcentre1'
port='5432' user='PN2010_0911' password='PN2010_0911',images"
<br>
<br>
note the comma and table name at the end. <br>
See
<a class="moz-txt-link-freetext" href="http://lists.osgeo.org/pipermail/mapserver-dev/2011-April/011194.html">http://lists.osgeo.org/pipermail/mapserver-dev/2011-April/011194.html</a><br>
<br>
<br>
<pre class="moz-signature" cols="72">Best Regards,
Brent Fraser</pre>
On 3/3/2013 2:09 PM, Tamas Szekeres wrote:<br>
</div>
<blockquote
cite="mid:CACALY+RdiOFZUkUtVeCwYx7Ueu2iD4na-mhzxp4HYCbGKzLPgQ@mail.gmail.com"
type="cite">Hi,
<div><br>
</div>
<div>According to a commit (made 11 years ago) in <a
moz-do-not-send="true"
href="http://trac.osgeo.org/mapserver/changeset/1370">rev1370</a>
the OGR connections strings are being split by the comma
separators, see the following fragment in msOGRFileOpen:</div>
<div><br>
</div>
<div>
<div> papszTokens = CSLTokenizeStringComplex(
conn_decrypted, ",", TRUE, FALSE );</div>
<div><br>
</div>
<div> if( CSLCount(papszTokens) > 0 )</div>
<div> pszDSName = CPLStrdup( papszTokens[0] );</div>
<div> if( CSLCount(papszTokens) > 1 )</div>
<div> pszLayerDef = CPLStrdup( papszTokens[1] );</div>
</div>
<div><br>
</div>
<div>This behaviour causes issues if the syntax of the connection
string may normally expect commas, like with the issue: <a
moz-do-not-send="true"
href="http://trac.osgeo.org/gdal/ticket/4885">http://trac.osgeo.org/gdal/ticket/4885</a></div>
<div><br>
</div>
<div><br>
</div>
<div>Does it make sense to split the connection strings this way? </div>
<div><br>
</div>
<div>According to the <a moz-do-not-send="true"
href="http://mapserver.org/en/input/vector/ogr.html">OGR
driver documentation</a> the layer definitions should go to
the DATA section and not to the CONNECTION section.</div>
<div><br>
</div>
<div>I'd be in favour of removing this fragment from the code but
I'm not sure about all consequences.</div>
<div><br>
</div>
<div><br>
</div>
<div>Best regards,</div>
<div><br>
</div>
<div>Tamas</div>
<div>
<br>
</div>
<div><br>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
mapserver-dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:mapserver-dev@lists.osgeo.org">mapserver-dev@lists.osgeo.org</a>
<a class="moz-txt-link-freetext" href="http://lists.osgeo.org/mailman/listinfo/mapserver-dev">http://lists.osgeo.org/mailman/listinfo/mapserver-dev</a>
</pre>
</blockquote>
<br>
</body>
</html>