<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 14 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:Wingdings;
panose-1:5 0 0 0 0 0 0 0 0 0;}
@font-face
{font-family:Wingdings;
panose-1:5 0 0 0 0 0 0 0 0 0;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p.MsoAcetate, li.MsoAcetate, div.MsoAcetate
{mso-style-priority:99;
mso-style-link:"Balloon Text Char";
margin:0in;
margin-bottom:.0001pt;
font-size:8.0pt;
font-family:"Tahoma","sans-serif";}
p.MsoListParagraph, li.MsoListParagraph, div.MsoListParagraph
{mso-style-priority:34;
margin-top:0in;
margin-right:0in;
margin-bottom:0in;
margin-left:.5in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
span.EmailStyle17
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
span.BalloonTextChar
{mso-style-name:"Balloon Text Char";
mso-style-priority:99;
mso-style-link:"Balloon Text";
font-family:"Tahoma","sans-serif";}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri","sans-serif";}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
/* List Definitions */
@list l0
{mso-list-id:1932198285;
mso-list-type:hybrid;
mso-list-template-ids:1030149434 -1115269508 67698691 67698693 67698689 67698691 67698693 67698689 67698691 67698693;}
@list l0:level1
{mso-level-start-at:0;
mso-level-number-format:bullet;
mso-level-text:-;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;
font-family:"Calibri","sans-serif";
mso-fareast-font-family:Calibri;
mso-bidi-font-family:"Times New Roman";}
@list l0:level2
{mso-level-number-format:bullet;
mso-level-text:o;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;
font-family:"Courier New";}
@list l0:level3
{mso-level-number-format:bullet;
mso-level-text:\F0A7;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;
font-family:Wingdings;}
@list l0:level4
{mso-level-number-format:bullet;
mso-level-text:\F0B7;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;
font-family:Symbol;}
@list l0:level5
{mso-level-number-format:bullet;
mso-level-text:o;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;
font-family:"Courier New";}
@list l0:level6
{mso-level-number-format:bullet;
mso-level-text:\F0A7;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;
font-family:Wingdings;}
@list l0:level7
{mso-level-number-format:bullet;
mso-level-text:\F0B7;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;
font-family:Symbol;}
@list l0:level8
{mso-level-number-format:bullet;
mso-level-text:o;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;
font-family:"Courier New";}
@list l0:level9
{mso-level-number-format:bullet;
mso-level-text:\F0A7;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;
font-family:Wingdings;}
ol
{margin-bottom:0in;}
ul
{margin-bottom:0in;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Umberto,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Yep threading issue with Oracle seems to be fixed now, thanks for the quick fix! However, looking at mapows.c:2429 from beta2 sources shows that static variable
epsgCode was not removed. <o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">msOWSGetEPSGProj() seems to be called very often in WMS/WFS workflows…so I think it’s important issue in a threaded environment.
<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoListParagraph" style="text-indent:-.25in;mso-list:l0 level1 lfo1"><![if !supportLists]><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><span style="mso-list:Ignore">-<span style="font:7.0pt "Times New Roman"">
</span></span></span><![endif]><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Michel<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> Umberto Nicoletti [mailto:umberto.nicoletti@gmail.com]
<br>
<b>Sent:</b> Thursday, August 22, 2013 3:42 PM<br>
<b>To:</b> Michel Dastous<br>
<b>Cc:</b> MapServer Dev Mailing List<br>
<b>Subject:</b> Re: [mapserver-dev] Mapserver thread safety<o:p></o:p></span></p>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<p class="MsoNormal">We managed to push a fix in time for 6.4.0, which we will improve in later release.<o:p></o:p></p>
<div>
<p class="MsoNormal">If you want, you could test the recently released betas:<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal"><a href="http://mapserver.org/download.html#development-releases">http://mapserver.org/download.html#development-releases</a><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">BR,<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">Umberto<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</div>
<div>
<p class="MsoNormal" style="margin-bottom:12.0pt"><o:p> </o:p></p>
<div>
<p class="MsoNormal">On Thu, Aug 22, 2013 at 9:13 PM, <<a href="mailto:Michel.Dastous@bentley.com" target="_blank">Michel.Dastous@bentley.com</a>> wrote:<o:p></o:p></p>
<p class="MsoNormal">What's the status about this? I guess a fix for 6.4.0 release is too late?<br>
<br>
Thanks<o:p></o:p></p>
<div>
<p class="MsoNormal" style="margin-bottom:12.0pt"><br>
-----Original Message-----<br>
From: thomas bonfort [mailto:<a href="mailto:thomas.bonfort@gmail.com">thomas.bonfort@gmail.com</a>]<br>
Sent: Tuesday, August 13, 2013 12:21 PM<br>
To: Michel Dastous<br>
Cc: Umberto Nicoletti; MapServer Dev Mailing List<br>
Subject: Re: [mapserver-dev] Mapserver thread safety<o:p></o:p></p>
</div>
<div>
<div>
<p class="MsoNormal">Nice catch!<br>
Returning a reference to epsgCode in that function is, to my knowledge, to the best undefined behavior, clearly not thread safe, and should be fixed.<br>
<br>
--<br>
thomas<br>
<br>
On 13 August 2013 16:31, <<a href="mailto:Michel.Dastous@bentley.com">Michel.Dastous@bentley.com</a>> wrote:<br>
> About WFS/WMS thread safety, looking at mapows.c I found a single<br>
> static variable (epsgCode) used in msOWSGetEPSGProj().<br>
><br>
><br>
><br>
> Instead of returning a static pointer, the method could easily take a<br>
> buffer<br>
> + buffer size as parameters… Not a big deal except that 62 calls to<br>
> + that<br>
> function will have to be modified.<br>
><br>
><br>
><br>
> Is this the only thing that make WFS/WFS server non thread safe?<br>
><br>
><br>
><br>
> Thanks !<br>
><br>
><br>
><br>
><br>
><br>
> From: Michel Dastous<br>
> Sent: Tuesday, August 13, 2013 9:45 AM<br>
> To: 'Umberto Nicoletti'<br>
><br>
><br>
> Cc: MapServer Dev Mailing List<br>
> Subject: RE: [mapserver-dev] Mapserver thread safety<br>
><br>
><br>
><br>
> Thank you very much! I will test it as soon as possible.<br>
><br>
><br>
><br>
> From the page you sent me I realized that WMS/WFS server is not thread safe<br>
> (“WMS/WFS server: static data used for state of dispatcher”). Is there any<br>
> plan to fix this ? I could not find any ticket about this<br>
><br>
><br>
><br>
> Thanks.<br>
><br>
><br>
><br>
> From: Umberto Nicoletti [mailto:<a href="mailto:umberto.nicoletti@gmail.com">umberto.nicoletti@gmail.com</a>]<br>
> Sent: Tuesday, August 13, 2013 8:49 AM<br>
> To: Michel Dastous<br>
> Cc: MapServer Dev Mailing List<br>
> Subject: Re: [mapserver-dev] Mapserver thread safety<br>
><br>
><br>
><br>
> FYI, I've opened this pull request which should fix the Oracle spatial<br>
> issue you are seeing:<br>
><br>
> <a href="https://github.com/mapserver/mapserver/pull/4729" target="_blank">https://github.com/mapserver/mapserver/pull/4729</a><br>
><br>
> Let me know if it works for you.<br>
><br>
><br>
><br>
> BR,<br>
><br>
> Umberto<br>
><br>
> On Tue, Aug 13, 2013 at 8:23 AM, Umberto Nicoletti<br>
> <<a href="mailto:umberto.nicoletti@gmail.com">umberto.nicoletti@gmail.com</a>> wrote:<br>
><br>
> Michel,<br>
><br>
> this page attempts to keep track of which Mapserver components are<br>
> thread<br>
> safe:<br>
><br>
><br>
><br>
> <a href="http://mapserver.org/faq.html#is-mapserver-thread-safe" target="_blank">
http://mapserver.org/faq.html#is-mapserver-thread-safe</a><br>
><br>
><br>
><br>
> it must not be completely up to date as, as you found out, Oracle is<br>
> listed as safe, while it's not.<br>
><br>
> As for fixing it, it should be relatively easy as those two variables<br>
> can be made local to the functions using them.<br>
><br>
><br>
><br>
> Please open an issue and I will look into it asap.<br>
><br>
><br>
><br>
> Umberto<br>
><br>
><br>
><br>
><br>
><br>
> On Mon, Aug 12, 2013 at 9:44 PM, <<a href="mailto:Michel.Dastous@bentley.com">Michel.Dastous@bentley.com</a>> wrote:<br>
><br>
> Hi all,<br>
><br>
><br>
><br>
> I’ve been testing mapserver and its c# mapscript API for a while now,<br>
> and I have noticed that making simultaneous Draw request on multiple<br>
> maps containing Oracle layer will end up in memory corruption. No<br>
> surprise here since maporaclespatial.c uses static variables<br>
> (ordinates_tdo and ordinates).<br>
><br>
><br>
><br>
> My question is: Does anyone have already evaluated how much work it<br>
> would require to make it thread safe (i.e remove those static<br>
> variables from the<br>
> code) ?<br>
><br>
><br>
><br>
> Furthermore, I have also tested the MSSQL plugin which is stable under<br>
> same conditions, unfortunately it doesn’t seem to scale very well my 4<br>
> core machines with maximum CPU usage of 15%.<br>
><br>
><br>
><br>
> I don’t think the problem come from mapserver’ s rendering engine…<br>
> when drawing a map with inlined data, I could easily reach a 90% usage.<br>
><br>
><br>
><br>
> So any suggestions/information would be welcome.<br>
><br>
><br>
><br>
> Thanks.<br>
><br>
><br>
><br>
><br>
><br>
> _______________________________________________<br>
> mapserver-dev mailing list<br>
> <a href="mailto:mapserver-dev@lists.osgeo.org">mapserver-dev@lists.osgeo.org</a><br>
> <a href="http://lists.osgeo.org/mailman/listinfo/mapserver-dev" target="_blank">
http://lists.osgeo.org/mailman/listinfo/mapserver-dev</a><br>
><br>
><br>
><br>
><br>
><br>
><br>
> _______________________________________________<br>
> mapserver-dev mailing list<br>
> <a href="mailto:mapserver-dev@lists.osgeo.org">mapserver-dev@lists.osgeo.org</a><br>
> <a href="http://lists.osgeo.org/mailman/listinfo/mapserver-dev" target="_blank">
http://lists.osgeo.org/mailman/listinfo/mapserver-dev</a><br>
><br>
<br>
_______________________________________________<br>
mapserver-dev mailing list<br>
<a href="mailto:mapserver-dev@lists.osgeo.org">mapserver-dev@lists.osgeo.org</a><br>
<a href="http://lists.osgeo.org/mailman/listinfo/mapserver-dev" target="_blank">http://lists.osgeo.org/mailman/listinfo/mapserver-dev</a><o:p></o:p></p>
</div>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</div>
</body>
</html>