<div dir="ltr">Hi Steve,<div><br></div><div style>Yes I can add my function in mapstring.c. Will be done this day.</div><div style><br></div><div style>Regards</div><div style>Francois</div></div><div class="gmail_extra"><br>
<br><div class="gmail_quote">2013/8/28 Lime, Steve D (MNIT) <span dir="ltr"><<a href="mailto:Steve.Lime@state.mn.us" target="_blank">Steve.Lime@state.mn.us</a>></span><br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div lang="EN-US" link="blue" vlink="purple">
<div>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Hi Francois: Could your JSON escaping code implemented as a utility function in mapstring.c? I could see some use for it in other areas (e.g. templating).<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Steve<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p>
<p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> <a href="mailto:mapserver-dev-bounces@lists.osgeo.org" target="_blank">mapserver-dev-bounces@lists.osgeo.org</a> [mailto:<a href="mailto:mapserver-dev-bounces@lists.osgeo.org" target="_blank">mapserver-dev-bounces@lists.osgeo.org</a>]
<b>On Behalf Of </b>Francois Desjarlais<br>
<b>Sent:</b> Wednesday, August 28, 2013 9:00 AM<br>
<b>To:</b> Even Rouault<br>
<b>Cc:</b> <a href="mailto:mapserver-dev@lists.osgeo.org" target="_blank">mapserver-dev@lists.osgeo.org</a>; Daniel Morissette<br>
<b>Subject:</b> Re: [mapserver-dev] RFC-93: UTFGrid output<u></u><u></u></span></p><div><div class="h5">
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<p class="MsoNormal">Hi Even,<u></u><u></u></p>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">Thanks for your feedback. <u></u><u></u></p>
</div>
<div>
<p class="MsoNormal">I'll be looking at these points and do the necessary changes.<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">My code is already escaping non-valid characters in the JSON. It should always return a valid one.<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal">Also, I don't have enough time to add the suggested mode before the end of the project and school restarting.<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">Regards<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal">Francois<u></u><u></u></p>
</div>
</div>
<div>
<p class="MsoNormal" style="margin-bottom:12.0pt"><u></u> <u></u></p>
<div>
<p class="MsoNormal">2013/8/27 Even Rouault <<a href="mailto:even.rouault@mines-paris.org" target="_blank">even.rouault@mines-paris.org</a>><u></u><u></u></p>
<p class="MsoNormal">Le lundi 26 août 2013 13:06:18, Daniel Morissette a écrit :<u></u><u></u></p>
<div>
<p class="MsoNormal" style="margin-bottom:12.0pt">> Hi Devs,<br>
><br>
> RFC-93 has been updated by François to reflect his implementation of<br>
> UTGGrid output in MapServer over the summer. Please have a look and<br>
> share your comments so that he has time to make any required changes<br>
> before the end of his project:<br>
><br>
> <a href="http://mapserver.org/development/rfc/ms-rfc-93.html" target="_blank">
http://mapserver.org/development/rfc/ms-rfc-93.html</a><br>
><br>
> A sample app and docs are available at:<br>
><br>
> <a href="http://msgsoc.mapgears.com/" target="_blank">http://msgsoc.mapgears.com/</a><br>
><br>
> And his code is in branch utfgridgsoc of his github fork:<br>
><br>
> <a href="https://github.com/fdesj/mapserver/tree/utfgridgsoc" target="_blank">
https://github.com/fdesj/mapserver/tree/utfgridgsoc</a><u></u><u></u></p>
</div>
<p class="MsoNormal">Nice work.<br>
<br>
A few points and ideas :<br>
<br>
* <a href="http://msgsoc.mapgears.com/html/en/output/utfgrid.html" target="_blank">
http://msgsoc.mapgears.com/html/en/output/utfgrid.html</a> mentions "UTFGrids<br>
can be set on multiple layers but only one UTFGrid can be rendered at a time"<br>
but the RFC not. Perhaps this could be added in it too.<br>
<br>
* I'm wondering if the JSON escaping of values expanded in the "keys" (from<br>
UTFITEM) and "data" (from UTFDATA) has been taken into account (in particular<br>
escaping of " and \ ). My quick review of the code seems to indicate no, but I<br>
might be wrong.<br>
<br>
* perhaps there could be a mode (for the lazy folks ;-) ) in which UTFDATA<br>
could be generated automatically from the "gml_include_items" and<br>
"gml_exclude_items" layer metadata ?<br>
<br>
* No validation of UTFRESOLUTION is done (line 310). If set to values < 1,<br>
this could lead to divizon by zero or failed mallocs due to negative values.<br>
Such values shoud likely be refused.<br>
<br>
* r->duplicates = strcmp("false", msGetOutputFormatOption(format,<br>
"DUPLICATES", "true")); at line 320 is a convoluted way of writing :<br>
<br>
r->duplicates = EQUAL("true", msGetOutputFormatOption(format, "DUPLICATES",<br>
"true"));<br>
<br>
or !EQUAL("false", ... )<br>
<br>
* MSVC will not be happy with wchar_t string[img->width/renderer-<br>
>utfresolution + 1]; at line 378<br>
<span style="color:#888888"><br>
<br>
<span>Even</span><br>
<br>
<span>--</span><br>
<span>Geospatial professional services</span><br>
<span><a href="http://even.rouault.free.fr/services.html" target="_blank">http://even.rouault.free.fr/services.html</a></span></span><u></u><u></u></p>
<div>
<div>
<p class="MsoNormal">_______________________________________________<br>
mapserver-dev mailing list<br>
<a href="mailto:mapserver-dev@lists.osgeo.org" target="_blank">mapserver-dev@lists.osgeo.org</a><br>
<a href="http://lists.osgeo.org/mailman/listinfo/mapserver-dev" target="_blank">http://lists.osgeo.org/mailman/listinfo/mapserver-dev</a><u></u><u></u></p>
</div>
</div>
</div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
</div></div></div>
</div>
</blockquote></div><br></div>