<!DOCTYPE html><html><head><title></title><style type="text/css">#qt p{white-space:pre-wrap;}
p.MsoNormal,p.MsoNoSpacing{margin:0}</style></head><body><div>Hi,<br></div><div><br></div><div>Thanks for the merge. <br></div><div><br></div><div>It looks like the backport bot was already setup on docs 6 months ago [1], so any change comes down to updating the "About" text and default branch. <br></div><div><br></div><div>Re line endings - I've been guilty of this, especially when EOL differences are hidden by default in diff viewers. <br></div><div><div>Currently, it seems the docs are majority CRLF and the MapServer code are majority LF. <br></div><div>Trying to enforce this via .gitattributes didn't work out too well last time [2]. <br></div><div>Maybe there is a GitHub Action that could help [3]. <br></div><div><br></div><div>Seth<br></div><div><br></div></div><div>[1] <a href="https://github.com/mapserver/docs/blob/master/.github/workflows/backport.yml">https://github.com/mapserver/docs/blob/master/.github/workflows/backport.yml</a><br></div><div>[2] <a href="https://github.com/mapserver/mapserver/pull/5934">https://github.com/mapserver/mapserver/pull/5934</a><br></div><div>[3] <a href="https://github.com/marketplace/actions/check-crlf">https://github.com/marketplace/actions/check-crlf</a><br></div><div><br></div><div>Options to enforce this on pull requests would be very useful. <br></div><div><br></div><div id="sig62266145"><div>--<br></div><div>web:http://geographika.co.uk<br></div><div>twitter: @geographika<br></div></div><div><br></div><div><br></div><div>On Sun, Sep 20, 2020, at 11:18 AM, Even Rouault wrote:<br></div><blockquote type="cite" id="qt" style="font-family:"monospace";font-size:9pt;font-weight:400;font-style:normal;"><p style="margin-top:0px;margin-bottom:0px;margin-left:0px;margin-right:0px;text-indent:0px;">Hi,<br></p><p style="margin-top:0px;margin-bottom:0px;margin-left:0px;margin-right:0px;text-indent:0px;"> <br></p><p style="margin-top:0px;margin-bottom:0px;margin-left:0px;margin-right:0px;text-indent:0px;">I'm OK with that. I've just done the exercise of merging the 7.6 branch to master. Technically this is just a matter of running "git merge", but there are indeed the issues with conflicts. There were a few here to solve.<br></p><p style="margin-top:0px;margin-bottom:0px;margin-left:0px;margin-right:0px;text-indent:0px;"> <br></p><p style="margin-top:0px;margin-bottom:0px;margin-left:0px;margin-right:0px;text-indent:0px;">One issue that we face regularly though to keep the stable and master branch in sync is the issue of line endings. This is something we face independently of using "git merge" or backport/cherry-picking of commits. Would be good if people could convince their text editors not to alter the line endings. Or we might play with .git/config settings to decide for a given line ending on the server.<br></p><p style="margin-top:0px;margin-bottom:0px;margin-left:0px;margin-right:0px;text-indent:0px;"> <br></p><p style="margin-top:0px;margin-bottom:0px;margin-left:0px;margin-right:0px;text-indent:0px;">Once we go for a backport-based workflow, git merge will no longer be usable, so this will require discipline for people to make sure that whatever must be ported to the other branch is done at the time the change is pushed.<br></p><p style="margin-top:0px;margin-bottom:0px;margin-left:0px;margin-right:0px;text-indent:0px;"> <br></p><p style="margin-top:0px;margin-bottom:0px;margin-left:0px;margin-right:0px;text-indent:0px;">Even<br></p><p style="margin-top:0px;margin-bottom:0px;margin-left:0px;margin-right:0px;text-indent:0px;"> <br></p><p style="margin-top:0px;margin-bottom:0px;margin-left:0px;margin-right:0px;text-indent:0px;">> Hi all,<br></p><p style="margin-top:0px;margin-bottom:0px;margin-left:0px;margin-right:0px;text-indent:0px;">><br></p><p style="margin-top:0px;margin-bottom:0px;margin-left:0px;margin-right:0px;text-indent:0px;">> At the moment pull requests to https://github.com/mapserver/docs/ should be<br></p><p style="margin-top:0px;margin-bottom:0px;margin-left:0px;margin-right:0px;text-indent:0px;">> made to the latest active branch (currently 7.6). Documentation for new<br></p><p style="margin-top:0px;margin-bottom:0px;margin-left:0px;margin-right:0px;text-indent:0px;">> features however should be made to master (as they won't apply to new<br></p><p style="margin-top:0px;margin-bottom:0px;margin-left:0px;margin-right:0px;text-indent:0px;">> features). Sometimes it is difficult to know if a code change will be<br></p><p style="margin-top:0px;margin-bottom:0px;margin-left:0px;margin-right:0px;text-indent:0px;">> backported or not.<br></p><p style="margin-top:0px;margin-bottom:0px;margin-left:0px;margin-right:0px;text-indent:0px;">><br></p><p style="margin-top:0px;margin-bottom:0px;margin-left:0px;margin-right:0px;text-indent:0px;">> There are several pull requests that have been added to the 7.6 branch that<br></p><p style="margin-top:0px;margin-bottom:0px;margin-left:0px;margin-right:0px;text-indent:0px;">> are not in master, and some in master that are not in 7.6. I'm not sure how<br></p><p style="margin-top:0px;margin-bottom:0px;margin-left:0px;margin-right:0px;text-indent:0px;">> these possible conflicts are merged following a release (likely a<br></p><p style="margin-top:0px;margin-bottom:0px;margin-left:0px;margin-right:0px;text-indent:0px;">> painstaking manual process by Jeff?).<br></p><p style="margin-top:0px;margin-bottom:0px;margin-left:0px;margin-right:0px;text-indent:0px;">><br></p><p style="margin-top:0px;margin-bottom:0px;margin-left:0px;margin-right:0px;text-indent:0px;">> Would it make sense to follow the same development process as the MapServer<br></p><p style="margin-top:0px;margin-bottom:0px;margin-left:0px;margin-right:0px;text-indent:0px;">> codebase, and set up the GitHub "backport" bot? Then if code is backported<br></p><p style="margin-top:0px;margin-bottom:0px;margin-left:0px;margin-right:0px;text-indent:0px;">> the doc pull request can be too, and master will contain all updates.<br></p><p style="margin-top:0px;margin-bottom:0px;margin-left:0px;margin-right:0px;text-indent:0px;">><br></p><p style="margin-top:0px;margin-bottom:0px;margin-left:0px;margin-right:0px;text-indent:0px;">> Seth<br></p><p style="margin-top:0px;margin-bottom:0px;margin-left:0px;margin-right:0px;text-indent:0px;">><br></p><p style="margin-top:0px;margin-bottom:0px;margin-left:0px;margin-right:0px;text-indent:0px;">><br></p><p style="margin-top:0px;margin-bottom:0px;margin-left:0px;margin-right:0px;text-indent:0px;">> --<br></p><p style="margin-top:0px;margin-bottom:0px;margin-left:0px;margin-right:0px;text-indent:0px;">> web:http://geographika.co.uk<br></p><p style="margin-top:0px;margin-bottom:0px;margin-left:0px;margin-right:0px;text-indent:0px;">> twitter: @geographika<br></p><p style="margin-top:0px;margin-bottom:0px;margin-left:0px;margin-right:0px;text-indent:0px;">> _______________________________________________<br></p><p style="margin-top:0px;margin-bottom:0px;margin-left:0px;margin-right:0px;text-indent:0px;">> mapserver-dev mailing list<br></p><p style="margin-top:0px;margin-bottom:0px;margin-left:0px;margin-right:0px;text-indent:0px;">> mapserver-dev@lists.osgeo.org<br></p><p style="margin-top:0px;margin-bottom:0px;margin-left:0px;margin-right:0px;text-indent:0px;">> https://lists.osgeo.org/mailman/listinfo/mapserver-dev<br></p><p style="margin-top:0px;margin-bottom:0px;margin-left:0px;margin-right:0px;text-indent:0px;"> <br></p><p style="margin-top:0px;margin-bottom:0px;margin-left:0px;margin-right:0px;text-indent:0px;"> <br></p><p style="margin-top:0px;margin-bottom:0px;margin-left:0px;margin-right:0px;text-indent:0px;">--<br></p><p style="margin-top:0px;margin-bottom:0px;margin-left:0px;margin-right:0px;text-indent:0px;">Spatialys - Geospatial professional services<br></p><p style="margin-top:0px;margin-bottom:0px;margin-left:0px;margin-right:0px;text-indent:0px;">http://www.spatialys.com<br></p></blockquote><div><br></div></body></html>