<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<p>I'm +1 on the RFC</p>
<p>Even<br>
</p>
<div class="moz-cite-prefix">Le 30/03/2021 à 22:57, Seth G a écrit :<br>
</div>
<blockquote type="cite"
cite="mid:9c595813-3fb1-4f14-93be-5063b11c95da@www.fastmail.com">
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
<title></title>
<style type="text/css">p.MsoNormal,p.MsoNoSpacing{margin:0}</style>
<div>Hi Steve,<br>
</div>
<div><br>
</div>
<div>I'm not sure where I got CLASS MAXSCALE from - it is not a
property of the classObj or referenced anywhere in the
sourcecode/tests. I'll remove from the RFC. <br>
</div>
<div><br>
</div>
<div>Anyone else on the PSC more votes on this?<br>
</div>
<div><br>
</div>
<div>I'm tempted to merge <a
href="https://github.com/MapServer/MapServer/pull/6264/"
moz-do-not-send="true">https://github.com/MapServer/MapServer/pull/6264/</a>
(this is mainly Steve's work, and then I updated the
msautotests), it touches a lot of files so may need to be
rebased quite often if not merged soon.<br>
</div>
<div><br>
</div>
<div>Seth<br>
</div>
<div><br>
</div>
<div id="sig62266145">
<div class="signature">--<br>
</div>
<div class="signature">web:<a class="moz-txt-link-freetext" href="http://geographika.co.uk">http://geographika.co.uk</a><br>
</div>
<div class="signature">twitter: @geographika<br>
</div>
</div>
<div><br>
</div>
<div><br>
</div>
<div>On Mon, Mar 29, 2021, at 4:54 PM, Steve Lime wrote:<br>
</div>
<blockquote type="cite" id="qt" style="">
<div dir="ltr">
<div>Hi Seth: In general I'm a strong +1 on this, anything
that simplifies the code base is a good thing.. Only one I
wonder about is <i>CLASS MAXSCALE</i> since MINSCALE is
currently supported as well? Personally I'm selfish and I
really like the MINSCALE/MAXSCALE aliases so retaining those
across the board would save me a ton of work when 8.0
arrives.<br>
</div>
<div><br>
</div>
<div>--Steve<br>
</div>
</div>
<div><br>
</div>
<div class="qt-gmail_quote">
<div dir="ltr" class="qt-gmail_attr">On Tue, Mar 16, 2021 at
6:08 PM Seth G <<a href="mailto:sethg@geographika.co.uk"
moz-do-not-send="true">sethg@geographika.co.uk</a>>
wrote:<br>
</div>
<blockquote class="qt-gmail_quote"
style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0.8ex;border-left-color:rgb(204,
204,
204);border-left-style:solid;border-left-width:1px;padding-left:1ex;">
<div><br>
</div>
<div>
<div>Hi all,<br>
</div>
<div><br>
</div>
<div>I've made a start of implementing RFC 133 [1] by
removing the now redundant LAYER DUMP keyword [2].<br>
</div>
<div>It would be good to get some votes in before
proceeding further in case people have objections to the
overall aim of removing deprecated keywords for the 8.0
release. <br>
</div>
<div>Any objections to specific keywords being removed can
be raised on individual pull requests. <br>
</div>
<div><br>
</div>
<div>Seth<br>
</div>
<div><br>
</div>
<div>[1] <a
href="https://mapserver.org/development/rfc/ms-rfc-133.html"
target="_blank" moz-do-not-send="true">https://mapserver.org/development/rfc/ms-rfc-133.html</a><br>
</div>
<div>[2] <a
href="https://github.com/MapServer/MapServer/pull/6264"
target="_blank" moz-do-not-send="true">https://github.com/MapServer/MapServer/pull/6264</a><br>
</div>
<div id="qt-gmail-m_-994561705765618940sig62266145">
<div>--<br>
</div>
<div>web:<a href="http://geographika.co.uk"
target="_blank" moz-do-not-send="true">http://geographika.co.uk</a><br>
</div>
<div>twitter: @geographika<br>
</div>
</div>
<div><br>
</div>
<div><br>
</div>
<div>On Tue, Feb 2, 2021, at 11:18 PM, Seth G wrote:<br>
</div>
<blockquote type="cite"
id="qt-gmail-m_-994561705765618940qt">
<div>Hi Steve,<br>
</div>
<div><br>
</div>
<div>If you could do a reference pull request I can use
this as a template for the other keywords.<br>
</div>
<div>I guess it needs a vote before accepting, so I'll
start with my +1 - removing ambiguity around keywords
will help new MapServer users. I was adding the DUMP
keyword to all LAYER configs for several years "just
in case"...<br>
</div>
<div><br>
</div>
<div>Seth<br>
</div>
<div><br>
</div>
<div id="qt-gmail-m_-994561705765618940qt-sig62266145">
<div>--<br>
</div>
<div>web:<a href="http://geographika.co.uk"
target="_blank" moz-do-not-send="true">http://geographika.co.uk</a><br>
</div>
<div>twitter: @geographika<br>
</div>
</div>
<div><br>
</div>
<div><br>
</div>
<div>On Tue, Feb 2, 2021, at 12:31 AM, Steve Lime wrote:<br>
</div>
<blockquote type="cite"
id="qt-gmail-m_-994561705765618940qt-qt">
<div dir="ltr">
<div>I don't recall any keyword removals
specifically. Should have to touch:<br>
</div>
<div>
<ul>
<li>maplexer.l to remove keywords from the
grammar <br>
</li>
<li>mapfile.c/mapfile.h to remove read/write
cases and symbols<br>
</li>
<li>mapserver.h to remove structure members<br>
</li>
</ul>
<div>Updating the maplexer.l effectively stops
support, the rest is just cleanup. I'll commit
to taking a run through all of these in the next
day or so. It's a long list...<br>
</div>
</div>
<div><br>
</div>
<div>--Steve<br>
</div>
</div>
<div><br>
</div>
<div>
<div dir="ltr">On Fri, Jan 29, 2021 at 3:06 PM Seth
G <<a href="mailto:sethg@geographika.co.uk"
target="_blank" moz-do-not-send="true">sethg@geographika.co.uk</a>>
wrote:<br>
</div>
<blockquote
style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0.8ex;border-left-color:rgb(204,
204,
204);border-left-style:solid;border-left-width:1px;padding-left:1ex;">
<div>Hi all,<br>
</div>
<div><br>
</div>
<div>I've got round to a draft RFC for cleaning up
deprecated and legacy Mapfile keywords, based on
current docs and going through all the allowed
syntax as part of mappyfile development and
ongoing MapScript docs updates. <br>
</div>
<div><br>
</div>
<div><a
href="https://mapserver.org/development/rfc/ms-rfc-133.html"
rel="noreferrer" target="_blank"
moz-do-not-send="true">https://mapserver.org/development/rfc/ms-rfc-133.html</a><br>
</div>
<div><br>
</div>
<div>It might be too early to vote on the RFC
without some discussion about which keywords
should be removed. <br>
</div>
<div><br>
</div>
<div>In terms of updates any keyword removal would
be a separate pull request. The changes to
mapfile.c seem fine (and the msautotest
Mapfiles), but I've never used the
lexer/parser/Bison process. Are there any sample
commits when a Mapfile keyword has been removed
previously?<br>
</div>
<div><br>
</div>
<div>Thoughts/comments welcome,<br>
</div>
<div><br>
</div>
<div>Seth<br>
</div>
<div><br>
</div>
<div><br>
</div>
<div>--<br>
</div>
<div>web:<a href="http://geographika.co.uk"
rel="noreferrer" target="_blank"
moz-do-not-send="true">http://geographika.co.uk</a><br>
</div>
<div>twitter: @geographika<br>
</div>
<div>_______________________________________________<br>
</div>
<div>mapserver-dev mailing list<br>
</div>
<div><a
href="mailto:mapserver-dev@lists.osgeo.org"
target="_blank" moz-do-not-send="true">mapserver-dev@lists.osgeo.org</a><br>
</div>
<div><a
href="https://lists.osgeo.org/mailman/listinfo/mapserver-dev"
rel="noreferrer" target="_blank"
moz-do-not-send="true">https://lists.osgeo.org/mailman/listinfo/mapserver-dev</a><br>
</div>
</blockquote>
</div>
</blockquote>
<div><br>
</div>
</blockquote>
<div><br>
</div>
</div>
<div>_______________________________________________<br>
</div>
<div> mapserver-dev mailing list<br>
</div>
<div> <a href="mailto:mapserver-dev@lists.osgeo.org"
target="_blank" moz-do-not-send="true">mapserver-dev@lists.osgeo.org</a><br>
</div>
<div> <a
href="https://lists.osgeo.org/mailman/listinfo/mapserver-dev"
rel="noreferrer" target="_blank" moz-do-not-send="true">https://lists.osgeo.org/mailman/listinfo/mapserver-dev</a><br>
</div>
</blockquote>
</div>
</blockquote>
<div><br>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<pre class="moz-quote-pre" wrap="">_______________________________________________
mapserver-dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:mapserver-dev@lists.osgeo.org">mapserver-dev@lists.osgeo.org</a>
<a class="moz-txt-link-freetext" href="https://lists.osgeo.org/mailman/listinfo/mapserver-dev">https://lists.osgeo.org/mailman/listinfo/mapserver-dev</a>
</pre>
</blockquote>
<pre class="moz-signature" cols="72">--
<a class="moz-txt-link-freetext" href="http://www.spatialys.com">http://www.spatialys.com</a>
My software is free, but my time generally not.</pre>
</body>
</html>