<div dir="ltr">Welcome Calvin, with four +1 votes and no objections you are now a proj4js committer. Keep up the great work!<div><br></div><div>With a vote of three +1, proj4js now has a review policy - no merging of pull requests without a peer review.</div>
<div><br></div><div>Thanks Hugues for the RFC suggestion. Although we do not have such a process in place, I would ask everyone who has big changes in mind to discuss them beforehand. It is my impression that this has been a part of the project's culture anyway, and has happened with all big changes so far.<br>
<div><br></div><div style>Andreas.</div></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Sep 6, 2013 at 9:48 AM, Hugues Wisniewski <span dir="ltr"><<a href="mailto:hugues.wisniewski@autodesk.com" target="_blank">hugues.wisniewski@autodesk.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div lang="EN-US" link="blue" vlink="purple">
<div>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">+1<u></u><u></u></span></p><div class="im">
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">></span>
<span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Now that we're at least 3 active proj4js committers, I'd like to establish a review policy<u></u><u></u></span></p>
</div><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">+1 for that<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Something to possibly also consider is the concept of RFCs used on MapGuide and CsMap (Request For Change)<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">When many from different teams and companies work on the same project, it’s nice to be notified ahead of time of major changes coming up. Others have time to
prepare and react, possibly asking or suggesting changes.<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">This is the CsMap page, which is based on the MapGuide RFC process<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><a href="http://trac.osgeo.org/csmap/wiki/CsMapRfcs" target="_blank">http://trac.osgeo.org/csmap/wiki/CsMapRfcs</a><u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Hugues<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p>
<p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> <a href="mailto:metacrs-bounces@lists.osgeo.org" target="_blank">metacrs-bounces@lists.osgeo.org</a> [mailto:<a href="mailto:metacrs-bounces@lists.osgeo.org" target="_blank">metacrs-bounces@lists.osgeo.org</a>]
<b>On Behalf Of </b>Andreas Hocevar<br>
<b>Sent:</b> Thursday, September 05, 2013 8:36 PM<br>
<b>To:</b> <a href="mailto:metacrs@lists.osgeo.org" target="_blank">metacrs@lists.osgeo.org</a>; Calvin Metcalf; Mike Adair<br>
<b>Subject:</b> [MetaCRS] Give Calvin Metcalf commit access to proj4js; proj4js review policy<u></u><u></u></span></p><div><div class="h5">
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<p class="MsoNormal">Hey,<u></u><u></u></p>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">I'd like to propose to give Calvin Metcalf commit access to the proj4js repository on github. Calvin has shown great talent bringing bleeding edge JavaScript technologies to proj4js, and the many pull request of his that I merged were all
of outstanding quality.<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">I am +1.<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">Now that we're at least 3 active proj4js committers, I'd like to establish a review policy: Pull request - peer review - merge. This way every change will have a second pair of eyes look at it, which is good for QA.<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">I am +1.<br clear="all">
<u></u><u></u></p>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">Thanks,<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal">Andreas.<u></u><u></u></p>
</div>
<p class="MsoNormal"><br clear="all">
<u></u><u></u></p>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<p class="MsoNormal">-- <br>
Andreas Hocevar<br>
OpenGeo - <a href="http://opengeo.org/" target="_blank">http://opengeo.org/</a><br>
Expert service straight from the developers.<br clear="all"><div><br></div>-- <br>Andreas Hocevar<br>OpenGeo - <a href="http://opengeo.org/">http://opengeo.org/</a><br>Expert service straight from the developers.<br>
<br>
</p></div></div></div></div></div></div></blockquote></div></div>