[OpenLayers-Dev] Different lon and lat map resolution (and other issues)

Christopher Schmidt crschmidt at metacarta.com
Fri Nov 2 14:12:50 EDT 2007


On Fri, Nov 02, 2007 at 06:37:43PM +0100, Jachym Cepicky wrote:
> Hi,
> 
> Tim Schaub p????e v P?? 02. 11. 2007 v 10:57 -0600:
> 
> > > I can understand this. How many people do have write access to trunk?
> > > 
> > 
> > http://trac.openlayers.org/wiki/CLA
> > 
> > The above page describes who has access to what.  As with all else in a 
> > wiki, this list requires a person to update it - so I can't say how 
> > current it is, but I think Erik probably is keeping it up.
> > 
> 
> From what I see in mailing list, only few, who have the access are
> really committing something or reviewing patches "from outside". Am I
> wrong?

Erik, Tim, Schuyler, and Eric have all actively reviewed patches in the
past couple months. After pushing for weeks on end -- spending hours of
my personal time every day -- I've been taking a break and sticking to
only working 12 hours a day instead of 16. This leaves a lot less
OpenLayers time there.

I agree that there are fewer people reviewing and examining code than
there could be. However, at the moment, I'm not aware of a solution
which results in more people volunteering their free time to do
integration of existing patches into the trunk. This isn't a case of
avoiding code from outsiders, this is largely a case of avoiding any
changes at all.

I do have a goal of reviewing many of the outstanding patches, but at
the moment, I can't  afford to do it 'at work', so I need to do it in my
free time. This means that anything complex doesn't get reviewed at all.

Simple patches -- one or two lines -- especially those with tests, get a
quick eyeball and review. Anything more complex is unlikely to proceed
quickly, simply because it requires long solid blocks of time to move
such complex patches forward.

> >  Will it work with the upcoming Proj4js work?  
> 
> No idea - I'm working with current subversion repository. Do I have to
> apply all other proposed changes/patches in order to provide well tests?

No, but it's important to be aware of upcoming work, in order to be able
to discuss it with other members of the community with this in mind.
It's not possible to know everything, but this particular change affects
a pretty major part of the code -- right at the core -- and changing the
core of OpenLayers behavior is something that I am personally adverse
to.

> If I'm posting a patch, than I can only say: "I tested everything, I
> could. It works for me". When I find something, or somebody will report
> something, that would not work, I will do my best to fix it. 
> 
> So, to answer your question: yes, everything works for me.

Have you run the tests in Firefox and IE? That's typically a good
question to have a ready answer to. 

> But the discussion went too concrete now. General question is: Do you
> think, current system is all right? Are there enough reviewers, who are
> checking the tracker regularly and communicating with the contributors?
>
> As you probably understand: I do not think so.

I'll respond to this in a new thread, because I think it's a very
important quesiton that deserves more than a piecemeal discussion as
part of this thread.

Regards,
-- 
Christopher Schmidt
MetaCarta



More information about the Dev mailing list