[OpenLayers-Dev] Submitted Patch for Ticket #2959
jansen at terrestris.de
Thu Jun 16 17:43:45 EDT 2011
indeed a great addition.
I was wondering though wether we have all our @requires set correctly
now. Or is OpenLayers.Util always included in custom builds?
And is there a reason that we do not have a test that explicitly checks
the iframe-issue? I don't doubt it is being fixed by the patch but would
love to have a test double checking that. Without actually trying I'd
think that all current tests in test_isArray(t) would pass with the
"old" and unwrapped instanceof as well.
Just my two cents, thanks again and best regards,
Am 16.06.2011 21:19, schrieb Tim Schaub:
> On 6/16/11 10:06 AM, Michael Wooten wrote:
>> Hello All,
>> I have submitted a patch for ticket #2959
>> (http://trac.osgeo.org/openlayers/ticket/2959). The ticket is related
>> to "instanceof Array" tests that fail when the array is passed from
>> another frame or iframe (such as those used by Google Web Toolkit).
>> The patch replaces the "x instanceof Array" tests with a new call to
>> OpenLayers.Util.isArray(x). The OpenLayers.Util.isArray() function
>> uses a test that should work across all frames. I also updated
>> Util.html with a test case for isArray().
>> Please consider this patch for review and inclusion in OpenLayers 2.11.
> In with r12095. Thanks for the great patch.
> I think we need to restart the conversation about the 2.11 release
> process. This isn't a regression, so it shouldn't be pulled in during
> the RC process. But where we are in the process is not clear to me.
> Separate thread.
>> -Michael Wooten
>> Dev mailing list
>> Dev at lists.osgeo.org
More information about the Dev