I like to see this changes, but may be we need more, I think it's the time to move the indexOf and toFloat methods from Util to base types. <br>For backward compatibility, we let OpenLayers.Util.indexOf link to OpenLayers.Array.indexOf<br>
<br clear="all">Li XinGang<br>EMail: <a href="mailto:slinavlee@gmail.com">slinavlee@gmail.com</a><br>Blog: <a href="http://avlee.cnblogs.com">avlee.cnblogs.com</a><br>Site: <a href="http://www.mapboost.org">www.mapboost.org</a><br>
<br><br><div class="gmail_quote">On Thu, Jan 6, 2011 at 5:03 AM, Tim Schaub <span dir="ltr"><<a href="mailto:tschaub@opengeo.org">tschaub@opengeo.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
So I've made changes in the trunk to simplify build configurations.<br>
<br>
<a href="http://trac.osgeo.org/openlayers/changeset/11006/" target="_blank">http://trac.osgeo.org/openlayers/changeset/11006/</a><br>
<br>
This allows for circular dependencies (imposing an arbitrary sort order). Then I changed things to break the one circular dependency that we have that cannot be resolved with an arbitrary sort order.<br>
<br>
<a href="http://trac.osgeo.org/openlayers/changeset/11003/" target="_blank">http://trac.osgeo.org/openlayers/changeset/11003/</a><br>
<br>
The result is that dependencies can now be entirely declared within the library (and, in the future, in your application code).<br>
<br>
As a consequence, people using custom build profiles will likely want to remove the "first" section from their configuration files.<br>
<br>
E.g. <a href="http://trac.osgeo.org/openlayers/changeset/11008" target="_blank">http://trac.osgeo.org/openlayers/changeset/11008</a><br>
<br>
Hope that makes sense,<br><font color="#888888">
Tim</font><div><div></div><div class="h5"><br>
<br>
On 1/1/11 4:34 PM, Tim Schaub wrote:<br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
Hey-<br>
<br>
I'd like to make it easier to correctly build custom profiles of the<br>
library. One restriction that we currently face is that our toposort<br>
method is unnecessarily strict with regard to circular dependencies.<br>
With a more tolerant toposort, we could safely declare more dependencies<br>
in our source files (where they belong) instead of in configuration files.<br>
<br>
One current circular dependency that will not be satisfied with an<br>
arbitrary sort order is the Class -> Util -> BaseTypes -> Class loop.<br>
Our Class function really only requires the extend method from Util. If<br>
we define the extend method in the Class.js file, then things can be<br>
resolved properly.<br>
<br>
I've made changes in a sandbox that include a simplified & more tolerant<br>
topological sort [1], extend in Class instead of Util [2], and proper<br>
dependency declarations in the source comments. This results in simpler<br>
build configuration files [3] (closer to something that could be handled<br>
by @require comments in an application file instead of a separate build<br>
configuration file).<br>
<br>
I've put up a patch that moves the extend method into Class.js [4]. I<br>
thought this one deserved review & input. All the other changes are<br>
comments only or changes in the build tools.<br>
<br>
Thanks for any feedback,<br>
Tim<br>
<br>
<br>
[1] <a href="http://trac.osgeo.org/openlayers/changeset/10979/" target="_blank">http://trac.osgeo.org/openlayers/changeset/10979/</a><br>
<br>
[2] <a href="http://trac.osgeo.org/openlayers/changeset/10982/" target="_blank">http://trac.osgeo.org/openlayers/changeset/10982/</a><br>
<br>
[3]<br>
<a href="http://trac.osgeo.org/openlayers/browser/sandbox/tschaub/uncircular/build/lite.cfg" target="_blank">http://trac.osgeo.org/openlayers/browser/sandbox/tschaub/uncircular/build/lite.cfg</a><br>
<br>
<br>
[4] <a href="http://trac.osgeo.org/openlayers/ticket/2992" target="_blank">http://trac.osgeo.org/openlayers/ticket/2992</a><br>
<br>
</blockquote>
<br>
<br>
-- <br>
Tim Schaub<br>
OpenGeo - <a href="http://opengeo.org" target="_blank">http://opengeo.org</a><br>
Expert service straight from the developers.<br>
_______________________________________________<br>
Dev mailing list<br>
<a href="mailto:Dev@lists.osgeo.org" target="_blank">Dev@lists.osgeo.org</a><br>
<a href="http://lists.osgeo.org/mailman/listinfo/openlayers-dev" target="_blank">http://lists.osgeo.org/mailman/listinfo/openlayers-dev</a><br>
</div></div></blockquote></div><br>