<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
<title></title>
</head>
<body bgcolor="#ffffff" text="#000000">
Hi Denis,<br>
<br>
I shared my thoughts already in the ticket.<br>
<br>
One additional thought: If I read it right, your method expects to
be called with a string argument, right? Maybe it'd be good to also
support passing the constructor. You'd then need to check the type
of the argument and if it is a fucntion, do an instanceof check.<br>
<br>
Maybe even better than any specific implementation would be a method
like "findFeaturesByFunc" (or so) that'd accept a method and
optionally a scope. We would call teh method with every feature and
if the function returned true, we'd add it to the foundFeatures
array.<br>
<br>
What would you think?<br>
<br>
Regards,<br>
Marc<br>
<br>
<br>
<br>
<br>
<br>
On 01.08.2011 01:27, Denis Rykov wrote:
<blockquote
cite="mid:CAJbvKNqo7HdqMhMd-3Q_f=LqardvrAadQW1UFv_Q5LAU7vW1iw@mail.gmail.com"
type="cite">Hi!<br>
<br>
Could anyone review my first patch to OpenLayers: <a
moz-do-not-send="true"
href="http://trac.osgeo.org/openlayers/ticket/3446">http://trac.osgeo.org/openlayers/ticket/3446</a>.
This method returns an array of features that have the given
geometry type. I use this method very extensively and guess it may
be useful for another users.<br>
<pre wrap="">
<fieldset class="mimeAttachmentHeader"></fieldset>
_______________________________________________
Dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Dev@lists.osgeo.org">Dev@lists.osgeo.org</a>
<a class="moz-txt-link-freetext" href="http://lists.osgeo.org/mailman/listinfo/openlayers-dev">http://lists.osgeo.org/mailman/listinfo/openlayers-dev</a>
</pre>
</blockquote>
<br>
</body>
</html>