On 04/09/07, <b class="gmail_sendername">Christopher Schmidt</b> <<a href="mailto:crschmidt@metacarta.com">crschmidt@metacarta.com</a>> wrote:<div><span class="gmail_quote"></span><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
On Mon, Sep 03, 2007 at 11:20:14AM +1000, Glen Stampoultzis wrote:<br>> On 31/08/07, Christopher Schmidt <<a href="mailto:crschmidt@metacarta.com">crschmidt@metacarta.com</a>> wrote:<br>> ><br>> > On Fri, Aug 31, 2007 at 04:12:54PM +1000, Glen Stampoultzis wrote:
<br>> > > Hi...<br>> > ><br>> > > just been mucking around with popups and I noticed that the destroy<br>> > method<br>> > > does seem to get called. The close poup button just hides the div from
<br>> > what<br>> > > I can tell and the map.removePopup() call seems to remove the div from<br>> > the<br>> > > DOM without calling destroy and cleaning up the event handlers.<br>> > >
<br>> > > Bug or feature?<br>> ><br>> > When would you call destroy? Certainly, a popup can be removed from the<br>> > map without it being destroyed: it can be re-added at a later time, and<br>
> > we use that behavior in some applications here at MetaCarta.<br>> ><br>> > In general, removing things is not the same as destroying them, and<br>> > depending on when they are created, you may have to clean up after
<br>> > yourself rather than depending on OpenLayers to do it for you.<br>> ><br>> > If you use a feature to create the popup, it destroys the popup for<br>> > you. If you create your own, you're on your own.
<br>> ><br>> ><br>> It's just that popup doesn't provide any way for you to attach an event<br>> indicating the user has closed the popup using the close button so how do<br>> you know when to destroy?
<br><br>You probably don't want to destroy when the user closed the popup<br>anyway: It's still attached to the map at that point, no?<br><br>One possibility is just to destroy it when the window is closed -- but<br>
really, if there's still any popups on the map when the page is<br>unloaded, we should be destroying them. I've opened ticket #955 for<br>that. Would that be enough to solve the problem? Is destroying the<br>popups during your application's running important?
<br><br></blockquote></div><br>It would help. I guess I'm a bit anal about leaving loads of
unnecessary event handlers registered for popups that aren't visible.
I can do a check for hidden popups before opening a new one I guess.<br>
<br><br><br>