<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">Hi Juan Manuel,<br>
<br>
great work indeed, this looks very promising.<br>
<br>
I agree with Toms comments, especially the dist part. Most of your
commits also include the changed dist-file which can be quite
distracting. <br>
<br>
Other comments (not a thorough review):<br>
<ul>
<li>some typos in the README</li>
<li>some typos in the commit messages</li>
<li>IMO the README should use '#', '##' and friends for headings
in a more structured way</li>
<li>I'd personally leave out the validator links in the example</li>
<li>the example itself isn't really self-explanatory <br>
</li>
</ul>
<p>Nothing of the above is critical.<br>
</p>
I'd love to get your work in, so others can built on top of this.<br>
<br>
Thanks again & best regards,<br>
Marc<br>
<br>
On 14.03.2015 02:41, Tom Kralidis wrote:<br>
</div>
<blockquote
cite="mid:01BE07D1-3C94-4E4C-B5F9-3D3F3ED36EEB@gmail.com"
type="cite">
<meta http-equiv="content-type" content="text/html;
charset=windows-1252">
<div>Hi Juan Manuel: great work! I'll dig deeper when the pr is
submitted but first comments for clarification:</div>
<div><br>
</div>
<div>- should we abstract the js code setup for multiple versions?
For example I would like to start CSW 3 implementation</div>
<div>- can we remove the dist/ directory from version control? The
idea being this should be a build / release step</div>
<div><br>
</div>
<div>..Tom<br>
<br>
Sent from my iPhone</div>
<div><br>
On Mar 13, 2015, at 17:21, Juan Manuel Vicente <<a
moz-do-not-send="true" href="mailto:juanma.v82@gmail.com">juanma.v82@gmail.com</a>>
wrote:<br>
<br>
</div>
<blockquote type="cite">
<div>
<div dir="ltr">Hi guys,
<div><br>
</div>
<div>I done some updates, especially at the README. The
library need some more work but I think it is a good start
point to start using it.</div>
<div><br>
</div>
<div>Can anyone do a peer-review before I make a pull
request?[1]</div>
<div><br>
</div>
<div>Thanks</div>
<div>
<div style="font-size:12.8000001907349px">Regards</div>
<div style="font-size:12.8000001907349px">Juan Manuel</div>
</div>
<div style="font-size:12.8000001907349px"><br>
</div>
<div style="font-size:12.8000001907349px"><span
style="font-size:12.8000001907349px">[1]</span><a
moz-do-not-send="true"
href="https://github.com/juanmav/ows.js" target="_blank"
style="font-size:12.8000001907349px">https://github.com/juanmav/<span
class="">ows</span>.<span class="">js</span></a><br>
</div>
</div>
<br>
</div>
</blockquote>
</blockquote>
<br>
</body>
</html>