<div dir="ltr"><div>Tom, Marc, </div><div><br></div><div>Thanks for the feedback!</div><div><br></div><div>1- Yes, we can abstract the js code to implement new CSW version. I really dont know which differences are between CSW 2.0.2 and CSW 3.0. If CSW 3.0 extend CSW 2.0.2 operations or CSW 3.0 need to re-implement operations.</div><div><br></div><div>2- We should remove the dist directory and create another repo with dist files. (ex: bower-ows.js, npm-ows.js, etc). Here I was playing around with bower and registered the repo. With "bower install ows.js --save" to install the ows.min.js file.</div><div><br></div><div>3- I going check typos with more detail (english is not my native language) and use Markup correctly.</div><div><br></div><div>Thanks</div><div>Juan Manuel</div><div><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Sun, Mar 15, 2015 at 6:32 PM, Marc Jansen <span dir="ltr"><<a href="mailto:jansen@terrestris.de" target="_blank">jansen@terrestris.de</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000">
<div>Hi Juan Manuel,<br>
<br>
great work indeed, this looks very promising.<br>
<br>
I agree with Toms comments, especially the dist part. Most of your
commits also include the changed dist-file which can be quite
distracting. <br>
<br>
Other comments (not a thorough review):<br>
<ul>
<li>some typos in the README</li>
<li>some typos in the commit messages</li>
<li>IMO the README should use '#', '##' and friends for headings
in a more structured way</li>
<li>I'd personally leave out the validator links in the example</li>
<li>the example itself isn't really self-explanatory <br>
</li>
</ul>
<p>Nothing of the above is critical.<br>
</p>
I'd love to get your work in, so others can built on top of this.<br>
<br>
Thanks again & best regards,<br>
Marc<span class=""><br>
<br>
On 14.03.2015 02:41, Tom Kralidis wrote:<br>
</span></div><span class="">
<blockquote type="cite">
<div>Hi Juan Manuel: great work! I'll dig deeper when the pr is
submitted but first comments for clarification:</div>
<div><br>
</div>
<div>- should we abstract the js code setup for multiple versions?
For example I would like to start CSW 3 implementation</div>
<div>- can we remove the dist/ directory from version control? The
idea being this should be a build / release step</div>
<div><br>
</div>
<div>..Tom<br>
<br>
Sent from my iPhone</div>
<div><br>
On Mar 13, 2015, at 17:21, Juan Manuel Vicente <<a href="mailto:juanma.v82@gmail.com" target="_blank">juanma.v82@gmail.com</a>>
wrote:<br>
<br>
</div>
<blockquote type="cite">
<div>
<div dir="ltr">Hi guys,
<div><br>
</div>
<div>I done some updates, especially at the README. The
library need some more work but I think it is a good start
point to start using it.</div>
<div><br>
</div>
<div>Can anyone do a peer-review before I make a pull
request?[1]</div>
<div><br>
</div>
<div>Thanks</div>
<div>
<div style="font-size:12.8000001907349px">Regards</div>
<div style="font-size:12.8000001907349px">Juan Manuel</div>
</div>
<div style="font-size:12.8000001907349px"><br>
</div>
<div style="font-size:12.8000001907349px"><span style="font-size:12.8000001907349px">[1]</span><a href="https://github.com/juanmav/ows.js" style="font-size:12.8000001907349px" target="_blank">https://github.com/juanmav/<span>ows</span>.<span>js</span></a><br>
</div>
</div>
<br>
</div>
</blockquote>
</blockquote>
<br>
</span></div>
<br>_______________________________________________<br>
owsjs mailing list<br>
<a href="mailto:owsjs@lists.osgeo.org">owsjs@lists.osgeo.org</a><br>
<a href="http://lists.osgeo.org/cgi-bin/mailman/listinfo/owsjs" target="_blank">http://lists.osgeo.org/cgi-bin/mailman/listinfo/owsjs</a><br>
<br></blockquote></div><br></div></div>