<html>
<head>
<style><!--
.hmmessage P
{
margin:0px;
padding:0px
}
body.hmmessage
{
font-size: 10pt;
font-family:Tahoma
}
--></style></head>
<body class='hmmessage'><div dir='ltr'>
<br>Thanks Luca! Please merge into trunk, as most of your changes are additions.<br><br>w.r.t tests, there is a github branch which fixes the tests, which we can merge following this.<br><br><div><div id="SkyDrivePlaceholder"></div><hr id="stopSpelling">From: Luca.Cinquini@jpl.nasa.gov<br>To: tomkralidis@hotmail.com<br>CC: jachym.cepicky@gmail.com; owslib-devel@lists.sourceforge.net; pywps-devel@wald.intevation.org<br>Subject: Re: [owslib-devel] WPS branch<br>Date: Tue, 5 Jun 2012 14:55:30 +0000<br><br>
Hi Tom,
<div><br>
<div>
<div>On Jun 3, 2012, at 3:58 PM, Tom Kralidis wrote:</div>
<br class="ecxApple-interchange-newline">
<blockquote><span class="ecxApple-style-span" style="border-collapse:separate;font-family:Helvetica;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;orphans:2;text-align:-webkit-auto;text-indent:0px;text-transform:none;white-space:normal;widows:2;word-spacing:0px;font-size:medium">
<div class="ecxhmmessage" style="font-size:10pt;font-family:Tahoma">
<div dir="ltr">Luca: great work -- thanks very much for this! Some comments:<br>
<br>
- can you put what you can from README_WPS.txt in owslib/wps.py (i.e. as docstring comments, etc.), or even better add these as documentation to docs/en/index.rst?<br>
</div>
</div>
</span></blockquote>
<div><br>
</div>
<div>Done - I have updated index.rst with the same usage examples as some of the other modules, and transferred the whole content of README_WPS.txt at the beginning of the wps.py module</div>
<br>
<blockquote><span class="ecxApple-style-span" style="border-collapse:separate;font-family:Helvetica;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;orphans:2;text-align:-webkit-auto;text-indent:0px;text-transform:none;white-space:normal;widows:2;word-spacing:0px;font-size:medium">
<div class="ecxhmmessage" style="font-size:10pt;font-family:Tahoma">
<div dir="ltr">- can you merge owslib/wps_utils.py into owslib/util.py, assuming you can't use what's already in owslib/util.py (e.g. util.testXMLValue might do the same thing as wps_utils.parseText)?<br>
</div>
</div>
</span></blockquote>
<div><br>
</div>
Done - I was indeed able to reuse util.testXMLValue but no other function.<br>
<blockquote><span class="ecxApple-style-span" style="border-collapse:separate;font-family:Helvetica;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;orphans:2;text-align:-webkit-auto;text-indent:0px;text-transform:none;white-space:normal;widows:2;word-spacing:0px;font-size:medium">
<div class="ecxhmmessage" style="font-size:10pt;font-family:Tahoma">
<div dir="ltr"><br>
Having said this, we should get this into trunk sooner than later, so I'm okay with Luca committing this to trunk given the above is considered.<br>
</div>
</div>
</span></blockquote>
<div><br>
</div>
<div>Great - I could merge the branch into trunk, or leave it up to someone else - let me know.</div>
<div>One question I have is wether the doctests currently in trunk are supposed to work - I get a whole lot of errors when I run tests/runalldoctests.py from trunk.... But maybe I am doing something wrong.</div>
<div><br>
</div>
<div>thanks, Luca</div>
<br>
<blockquote><span class="ecxApple-style-span" style="border-collapse:separate;font-family:Helvetica;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;orphans:2;text-align:-webkit-auto;text-indent:0px;text-transform:none;white-space:normal;widows:2;word-spacing:0px;font-size:medium">
<div class="ecxhmmessage" style="font-size:10pt;font-family:Tahoma">
<div dir="ltr"><br>
Thanks<br>
<br>
..Tom<br>
<br>
<div>
<div id="ecxSkyDrivePlaceholder"></div>
> From:<span class="ecxApple-converted-space"> </span><a href="mailto:Luca.Cinquini@jpl.nasa.gov">Luca.Cinquini@jpl.nasa.gov</a><br>
> To:<span class="ecxApple-converted-space"> </span><a href="mailto:jachym.cepicky@gmail.com">jachym.cepicky@gmail.com</a><br>
> Date: Sun, 3 Jun 2012 19:38:25 +0000<br>
> CC:<span class="ecxApple-converted-space"> </span><a href="mailto:owslib-devel@lists.sourceforge.net">owslib-devel@lists.sourceforge.net</a>;<span class="ecxApple-converted-space"> </span><a href="mailto:pywps-devel@wald.intevation.org">pywps-devel@wald.intevation.org</a><br>
> Subject: Re: [owslib-devel] WPS branch<br>
><span class="ecxApple-converted-space"> </span><br>
> Hi Jachym,<br>
> thanks, I appreciate the extra work on a Sunday...<br>
> best regards,<br>
> Luca<br>
><span class="ecxApple-converted-space"> </span><br>
> On Jun 3, 2012, at 12:22 PM, Jachym Cepicky wrote:<br>
><span class="ecxApple-converted-space"> </span><br>
> > hi,<br>
> ><span class="ecxApple-converted-space"> </span><br>
> > thanks for submitting<br>
> ><span class="ecxApple-converted-space"> </span><br>
> > I've tested it (up to describe-process phase ;-) ) on one of our PyWPS<br>
> > deployments (<a href="http://apps.esdi-humboldt.cz/pywps/" target="_blank">http://apps.esdi-humboldt.cz/pywps/</a>), it worked perfectly.<br>
> ><span class="ecxApple-converted-space"> </span><br>
> > I like the way, the client is implemented - nice work, thanks!<br>
> ><span class="ecxApple-converted-space"> </span><br>
> > Jachym<br>
> ><span class="ecxApple-converted-space"> </span><br>
> > Dne 3.6.2012 13:14, Cinquini, Luca (3880) napsal(a):<br>
> >> Hi all,<br>
> >> I believe the WPS branch is ready for some independent testing...<br>
> >><span class="ecxApple-converted-space"> </span><br>
> >> I merged the latest trunk into the branch. The code seems to be working well with invocations to the USGS and PML WPS services, at least the examples I tried.<br>
> >><span class="ecxApple-converted-space"> </span><br>
> >> Good starting points for trying out the code are:<br>
> >><span class="ecxApple-converted-space"> </span><br>
> >> o The README_WPS.txt file<br>
> >> o The wps* examples in the examples/ directory<br>
> >> o The wps*.txt tests in the tests/ directory<br>
> >> o The wps-client.py program in the examples/ directory<br>
> >><span class="ecxApple-converted-space"> </span><br>
> >> All feedback is appreciated,<br>
> >> thanks, Luca<br>
> >><span class="ecxApple-converted-space"> </span><br>
> >><span class="ecxApple-converted-space"> </span><br>
> >><span class="ecxApple-converted-space"> </span><br>
> >> ------------------------------------------------------------------------------<br>
> >> Live Security Virtual Conference<br>
> >> Exclusive live event will cover all the ways today's security and<span class="ecxApple-converted-space"> </span><br>
> >> threat landscape has changed and how IT managers can respond. Discussions<span class="ecxApple-converted-space"> </span><br>
> >> will include endpoint security, mobile security and the latest in malware<span class="ecxApple-converted-space"> </span><br>
> >> threats.<span class="ecxApple-converted-space"> </span><a href="http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/" target="_blank">http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/</a><br>
> >> _______________________________________________<br>
> >> owslib-devel mailing list<br>
> >><span class="ecxApple-converted-space"> </span><a href="mailto:owslib-devel@lists.sourceforge.net">owslib-devel@lists.sourceforge.net</a><br>
> >><span class="ecxApple-converted-space"> </span><a href="https://lists.sourceforge.net/lists/listinfo/owslib-devel" target="_blank">https://lists.sourceforge.net/lists/listinfo/owslib-devel</a><br>
> ><span class="ecxApple-converted-space"> </span><br>
> > --<span class="ecxApple-converted-space"> </span><br>
> > Jachym Cepicky<br>
> > Help Service - Remote Sensing s.r.o.<br>
> ><span class="ecxApple-converted-space"> </span><a href="mailto:jachym.cepicky@gmail.com">jachym.cepicky@gmail.com</a><span class="ecxApple-converted-space"> </span>|<span class="ecxApple-converted-space"> </span><a href="mailto:jachym@hsrs.cz">jachym@hsrs.cz</a><br>
> ><span class="ecxApple-converted-space"> </span><a href="http://les-ejk.cz" target="_blank">http://les-ejk.cz</a><span class="ecxApple-converted-space"> </span>|<span class="ecxApple-converted-space"> </span><a href="http://bnhelp.cz" target="_blank">http://bnhelp.cz</a><br>
> ><span class="ecxApple-converted-space"> </span><br>
><span class="ecxApple-converted-space"> </span><br>
><span class="ecxApple-converted-space"> </span><br>
> ------------------------------------------------------------------------------<br>
> Live Security Virtual Conference<br>
> Exclusive live event will cover all the ways today's security and<span class="ecxApple-converted-space"> </span><br>
> threat landscape has changed and how IT managers can respond. Discussions<span class="ecxApple-converted-space"> </span><br>
> will include endpoint security, mobile security and the latest in malware<span class="ecxApple-converted-space"> </span><br>
> threats.<span class="ecxApple-converted-space"> </span><a href="http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/" target="_blank">http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/</a><br>
> _______________________________________________<br>
> owslib-devel mailing list<br>
><span class="ecxApple-converted-space"> </span><a href="mailto:owslib-devel@lists.sourceforge.net">owslib-devel@lists.sourceforge.net</a><br>
><span class="ecxApple-converted-space"> </span><a href="https://lists.sourceforge.net/lists/listinfo/owslib-devel" target="_blank">https://lists.sourceforge.net/lists/listinfo/owslib-devel</a><br>
</div>
</div>
</div>
</span></blockquote>
</div>
<br>
</div></div> </div></body>
</html>