<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<base href="x-msg://4/">
</head>
<body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">
<div><br>
</div>
<div>Tom,</div>
<div><br>
</div>
<div>I added a test case in test/test_wfs_USDASSURGO.py. Here is what the failure looks like without my proposed patch:</div>
<div><br>
</div>
<div>
<blockquote type="cite">
<div><font class="Apple-style-span" color="#000000">$ python -m unittest test_wfs_USDASSURGO</font></div>
<div><font class="Apple-style-span" color="#000000">E</font></div>
<div><font class="Apple-style-span" color="#000000">======================================================================</font></div>
<div><font class="Apple-style-span" color="#000000">ERROR: runTest (test_wfs_USDASSURGO.USDASSURGOWFSTestCase)</font></div>
<div><font class="Apple-style-span" color="#000000">----------------------------------------------------------------------</font></div>
<div><font class="Apple-style-span" color="#000000">Traceback (most recent call last):</font></div>
<div><font class="Apple-style-span" color="#000000"> File "test_wfs_USDASSURGO.py", line 17, in runTest</font></div>
<div><font class="Apple-style-span" color="#000000"> response = wfs.getfeature(typename=('MapunitPolyExtended',), filter=filter, propertyname=None)</font></div>
<div><font class="Apple-style-span" color="#000000"> File "/usr/local/lib/python2.7/dist-packages/OWSLib-0.5.1-py2.7.egg/owslib/feature/wfs100.py", line 184, in getfeature</font></div>
<div><font class="Apple-style-span" color="#000000"> request['propertyname'] = ','.join(propertyname)</font></div>
<div><font class="Apple-style-span" color="#000000">TypeError</font></div>
<div><font class="Apple-style-span" color="#000000"><br>
</font></div>
<div><font class="Apple-style-span" color="#000000">----------------------------------------------------------------------</font></div>
<div><font class="Apple-style-span" color="#000000">Ran 1 test in 0.215s</font></div>
<div><font class="Apple-style-span" color="#000000"><br>
</font></div>
<div><font class="Apple-style-span" color="#000000">FAILED (errors=1)</font></div>
</blockquote>
</div>
<div>
<div><br>
</div>
</div>
<div><br>
</div>
<div>Let me know if you need anything else.</div>
<div><br>
</div>
<div>Thanks,</div>
<br>
<div><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; font-size: medium; "><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; font-size: medium; ">
<div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">
<span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; font-size: medium; ">
<div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">
<span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; font-size: medium; ">
<div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">
<div>Brian Miles</div>
<div>PhD Candidate</div>
<div>Department of Geography</div>
<div>University of North Carolina at Chapel Hill</div>
<div><br>
</div>
<div>Saunders Hall</div>
</div>
</span></div>
</span>Campus Box 3220
<div>Chapel Hill, NC 27599-3220<br>
<div><br>
</div>
</div>
</div>
</span><br class="Apple-interchange-newline">
</span><br class="Apple-interchange-newline">
</div>
<br>
<div>
<div>On Nov 27, 2012, at 9:56 PM, Tom Kralidis wrote:</div>
<br class="Apple-interchange-newline">
<blockquote type="cite">
<div class="hmmessage" style="font-size: 12pt; font-family: Calibri; ">
<div dir="ltr">Thanks for the reminder, I've since commented in the PR.<br>
<br>
<div>
<div id="SkyDrivePlaceholder"></div>
<hr id="stopSpelling">
From:<span class="Apple-converted-space"> </span><a href="mailto:brian_miles@unc.edu">brian_miles@unc.edu</a><br>
To:<span class="Apple-converted-space"> </span><a href="mailto:owslib-devel@lists.osgeo.org">owslib-devel@lists.osgeo.org</a><br>
Date: Wed, 28 Nov 2012 01:09:44 +0000<br>
Subject: [OWSLib-devel] Pull request: WFS 1.0.0 getfeature property handling Edit<br>
<br>
<div><br>
</div>
<div>Hello,</div>
<div><br>
</div>
<div>Any chance of incorporating this pull request:</div>
<div><br>
</div>
<div><a href="https://github.com/geopython/OWSLib/pull/37" target="_blank">https://github.com/geopython/OWSLib/pull/37</a></div>
<div><br>
</div>
<div>
<blockquote>
<p style="margin-top: 0px; margin-right: 0px; margin-bottom: 15px; margin-left: 0px; padding-top: 0px; padding-right: 0px; padding-bottom: 0px; padding-left: 0px; border-top-width: 0px; border-right-width: 0px; border-bottom-width: 0px; border-left-width: 0px; border-style: initial; border-color: initial; color: rgb(51, 51, 51); font-family: Helvetica, arial, freesans, clean, sans-serif; font-size: 13px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: 20px; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; background-color: rgb(251, 251, 251); ">
Added check to getfeature(.) to allow for NoneType to be passed as the propertyname. This mirrors the behavior of wfs110.py and allows queries to USGS Soil Data Mart to succeed (<a href="http://SDMDataAccess.nrcs.usda.gov/Spatial/SDMNAD83UTM.wfs" target="_blank" style="padding-top: 0px; padding-right: 0px; padding-bottom: 0px; padding-left: 0px; border-top-width: 0px; border-right-width: 0px; border-bottom-width: 0px; border-left-width: 0px; border-style: initial; border-color: initial; color: rgb(65, 131, 196); text-decoration: none; ">http://SDMDataAccess.nrcs.usda.gov/Spatial/SDMNAD83UTM.wfs</a>).</p>
<div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px !important; margin-left: 0px; padding-top: 0px; padding-right: 0px; padding-bottom: 0px; padding-left: 0px; border-top-width: 0px; border-right-width: 0px; border-bottom-width: 0px; border-left-width: 0px; border-style: initial; border-color: initial; color: rgb(51, 51, 51); font-family: Helvetica, arial, freesans, clean, sans-serif; font-size: 13px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: 20px; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; background-color: rgb(251, 251, 251); z-index: auto; ">
Not sure how this jibes with the 1.0.0 spec, but it makes calls to the above 1.0.0 WFS service work.</div>
</blockquote>
</div>
<div><br>
</div>
<div>Thanks,</div>
<div><br>
</div>
<div>Brian</div>
<br>
_______________________________________________ OWSLib-devel mailing list<span class="Apple-converted-space"> </span><a href="mailto:OWSLib-devel@lists.osgeo.org">OWSLib-devel@lists.osgeo.org</a><a href="http://lists.osgeo.org/cgi-bin/mailman/listinfo/owslib-devel">http://lists.osgeo.org/cgi-bin/mailman/listinfo/owslib-devel</a></div>
</div>
</div>
</blockquote>
</div>
<br>
</body>
</html>