<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
<title></title>
</head>
<body text="#000000" bgcolor="#ffffff">
Hi Alexey,<br>
<br>
Thanks for your patch. I just apply it and commit changes.<br>
<br>
As far as I am not a VisualStudio user, I cannot asset the
correctness of your #ifdef statement.<br>
<br>
Regards, <br>
Maxence Laurent<br>
<br>
On 17/11/11 15:36, Alexei Kolganov wrote:
<blockquote
cite="mid:CADtz2Zsjow-kUTHn_8tRoiPMvmWdEbQuM_jU8WBXxTK4wFzW7A@mail.gmail.com"
type="cite">
<meta http-equiv="Content-Type" content="text/html;
charset=ISO-8859-1">
Greetings, Developers.<br>
<br>
Recently I have started integrating libPAL in my project and found
that it does not include any MS Visual Studio solution (or any
other convenient way) to build the library under Windows. Also,
when I have started building the library I have faced some issues
(all of them were minor, but still). Therefore I would like to
submit a little patch which would allow new users of libPAL build
the library easily.<br>
<br>
The patch is minor, it contains only the features required to
build the library in my environment.<br>
<br>
It consists of:<br>
- Solution files<br>
- Changes to source files:<br>
- Minor: eliminated trailing spaces in files that I have
modified.<br>
- Minor: eliminated few compiler warnings.<br>
- Minor: fixed compilation issue with M_PI.<br>
<br>
One thing that, however, I am not sure is correct:<br>
#ifdef _MSC_VER<br>
#define _HAVE_WINDOWS_H_<br>
#endif // _MSC_VER<br>
This code assumes that Windows SDK is always installed in MSVC,
which, frankly, is not.<br>
<br>
The patch is submitted to Trac as Ticket #14 ( <a
moz-do-not-send="true"
href="http://geosysin.iict.ch/pal-trac/ticket/14">http://geosysin.iict.ch/pal-trac/ticket/14</a>
)
<div>
If you have any suggestions or comments please don't hesitate to
contact me.<font class="Apple-style-span" face="Verdana, Arial,
'Bitstream Vera Sans', Helvetica, sans-serif"><br>
</font><br>
Best regards, Alexey Kolganov
</div>
<pre wrap="">
<fieldset class="mimeAttachmentHeader"></fieldset>
_______________________________________________
pal-developer mailing list
<a class="moz-txt-link-abbreviated" href="mailto:pal-developer@lists.osgeo.org">pal-developer@lists.osgeo.org</a>
<a class="moz-txt-link-freetext" href="http://lists.osgeo.org/mailman/listinfo/pal-developer">http://lists.osgeo.org/mailman/listinfo/pal-developer</a>
</pre>
</blockquote>
<br>
</body>
</html>