[pdal-commits] [PDAL/PDAL] a3ea22: Clearing up some of the issues with pdal_defines.h

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/PDAL/PDAL
  Commit: a3ea22e9205ca8df6dea68e29073b83c8442d048
      https://github.com/PDAL/PDAL/commit/a3ea22e9205ca8df6dea68e29073b83c8442d048
  Author: Bradley J Chambers <brad.chambers at gmail.com>
  Date:   2013-05-01 (Wed, 01 May 2013)

  Changed paths:
    M CMakeLists.txt
    A cmake/pdal_utils.cmake
    M src/CMakeLists.txt

  Log Message:
  -----------
  Clearing up some of the issues with pdal_defines.h

We have borrowed a number of helper macros from PCL and modify them for use in
PDAL. The pdal_defines.h should still be configured to the
PROJECT_BINARY_DIRECTORY, so we'll still need to test to see that it gets
updated accordingly.


  Commit: 9372731f079d36eeddd75b716ba5b2bef83c5230
      https://github.com/PDAL/PDAL/commit/9372731f079d36eeddd75b716ba5b2bef83c5230
  Author: Howard Butler <hobu.inc at gmail.com>
  Date:   2013-05-02 (Thu, 02 May 2013)

  Changed paths:
    M CMakeLists.txt
    A cmake/pdal_utils.cmake
    M src/CMakeLists.txt

  Log Message:
  -----------
  Merge pull request #128 from chambbj/pdal_defines_rebase

compiles ok for me.

btw, I found a good solution for adding the git sha to the version string inside the utilities. I don't know how well it works on windows though. You can see it in action at http://github.com/hobu/hexer Can you give it a try and see if it works on windows for you there before I try to put it in PDAL?


Compare: https://github.com/PDAL/PDAL/compare/8161b0b3dc31...9372731f079d