[pdal-commits] [PDAL/PDAL] 5d3e8f: Build and test bpf without zlib

GitHub noreply at github.com
Mon Jun 2 12:00:57 PDT 2014


  Branch: refs/heads/master
  Home:   https://github.com/PDAL/PDAL
  Commit: 5d3e8f60a2bac914f43b6eb9209043ef89254361
      https://github.com/PDAL/PDAL/commit/5d3e8f60a2bac914f43b6eb9209043ef89254361
  Author: Pete Gadomski <pete.gadomski at gmail.com>
  Date:   2014-05-20 (Tue, 20 May 2014)

  Changed paths:
    M include/pdal/drivers/bpf/BpfSeqIterator.hpp
    M src/drivers/bpf/BpfSeqIterator.cpp
    M test/unit/drivers/bpf/BPFTest.cpp

  Log Message:
  -----------
  Build and test bpf without zlib

zlib support was baked into parts of the bpf driver, via the
`BpfSeqIterator::inflate` method and the logic in
`BpfSeqIterator::readBlock`. This patch only defines `inflate` if we
have zlib support, throws a runtime error if the bpf iterator tries to
read a block without zlib, and disables zlib tests if there's no zlib
support.

I'm not sure that my treatment of `readBlock` is correct, as for all I
know there could be a way to read a block without zlib. However, since I
don't know better, I kept things dumb and just threw an error if we
don't have zlib. @abellgithub can we do better?


  Commit: bd27732cc3b026ae4db4a5f6743b7f7f39c88228
      https://github.com/PDAL/PDAL/commit/bd27732cc3b026ae4db4a5f6743b7f7f39c88228
  Author: Pete Gadomski <pete.gadomski at gmail.com>
  Date:   2014-05-20 (Tue, 20 May 2014)

  Changed paths:
    M test/unit/MetadataTest.cpp
    M test/unit/drivers/las/LasWriterTest.cpp
    M test/unit/filters/StatsFilterTest.cpp

  Log Message:
  -----------
  Guard tests that require srs support

Add `#ifdef PDAL_SRS_ENABLED` around tests that require SRS support, and
in once case split out the srs-dependent parts of a test into a seperate
(guarded) test.

In the stats filter test, ther could be potential for simplifying those
the guarded tests to they don't depend on srs functionality. However,
that would be work for another commit.


  Commit: 6530d1d1f2a1d80889fd2e4364af2fc05792b9f5
      https://github.com/PDAL/PDAL/commit/6530d1d1f2a1d80889fd2e4364af2fc05792b9f5
  Author: Pete Gadomski <pete.gadomski at gmail.com>
  Date:   2014-05-20 (Tue, 20 May 2014)

  Changed paths:
    M include/pdal/Filters.hpp
    M include/pdal/filters/Colorization.hpp
    M src/CMakeLists.txt
    M src/StageFactory.cpp
    M test/unit/CMakeLists.txt

  Log Message:
  -----------
  Exclude colorization filter if we don't have GDAL

It doesn't make much sense to overlay a GDAL raster without GDAL. This
patch also reorganizes the GDAL files in src/CMakeLists.txt.


  Commit: 7b79183d35e2627911b4a4e7ebe631a0655e30dd
      https://github.com/PDAL/PDAL/commit/7b79183d35e2627911b4a4e7ebe631a0655e30dd
  Author: Pete Gadomski <pete.gadomski at gmail.com>
  Date:   2014-05-20 (Tue, 20 May 2014)

  Changed paths:
    M apps/pdal.cpp
    M include/pdal/Filters.hpp
    M include/pdal/kernel/Kernel.hpp
    M src/CMakeLists.txt
    M src/StageFactory.cpp

  Log Message:
  -----------
  Conditionally exclude PCL

All the PCL code is now turned off if WITH_PCL == FALSE. We also remove
the command-line help text that mentions PCL.


  Commit: 52c2bf4ccf92d304b04c23faab4911aadde6859c
      https://github.com/PDAL/PDAL/commit/52c2bf4ccf92d304b04c23faab4911aadde6859c
  Author: Pete Gadomski <pete.gadomski at gmail.com>
  Date:   2014-05-20 (Tue, 20 May 2014)

  Changed paths:
    M include/pdal/Filters.hpp
    M src/CMakeLists.txt

  Log Message:
  -----------
  Conditionally exclude python-dependent filters

Programmable and Predicate.


  Commit: 0f3efb7178a27e32339eeeb06e5e314d138bc95d
      https://github.com/PDAL/PDAL/commit/0f3efb7178a27e32339eeeb06e5e314d138bc95d
  Author: Pete Gadomski <pete.gadomski at gmail.com>
  Date:   2014-06-02 (Mon, 02 Jun 2014)

  Changed paths:
    M apps/pdal.cpp
    M include/pdal/Filters.hpp
    M include/pdal/drivers/bpf/BpfSeqIterator.hpp
    M include/pdal/filters/Colorization.hpp
    M include/pdal/kernel/Kernel.hpp
    M src/CMakeLists.txt
    M src/StageFactory.cpp
    M src/drivers/bpf/BpfSeqIterator.cpp
    M test/unit/CMakeLists.txt
    M test/unit/MetadataTest.cpp
    M test/unit/drivers/bpf/BPFTest.cpp
    M test/unit/drivers/las/LasWriterTest.cpp
    M test/unit/filters/StatsFilterTest.cpp

  Log Message:
  -----------
  Merge pull request #374 from gadomski/build-without-optional-components

Build without optional components


Compare: https://github.com/PDAL/PDAL/compare/4a0f0582a816...0f3efb7178a2


More information about the pdal-commits mailing list