[pdal-commits] [PDAL/PDAL] ad291d: Delay filename requirement until processOptions

Fri Oct 10 05:49:38 PDT 2014

  Branch: refs/heads/las1.4
  Home:   https://github.com/PDAL/PDAL
  Commit: ad291d010916392c12541e1a371e26f0c273da03
      https://github.com/PDAL/PDAL/commit/ad291d010916392c12541e1a371e26f0c273da03
  Author: Pete Gadomski <pete.gadomski at gmail.com>
  Date:   2014-10-01 (Wed, 01 Oct 2014)

  Changed paths:
    M include/pdal/drivers/las/Writer.hpp
    M src/drivers/las/Writer.cpp

  Log Message:
  -----------
  Delay filename requirement until processOptions

The las writer previously opened up the output stream on writer
construction, which mandated that the options passed to Writer(Options)
needed to include a "filename" option. This patch defers the "filename"
requirement until `processOptions`.

In order to maintain compatibility with existing code, this patch keeps
the Writer(ostream) and Writer(Options, ostream) signatures. This means
that a las Writer created with an ostream will *not* require a
"filename" argument, and will in fact ignore any filename argument when
constructing the ostream. This is consistent with past behavior.

This patch also changes the protected member variable m_streamManager on
Writer from a OutputStreamManager to a unique_ptr<OutputStreamManager>.
This is to support OutputStreamManager construction *after* Writer
construction.

  Commit: 073586482135119ae607e3bb4259a1f214bc24cc
      https://github.com/PDAL/PDAL/commit/073586482135119ae607e3bb4259a1f214bc24cc
  Author: Pete Gadomski <pete.gadomski at gmail.com>
  Date:   2014-10-01 (Wed, 01 Oct 2014)

  Changed paths:
    M src/kernel/Pipeline.cpp

  Log Message:
  -----------
  Allow extra command line options for pdal pipeline

This was not previously supported.

  Commit: d87ddc89af45e1fe2ac8fccfa5f9f9d0da0f8064
      https://github.com/PDAL/PDAL/commit/d87ddc89af45e1fe2ac8fccfa5f9f9d0da0f8064
  Author: Pete Gadomski <pete.gadomski at gmail.com>
  Date:   2014-10-01 (Wed, 01 Oct 2014)

  Changed paths:
    M src/kernel/Pipeline.cpp

  Log Message:
  -----------
  Remove spurious options dump

Do'h. [ci skip]

  Commit: 8c51be571ffa28723896e2c569a288506912a328
      https://github.com/PDAL/PDAL/commit/8c51be571ffa28723896e2c569a288506912a328
  Author: Michael P. Gerlek <mpg at flaxen.com>
  Date:   2014-10-03 (Fri, 03 Oct 2014)

  Changed paths:
    M test/unit/main.cpp

  Log Message:
  -----------
  correct/clarify test runner doc

  Commit: 76671e5e292bf6abcfdbb406642e9e78e509ee17
      https://github.com/PDAL/PDAL/commit/76671e5e292bf6abcfdbb406642e9e78e509ee17
  Author: Michael P. Gerlek <mpg at flaxen.com>
  Date:   2014-10-03 (Fri, 03 Oct 2014)

  Changed paths:
    M src/SpatialReference.cpp
    M src/drivers/las/Reader.cpp
    M src/drivers/nitf/MetadataReader.hpp
    M src/drivers/nitf/NitfFile.cpp
    M src/drivers/nitf/NitfFile.hpp
    M src/drivers/nitf/Writer.cpp
    M src/drivers/nitf/tre_plugins.cpp
    M src/filters/Decimation.cpp
    M src/pdal_config.cpp

  Log Message:
  -----------
  fix various clang warnings

  Commit: a9ff11666fe317ad27f1575b01bcbbec7a510a1d
      https://github.com/PDAL/PDAL/commit/a9ff11666fe317ad27f1575b01bcbbec7a510a1d
  Author: Michael P. Gerlek <mpg at flaxen.com>
  Date:   2014-10-06 (Mon, 06 Oct 2014)

  Changed paths:
    M include/pdal/PDALUtils.hpp
    M src/CMakeLists.txt
    A src/PDALUtils.cpp

  Log Message:
  -----------
  added ptree-to-reST dump support

  Commit: 0b837f1a0cd1a5cbafbfa93e59ceb3489753d0e1
      https://github.com/PDAL/PDAL/commit/0b837f1a0cd1a5cbafbfa93e59ceb3489753d0e1
  Author: Michael P. Gerlek <mpg at flaxen.com>
  Date:   2014-10-06 (Mon, 06 Oct 2014)

  Changed paths:
    M include/pdal/kernel/Info.hpp
    M src/kernel/Info.cpp

  Log Message:
  -----------
  added --summary, for a less verbose output

just shows num points, WKT, num dims, and the bbox (computed via the
stats filter)

  Commit: 7e47724089f34a864dce307afa0773f863927ddd
      https://github.com/PDAL/PDAL/commit/7e47724089f34a864dce307afa0773f863927ddd
  Author: Howard Butler <howard at hobu.co>
  Date:   2014-10-07 (Tue, 07 Oct 2014)

  Changed paths:
    M include/pdal/PDALUtils.hpp
    M include/pdal/kernel/Info.hpp
    M src/CMakeLists.txt
    A src/PDALUtils.cpp
    M src/kernel/Info.cpp

  Log Message:
  -----------
  Merge pull request #509 from PDAL/pdal-info-summary

added --summary and --rst

  Commit: 84697d85273518099026778dec9b28a3cc10cc48
      https://github.com/PDAL/PDAL/commit/84697d85273518099026778dec9b28a3cc10cc48
  Author: Howard Butler <howard at hobu.co>
  Date:   2014-10-07 (Tue, 07 Oct 2014)

  Changed paths:
    M src/SpatialReference.cpp
    M src/drivers/las/Reader.cpp
    M src/drivers/nitf/MetadataReader.hpp
    M src/drivers/nitf/NitfFile.cpp
    M src/drivers/nitf/NitfFile.hpp
    M src/drivers/nitf/Writer.cpp
    M src/drivers/nitf/tre_plugins.cpp
    M src/filters/Decimation.cpp
    M src/pdal_config.cpp
    M test/unit/main.cpp

  Log Message:
  -----------
  Merge pull request #507 from PDAL/clang-warnings

Fix a bunch o' clang warnings

  Commit: 1e5b5f1680f7706afee8435fe7f0da2a5c722141
      https://github.com/PDAL/PDAL/commit/1e5b5f1680f7706afee8435fe7f0da2a5c722141
  Author: Howard Butler <howard at hobu.co>
  Date:   2014-10-07 (Tue, 07 Oct 2014)

  Changed paths:
    M include/pdal/drivers/las/Writer.hpp
    M src/drivers/las/Writer.cpp
    M src/kernel/Pipeline.cpp

  Log Message:
  -----------
  Merge pull request #506 from gadomski/pipeline-commandline-options

Allow extra command line options for `pdal pipeline`

  Commit: 627a88e4ec4afe24d6d77918a0dd42a39a6e6934
      https://github.com/PDAL/PDAL/commit/627a88e4ec4afe24d6d77918a0dd42a39a6e6934
  Author: Bradley J Chambers <brad.chambers at gmail.com>
  Date:   2014-10-08 (Wed, 08 Oct 2014)

  Changed paths:
    M apps/CMakeLists.txt
    M apps/pdal.cpp
    M doc/apps.rst
    A doc/stages/drivers.pclvisualizer.writer.rst
    M include/pdal/Drivers.hpp
    A include/pdal/drivers/pclvisualizer/PCLVisualizer.hpp
    M include/pdal/kernel/Kernel.hpp
    A include/pdal/kernel/View.hpp
    M src/CMakeLists.txt
    M src/StageFactory.cpp
    A src/drivers/pclvisualizer/PCLVisualizer.cpp
    A src/kernel/View.cpp

  Log Message:
  -----------
  add PCLVisualizer writer and View kernel

PCLVisualizer writer can be used as an endpoint to spawn a simple
viewer. To use the PCLVisualizer, PCL must be built with
BUILD_visualization=ON and WITH_VTK=ON, and PCL must be enabled within
PDAL.

PDAL_BUNDLE=ON creates the pdal app as application bundle, which is not
explicitly required, but enables some PCL keyboard/mouse interactions in
PCLVisualizer. As reported by Kitware
(http://vtk.1045678.n5.nabble.com/Keyboard-and-mouse-interaction-on-OSX-td5719379.html).

The View kernel allows us to create a simple viewer with only an input
filename, e.g., pdal view input.las.

The writer can also be invoked through existing kernels by passing a
dummy filename with the .pclviz extension. This is a bit of a hack, and
perhaps we should consider adding a "visualize" option that both writes
the requested output format and spawns the viewer.

  Commit: 1154577599b7d1379a1f8bfb95c267d5c8ce720e
      https://github.com/PDAL/PDAL/commit/1154577599b7d1379a1f8bfb95c267d5c8ce720e
  Author: Bradley J Chambers <brad.chambers at gmail.com>
  Date:   2014-10-08 (Wed, 08 Oct 2014)

  Changed paths:
    M include/stubs/pcl/point_types.h
    A include/stubs/pcl/visualization/pcl_visualizer.h
    A include/stubs/pcl/visualization/point_cloud_color_handlers.h

  Log Message:
  -----------
  fix the PCL stubs for PCLVisualizer

  Commit: 20808b499de5fd1b5b6c4a917c2bd249a39b45c8
      https://github.com/PDAL/PDAL/commit/20808b499de5fd1b5b6c4a917c2bd249a39b45c8
  Author: Bradley J Chambers <brad.chambers at gmail.com>
  Date:   2014-10-08 (Wed, 08 Oct 2014)

  Changed paths:
    M CMakeLists.txt
    M apps/pdal.cpp
    M include/pdal/Drivers.hpp
    M include/pdal/kernel/Application.hpp
    M include/pdal/kernel/Kernel.hpp
    M pdal_defines.h.in
    M src/CMakeLists.txt
    M src/StageFactory.cpp
    M src/kernel/Application.cpp
    M src/kernel/Ground.cpp
    M src/kernel/PCL.cpp
    M src/kernel/Random.cpp
    M src/kernel/Translate.cpp

  Log Message:
  -----------
  add --visualize flag at the Application level that will cause Ground,
PCL, Random, and Translate kernels to spawn a PCLVisualizer after
writing the result to disk

  Commit: 31b37f90588484f0912e6797da372540393c17d8
      https://github.com/PDAL/PDAL/commit/31b37f90588484f0912e6797da372540393c17d8
  Author: Bradley J Chambers <brad.chambers at gmail.com>
  Date:   2014-10-08 (Wed, 08 Oct 2014)

  Changed paths:
    M src/kernel/Application.cpp

  Log Message:
  -----------
  getVisualize should return false if PCLVisualize not available

  Commit: 0f526b4916f327c3cbcd89a83790f42d115c7122
      https://github.com/PDAL/PDAL/commit/0f526b4916f327c3cbcd89a83790f42d115c7122
  Author: Howard Butler <howard at hobu.co>
  Date:   2014-10-08 (Wed, 08 Oct 2014)

  Changed paths:
    M doc/stages/index.rst

  Log Message:
  -----------
  point to filters.ferry in stages doc

  Commit: 4b49259d3a45b85f97d630bd3c02e513f14f3a71
      https://github.com/PDAL/PDAL/commit/4b49259d3a45b85f97d630bd3c02e513f14f3a71
  Author: Howard Butler <howard at hobu.co>
  Date:   2014-10-08 (Wed, 08 Oct 2014)

  Changed paths:
    A doc/stages/drivers.buffer.reader.rst
    M doc/stages/index.rst

  Log Message:
  -----------
  put back docs for

  Commit: c73f1edcc517923d3718f8abcf54b579531d7bb7
      https://github.com/PDAL/PDAL/commit/c73f1edcc517923d3718f8abcf54b579531d7bb7
  Author: Bradley J Chambers <brad.chambers at gmail.com>
  Date:   2014-10-08 (Wed, 08 Oct 2014)

  Changed paths:
    M src/kernel/Ground.cpp

  Log Message:
  -----------
  visualize both input and output

  Commit: 8322c09f776070be5decbb578398c1df3b4a43d1
      https://github.com/PDAL/PDAL/commit/8322c09f776070be5decbb578398c1df3b4a43d1
  Author: Bradley J Chambers <brad.chambers at gmail.com>
  Date:   2014-10-08 (Wed, 08 Oct 2014)

  Changed paths:
    M include/pdal/kernel/Application.hpp
    M include/pdal/kernel/Translate.hpp
    M src/kernel/Application.cpp
    M src/kernel/Ground.cpp
    M src/kernel/PCL.cpp
    M src/kernel/Random.cpp
    M src/kernel/Translate.cpp

  Log Message:
  -----------
  move the visualization code to the Application class

Kernels now call `visualize(*pbSetOut.begin())` to display the output
buffer or `visualize(*pbSetIn.begin(), *pbSetOut.begin())` to display
input and output buffers.

`Random` displays only the output (there is no input buffer), while
`ground`, `pcl`, and `translate` display both input and output buffers.

  Commit: 91128f4ea79b6a190127b0449998d2d1cf571ccb
      https://github.com/PDAL/PDAL/commit/91128f4ea79b6a190127b0449998d2d1cf571ccb
  Author: Bradley J Chambers <brad.chambers at gmail.com>
  Date:   2014-10-08 (Wed, 08 Oct 2014)

  Changed paths:
    M include/pdal/kernel/Translate.hpp
    M src/kernel/Translate.cpp

  Log Message:
  -----------
  fix memory issue

  Commit: c2bc8ff9cafaf5279911ce7c1e228e03d8872dab
      https://github.com/PDAL/PDAL/commit/c2bc8ff9cafaf5279911ce7c1e228e03d8872dab
  Author: Howard Butler <howard at hobu.co>
  Date:   2014-10-08 (Wed, 08 Oct 2014)

  Changed paths:
    M CMakeLists.txt
    M apps/CMakeLists.txt
    M apps/pdal.cpp
    M doc/apps.rst
    A doc/stages/drivers.pclvisualizer.writer.rst
    M include/pdal/Drivers.hpp
    A include/pdal/drivers/pclvisualizer/PCLVisualizer.hpp
    M include/pdal/kernel/Application.hpp
    M include/pdal/kernel/Kernel.hpp
    M include/pdal/kernel/Translate.hpp
    A include/pdal/kernel/View.hpp
    M include/stubs/pcl/point_types.h
    A include/stubs/pcl/visualization/pcl_visualizer.h
    A include/stubs/pcl/visualization/point_cloud_color_handlers.h
    M pdal_defines.h.in
    M src/CMakeLists.txt
    M src/StageFactory.cpp
    A src/drivers/pclvisualizer/PCLVisualizer.cpp
    M src/kernel/Application.cpp
    M src/kernel/Ground.cpp
    M src/kernel/PCL.cpp
    M src/kernel/Random.cpp
    M src/kernel/Translate.cpp
    A src/kernel/View.cpp

  Log Message:
  -----------
  Merge pull request #508 from chambbj/PCLVisualizer

add PCLVisualizer writer and View kernel

  Commit: 439e27d340244200e8db5a1c5de90c58fde03928
      https://github.com/PDAL/PDAL/commit/439e27d340244200e8db5a1c5de90c58fde03928
  Author: Andrew Bell <andrew.bell.ia at gmail.com>
  Date:   2014-10-10 (Fri, 10 Oct 2014)

  Changed paths:
    M CMakeLists.txt
    M apps/CMakeLists.txt
    M apps/pdal.cpp
    M doc/apps.rst
    A doc/stages/drivers.buffer.reader.rst
    A doc/stages/drivers.pclvisualizer.writer.rst
    M doc/stages/index.rst
    M include/pdal/Drivers.hpp
    M include/pdal/PDALUtils.hpp
    A include/pdal/drivers/pclvisualizer/PCLVisualizer.hpp
    M include/pdal/kernel/Application.hpp
    M include/pdal/kernel/Info.hpp
    M include/pdal/kernel/Kernel.hpp
    M include/pdal/kernel/Translate.hpp
    A include/pdal/kernel/View.hpp
    M include/stubs/pcl/point_types.h
    A include/stubs/pcl/visualization/pcl_visualizer.h
    A include/stubs/pcl/visualization/point_cloud_color_handlers.h
    M pdal_defines.h.in
    M src/CMakeLists.txt
    A src/PDALUtils.cpp
    M src/SpatialReference.cpp
    M src/StageFactory.cpp
    M src/drivers/las/Reader.cpp
    M src/drivers/nitf/MetadataReader.hpp
    M src/drivers/nitf/NitfFile.cpp
    M src/drivers/nitf/NitfFile.hpp
    M src/drivers/nitf/Writer.cpp
    M src/drivers/nitf/tre_plugins.cpp
    A src/drivers/pclvisualizer/PCLVisualizer.cpp
    M src/filters/Decimation.cpp
    M src/kernel/Application.cpp
    M src/kernel/Ground.cpp
    M src/kernel/Info.cpp
    M src/kernel/PCL.cpp
    M src/kernel/Pipeline.cpp
    M src/kernel/Random.cpp
    M src/kernel/Translate.cpp
    A src/kernel/View.cpp
    M src/pdal_config.cpp
    M test/unit/main.cpp

  Log Message:
  -----------
  Merge branch 'master' of https://github.com/PDAL/PDAL into las1.4

Conflicts:
	include/pdal/drivers/las/Writer.hpp
	src/drivers/las/Reader.cpp
	src/drivers/las/Writer.cpp

  Commit: 104f4e02755466564352ff374da8d74abae9a56c
      https://github.com/PDAL/PDAL/commit/104f4e02755466564352ff374da8d74abae9a56c
  Author: Andrew Bell <andrew.bell.ia at gmail.com>
  Date:   2014-10-10 (Fri, 10 Oct 2014)

  Changed paths:
    M src/drivers/las/Writer.cpp

  Log Message:
  -----------
  Move initialization of zipper/zip point inside ifdef.

  Commit: 71ecfcc99448e38bfa36ee35222bcbada4336ab7
      https://github.com/PDAL/PDAL/commit/71ecfcc99448e38bfa36ee35222bcbada4336ab7
  Author: Andrew Bell <andrew.bell.ia at gmail.com>
  Date:   2014-10-10 (Fri, 10 Oct 2014)

  Changed paths:
    M include/pdal/drivers/las/VariableLengthRecord.hpp
    M src/drivers/las/Header.cpp
    M src/drivers/las/Reader.cpp
    M src/drivers/las/Writer.cpp

  Log Message:
  -----------
  Merge branch 'las1.4' of https://github.com/PDAL/PDAL into las1.4

Conflicts:
	src/drivers/las/Writer.cpp

Compare: https://github.com/PDAL/PDAL/compare/58fd368b8da4...71ecfcc99448