[pdal-commits] [PDAL/PDAL] 96e660: Fix NULL pointer in `pdal translate --polygon`

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/PDAL/PDAL
  Commit: 96e660a789383e3f1209d00295be93e2d7d9a3d5
      https://github.com/PDAL/PDAL/commit/96e660a789383e3f1209d00295be93e2d7d9a3d5
  Author: Pete Gadomski <pete.gadomski at gmail.com>
  Date:   2015-01-31 (Sat, 31 Jan 2015)

  Changed paths:
    M kernels/translate/TranslateKernel.cpp

  Log Message:
  -----------
  Fix NULL pointer in `pdal translate --polygon`

The crop_stage was being initialized to a (zero literal) NULL pointer,
and was never updated to a real Stage *. This led to a segfault when
trying to crop to a polygon with `pdal translate` (and probably would
cause segfaults in other situations as well).

Rather than creating a StageFactory in a third place in the same method,
I just made a method-wide stage factory — losing possible efficiency in
favor of simplicity.

This patch does not include any unit tests, since AFICT there aren't any
unit tests for kernels.


  Commit: e8df5e62fc22eb4fbf94faef6c0e6b0e222dd748
      https://github.com/PDAL/PDAL/commit/e8df5e62fc22eb4fbf94faef6c0e6b0e222dd748
  Author: Howard Butler <howard at hobu.co>
  Date:   2015-02-01 (Sun, 01 Feb 2015)

  Changed paths:
    M kernels/translate/TranslateKernel.cpp

  Log Message:
  -----------
  Merge pull request #740 from gadomski/translate-crop-null-stage-ptr

Fix NULL pointer in `pdal translate --polygon`


Compare: https://github.com/PDAL/PDAL/compare/f02dea55d560...e8df5e62fc22