[pdal-commits] [PDAL/PDAL] 530184: Windows clean-up (mostly warnings)
GitHub
noreply at github.com
Thu Mar 26 11:32:04 PDT 2015
Branch: refs/heads/master
Home: https://github.com/PDAL/PDAL
Commit: 530184006783642f1adf45f8c4ee4d5b83fed4bc
https://github.com/PDAL/PDAL/commit/530184006783642f1adf45f8c4ee4d5b83fed4bc
Author: Bradley J Chambers <brad.chambers at gmail.com>
Date: 2015-03-19 (Thu, 19 Mar 2015)
Changed paths:
M cmake/win32_compiler_options.cmake
M filters/chipper/ChipperFilter.cpp
M filters/chipper/ChipperFilter.hpp
M filters/colorization/ColorizationFilter.hpp
M filters/crop/CropFilter.cpp
M filters/range/RangeFilter.cpp
M filters/reprojection/ReprojectionFilter.cpp
M filters/stats/StatsFilter.cpp
M include/pdal/KDIndex.hpp
M include/pdal/Metadata.hpp
M include/pdal/PipelineManager.hpp
M include/pdal/PointView.hpp
M include/pdal/QuadIndex.hpp
M include/pdal/Utils.hpp
M include/pdal/pdal_macros.hpp
M include/pdal/pdal_types.hpp
M include/pdal/util/IStream.hpp
M include/pdal/util/OStream.hpp
M io/las/LasReader.cpp
M io/las/VariableLengthRecord.cpp
M io/text/TextWriter.cpp
M kernels/delta/DeltaKernel.cpp
M kernels/delta/DeltaKernel.hpp
M kernels/diff/DiffKernel.cpp
M kernels/info/InfoKernel.cpp
M plugins/attribute/filters/AttributeFilter.cpp
M plugins/nitf/test/NitfReaderTest.cpp
M plugins/nitf/test/NitfWriterTest.cpp
M plugins/pcl/io/PcdReader.cpp
M plugins/pcl/test/PCLBlockFilterTest.cpp
M src/KDIndex.cpp
M src/KernelSupport.cpp
M src/PDALUtils.cpp
M src/QuadIndex.cpp
M src/SpatialReference.cpp
M src/StageFactory.cpp
M src/pdal_config.cpp
M src/util/Bounds.cpp
M test/unit/BoundsTest.cpp
M test/unit/MetadataTest.cpp
M test/unit/PipelineManagerTest.cpp
A test/unit/PointContextTest.cpp
M test/unit/StreamFactoryTest.cpp
M test/unit/Support.cpp
M test/unit/Support.hpp
M test/unit/UserCallbackTest.cpp
M test/unit/filters/CropFilterTest.cpp
M test/unit/filters/DecimationFilterTest.cpp
M test/unit/filters/FerryFilterTest.cpp
M test/unit/filters/RangeFilterTest.cpp
M test/unit/filters/StatsFilterTest.cpp
M test/unit/filters/TransformationFilterTest.cpp
M test/unit/io/bpf/BPFTest.cpp
M test/unit/io/las/LasReaderTest.cpp
M test/unit/io/las/LasWriterTest.cpp
M test/unit/io/optech/OptechReaderTest.cpp
M test/unit/io/qfit/QFITReaderTest.cpp
M test/unit/io/rialto/RialtoWriterTest.cpp
Log Message:
-----------
Windows clean-up (mostly warnings)
Compiler is VC 11.0. Compiler warning is referenced in parens.
Stop getting PluginManager instance when it is not needed (C4189).
Remove initialized, but unreferenced variables (C4189).
Use EXPECT_DOUBLE_EQ vice EXPECT_FLOAT_EQ where appropriate. Rearrange
comparisons such that the expected value comes first (not strictly
necessary, just a convention). Compute some expected values rather than
typing (and truncating) them.
Change point_count_t and PointId to uint32_t vice size_t. Change datatypes
throughout the codebase to try to adhere to this convention, using PointId
vice size_t for point indices, and point_count_t vice size_t for point
counts.
Standardize handling of `-Wfloat-equal` on various compilers, generally
when sucking in GDAL/OGR headers.
Stop casting values to bool. Compare `non_bool != 0` instead (C4800).
Safer tolower/toupper implementation (so sayeth stackoverflow). See
http://stackoverflow.com/questions/19876746/stdtolower-and-visual-studio-2013.
Omit termination test from for loop (rather than using `true`) to avoid
warning about constant conditional expression (C4127).
Globally suppress warning about nameless union/struct (C4201).
Globally suppress warning about exception specifications. These are used
extensively in Nitro (C4290).
Commit: 007666d38b04f23935505fa9dcf0de9e2bd88624
https://github.com/PDAL/PDAL/commit/007666d38b04f23935505fa9dcf0de9e2bd88624
Author: Bradley J Chambers <brad.chambers at gmail.com>
Date: 2015-03-19 (Thu, 19 Mar 2015)
Changed paths:
M cmake/win32_compiler_options.cmake
M filters/colorization/ColorizationFilter.hpp
M filters/crop/CropFilter.cpp
M filters/range/RangeFilter.cpp
M filters/reprojection/ReprojectionFilter.cpp
M include/pdal/Metadata.hpp
M include/pdal/PipelineManager.hpp
M include/pdal/Utils.hpp
M include/pdal/util/IStream.hpp
M include/pdal/util/OStream.hpp
M plugins/attribute/filters/AttributeFilter.cpp
M plugins/nitf/test/NitfReaderTest.cpp
M plugins/nitf/test/NitfWriterTest.cpp
M plugins/pcl/test/PCLBlockFilterTest.cpp
M src/SpatialReference.cpp
M src/pdal_config.cpp
M src/util/Bounds.cpp
M test/unit/filters/CropFilterTest.cpp
M test/unit/filters/DecimationFilterTest.cpp
M test/unit/filters/FerryFilterTest.cpp
M test/unit/filters/RangeFilterTest.cpp
M test/unit/filters/StatsFilterTest.cpp
M test/unit/filters/TransformationFilterTest.cpp
M test/unit/io/optech/OptechReaderTest.cpp
M test/unit/io/rialto/RialtoWriterTest.cpp
Log Message:
-----------
revert some changes, use /W3 instead of /W4
Commit: 9176f4c17123464844bdbb944f041dc528f69e7c
https://github.com/PDAL/PDAL/commit/9176f4c17123464844bdbb944f041dc528f69e7c
Author: Bradley J Chambers <brad.chambers at gmail.com>
Date: 2015-03-19 (Thu, 19 Mar 2015)
Changed paths:
M test/unit/Support.hpp
Log Message:
-----------
fix bad rebase with master
Commit: 41747b089f0c4881756d58a0acd0f3383f6a5380
https://github.com/PDAL/PDAL/commit/41747b089f0c4881756d58a0acd0f3383f6a5380
Author: chambbj <brad.chambers at gmail.com>
Date: 2015-03-26 (Thu, 26 Mar 2015)
Changed paths:
M cmake/win32_compiler_options.cmake
M filters/chipper/ChipperFilter.cpp
M filters/chipper/ChipperFilter.hpp
M filters/colorization/ColorizationFilter.hpp
M filters/range/RangeFilter.cpp
M filters/reprojection/ReprojectionFilter.cpp
M filters/stats/StatsFilter.cpp
M include/pdal/KDIndex.hpp
M include/pdal/PointView.hpp
M include/pdal/QuadIndex.hpp
M include/pdal/Utils.hpp
M include/pdal/pdal_macros.hpp
M include/pdal/pdal_types.hpp
M io/las/LasReader.cpp
M io/las/VariableLengthRecord.cpp
M io/text/TextWriter.cpp
M kernels/delta/DeltaKernel.cpp
M kernels/delta/DeltaKernel.hpp
M kernels/diff/DiffKernel.cpp
M kernels/info/InfoKernel.cpp
M plugins/attribute/filters/AttributeFilter.cpp
M plugins/pcl/io/PcdReader.cpp
M src/KDIndex.cpp
M src/KernelSupport.cpp
M src/PDALUtils.cpp
M src/QuadIndex.cpp
M src/StageFactory.cpp
M src/util/Bounds.cpp
M test/unit/BoundsTest.cpp
M test/unit/MetadataTest.cpp
M test/unit/PipelineManagerTest.cpp
A test/unit/PointContextTest.cpp
M test/unit/StreamFactoryTest.cpp
M test/unit/Support.cpp
M test/unit/Support.hpp
M test/unit/UserCallbackTest.cpp
M test/unit/filters/FerryFilterTest.cpp
M test/unit/io/bpf/BPFTest.cpp
M test/unit/io/las/LasReaderTest.cpp
M test/unit/io/las/LasWriterTest.cpp
M test/unit/io/optech/OptechReaderTest.cpp
M test/unit/io/qfit/QFITReaderTest.cpp
Log Message:
-----------
Merge pull request #842 from PDAL/windows-warnings
Windows clean-up (mostly warnings)
Compare: https://github.com/PDAL/PDAL/compare/a015528463da...41747b089f0c
More information about the pdal-commits
mailing list