[pdal-commits] [PDAL/PDAL] 95dd7f: StatsFilterTest: Use EXPECT_DOUBLE_EQ

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/PDAL/PDAL
  Commit: 95dd7f4b5b63119e8e1778647cf55d5382cd8559
      https://github.com/PDAL/PDAL/commit/95dd7f4b5b63119e8e1778647cf55d5382cd8559
  Author: Even Rouault <even.rouault at spatialys.com>
  Date:   2015-09-30 (Wed, 30 Sep 2015)

  Changed paths:
    M test/unit/filters/StatsFilterTest.cpp

  Log Message:
  -----------
  StatsFilterTest: Use EXPECT_DOUBLE_EQ

Otherwise running StatsFilterTest under Valgrind leads to the following errors.

even at even-N550JK:~/PDAL/build$ valgrind bin/pdal_filters_stats_test
==17441== Memcheck, a memory error detector
==17441== Copyright (C) 2002-2013, and GNU GPL'd, by Julian Seward et al.
==17441== Using Valgrind-3.10.0.SVN and LibVEX; rerun with -h for copyright info
==17441== Command: bin/pdal_filters_stats_test
==17441==
[==========] Running 4 tests from 1 test case.
[----------] Global test environment set-up.
[----------] 4 tests from Stats
[ RUN      ] Stats.simple
[       OK ] Stats.simple (761 ms)
[ RUN      ] Stats.dimset
PDAL: Dimension '' listed in --dimensions option does not exist.  Ignoring.

[       OK ] Stats.dimset (180 ms)
[ RUN      ] Stats.metadata
PDAL: Dimension '' listed in --dimensions option does not exist.  Ignoring.

/home/even/PDAL/test/unit/filters/StatsFilterTest.cpp:171: Failure
Value of: 1.0
  Actual: 1
Expected: mi->findChild("minimum").value<double>()
Which is: 1
/home/even/PDAL/test/unit/filters/StatsFilterTest.cpp:172: Failure
Value of: 1.0
  Actual: 1
Expected: mi->findChild("maximum").value<double>()
Which is: 1
/home/even/PDAL/test/unit/filters/StatsFilterTest.cpp:177: Failure
Value of: 3.0
  Actual: 3
Expected: mi->findChild("average").value<double>()
Which is: 3
/home/even/PDAL/test/unit/filters/StatsFilterTest.cpp:178: Failure
Value of: 3.0
  Actual: 3
Expected: mi->findChild("minimum").value<double>()
Which is: 3
/home/even/PDAL/test/unit/filters/StatsFilterTest.cpp:179: Failure
Value of: 3.0
  Actual: 3
Expected: mi->findChild("maximum").value<double>()
Which is: 3
[  FAILED  ] Stats.metadata (251 ms)
[ RUN      ] Stats.enum
[       OK ] Stats.enum (128 ms)
[----------] 4 tests from Stats (1334 ms total)

[----------] Global test environment tear-down
[==========] 4 tests from 1 test case ran. (1389 ms total)
[  PASSED  ] 3 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] Stats.metadata

 1 FAILED TEST


  Commit: 41663488e9e09480c5e4211565aa0297cd53ba20
      https://github.com/PDAL/PDAL/commit/41663488e9e09480c5e4211565aa0297cd53ba20
  Author: Andrew Bell <andrew.bell.ia at gmail.com>
  Date:   2015-09-30 (Wed, 30 Sep 2015)

  Changed paths:
    M test/unit/filters/StatsFilterTest.cpp

  Log Message:
  -----------
  Merge pull request #1007 from rouault/fix_pdal_filters_stats_test

StatsFilterTest: Use EXPECT_DOUBLE_EQ


Compare: https://github.com/PDAL/PDAL/compare/16cf5935836f...41663488e9e0