[pdal-commits] [PDAL/PDAL] dccfaa: Shrink the PCL plugin

[GitHub]

  Branch: refs/heads/pcl-shrinkage
  Home:   https://github.com/PDAL/PDAL
  Commit: dccfaac5e47c658481d223fa45cf335ec329c916
      https://github.com/PDAL/PDAL/commit/dccfaac5e47c658481d223fa45cf335ec329c916
  Author: Bradley J Chambers <brad.chambers at gmail.com>
  Date:   2016-12-12 (Mon, 12 Dec 2016)

  Changed paths:
    M doc/apps/ground.rst
    M doc/apps/translate.rst
    R doc/apps/view.rst
    M doc/development/compilation/dependencies.rst
    M doc/development/contributors.rst
    R doc/stages/filters.dartsample.rst
    R doc/stages/filters.ground.rst
    R doc/stages/filters.height.rst
    R doc/stages/filters.radiusoutlier.rst
    R doc/stages/filters.statisticaloutlier.img1.png
    R doc/stages/filters.statisticaloutlier.img2.png
    R doc/stages/filters.statisticaloutlier.rst
    R doc/stages/writers.pclvisualizer.rst
    M doc/tutorial/calculating-normalized-heights.rst
    M doc/tutorial/dart-throwing.rst
    M doc/tutorial/pcl_ground.rst
    M doc/workshop/exercises/analysis/denoising/denoise.json
    M doc/workshop/exercises/analysis/denoising/denoising.rst
    R doc/workshop/exercises/analysis/ground/filter.json
    M doc/workshop/exercises/analysis/ground/ground-run-ground-only.txt
    M doc/workshop/exercises/analysis/ground/ground-run-no-filter.txt
    R doc/workshop/exercises/analysis/ground/ground-run-pcl-filter.txt
    M doc/workshop/exercises/analysis/ground/ground.rst
    A doc/workshop/exercises/analysis/ground/translate-run-ground-only.txt
    M doc/workshop/exercises/analysis/thinning/thinning-run-dartsample.txt
    M doc/workshop/exercises/analysis/thinning/thinning.rst
    M doc/workshop/pdal-introduction.rst
    M doc/workshop/slides/source/denoising.rst
    M doc/workshop/slides/source/ground.rst
    A kernels/GroundKernel.cpp
    A kernels/GroundKernel.hpp
    M pdal/KernelFactory.cpp
    M plugins/pcl/CMakeLists.txt
    R plugins/pcl/dartsample/dart_sample.cpp
    R plugins/pcl/dartsample/dart_sample.h
    R plugins/pcl/dartsample/dart_sample.hpp
    R plugins/pcl/filters/DartSampleFilter.cpp
    R plugins/pcl/filters/DartSampleFilter.hpp
    R plugins/pcl/filters/GroundFilter.cpp
    R plugins/pcl/filters/GroundFilter.hpp
    R plugins/pcl/filters/HeightFilter.cpp
    R plugins/pcl/filters/HeightFilter.hpp
    R plugins/pcl/filters/RadiusOutlierFilter.cpp
    R plugins/pcl/filters/RadiusOutlierFilter.hpp
    R plugins/pcl/filters/StatisticalOutlierFilter.cpp
    R plugins/pcl/filters/StatisticalOutlierFilter.hpp
    R plugins/pcl/io/PCLVisualizer.cpp
    R plugins/pcl/io/PCLVisualizer.hpp
    R plugins/pcl/kernel/GroundKernel.cpp
    R plugins/pcl/kernel/GroundKernel.hpp
    R plugins/pcl/kernel/HeightAboveGroundKernel.cpp
    R plugins/pcl/kernel/HeightAboveGroundKernel.hpp
    R plugins/pcl/kernel/ViewKernel.cpp
    R plugins/pcl/kernel/ViewKernel.hpp
    M plugins/pcl/test/PCLBlockFilterTest.cpp
    R test/data/filters/pcl/example_PMF_1.json
    R test/data/filters/pcl/example_PMF_2.json
    R test/data/filters/pcl/filter_APMF_1.json
    R test/data/filters/pcl/filter_PMF_1.json
    R test/data/filters/pcl/filter_PMF_2.json
    R test/data/filters/pcl/filter_PMF_3.json
    R test/data/filters/pcl/filter_PMF_4.json
    R test/data/filters/pcl/filter_PMF_5.json
    R test/data/filters/pcl/filter_PMF_6.json
    R test/data/filters/pcl/filter_PMF_7.json
    R test/data/filters/pcl/filter_PMF_8.json
    R test/data/filters/pcl/filter_PMF_9.json
    R test/data/filters/pcl/filter_RadiusOutlierRemoval_1.json
    R test/data/filters/pcl/filter_RadiusOutlierRemoval_2.json
    R test/data/filters/pcl/filter_StatisticalOutlierRemoval_1.json
    R test/data/filters/pcl/filter_StatisticalOutlierRemoval_2.json
    M test/unit/CMakeLists.txt
    A test/unit/OldPCLBlockTest.cpp

  Log Message:
  -----------
  Shrink the PCL plugin

As discussed in #1404, PDAL can now do many of the things we had been relying
on PCL to do. This commit removes the PCL versions of filters that had been
duplicated across PDAL and PCL, specifically:

* filters.dartsample
* filters.ground
* filters.height
* filters.radiusoutlier
* filters.statisticaloutlier
* kernels.views
* writers.pclvisualizer

Ground kernel is now a native PDAL kernel (it had been part of the PCL plugin).
It now calls filters.pmf (PDAL) as opposed to filters.ground (PCL), which are
both implementations of the PMF algorithm.

We have made an effort to update documentation (especially in the workshop) to
instruction users in the proper usage of the native PDAL capabilities. Many of
the tutorials still refer to the PCL implementations though, as they serve a
dual purpose of introducing the filtering approach and also covering concepts
of how to write plugins for PDAL.

The HeightAboveGround kernel in the PCL plugin had not been built or maintained
in months and has been removed.

To the extent that filters.ground, filters.statisticaloutlier, and
filters.radiusoutlier were being tested via the PCLBlockFilterTest, filters.pmf
and filters.outlier are being tested now in OldPCLBlockTest.