[pdal-commits] [PDAL/PDAL] c33236: Add GDAL_INCLUDE_DIR to interface include dirs

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/PDAL/PDAL
  Commit: c33236057f1d0184e91ccae15a17c7e8e4ae80a4
      https://github.com/PDAL/PDAL/commit/c33236057f1d0184e91ccae15a17c7e8e4ae80a4
  Author: Pete Gadomski <pete.gadomski at gmail.com>
  Date:   2016-11-04 (Fri, 04 Nov 2016)

  Changed paths:
    M src/CMakeLists.txt

  Log Message:
  -----------
  Add GDAL_INCLUDE_DIR to interface include dirs

If GDAL is installed to a non-standard location, anything that uses
`PDALUtils.hpp` will fail b/c it can't find `cpl_port.h`. Since we use
`include_directories` instead of `target_include_directories`, the CMake
library interface is not populated with upstream include directories.
This patch fixes that *for GDAL only*.

A more comprehensive population of the target include interface is
probably wise. IMO the best way to be to switch all usages of
`include_directories` to `target_include_directories`, which is some
work.


  Commit: 47f6bdf0ac3792d43d1d92b377beb96becb7e900
      https://github.com/PDAL/PDAL/commit/47f6bdf0ac3792d43d1d92b377beb96becb7e900
  Author: Andrew Bell <andrew.bell.ia at gmail.com>
  Date:   2016-11-04 (Fri, 04 Nov 2016)

  Changed paths:
    M src/CMakeLists.txt

  Log Message:
  -----------
  Merge pull request #1353 from gadomski/gdal-include-dir-interface

Add GDAL_INCLUDE_DIR to interface include dirs


Compare: https://github.com/PDAL/PDAL/compare/5c509db51eef...47f6bdf0ac37