[pdal-commits] [PDAL/PDAL] 7427d9: Change normal flipping options

[GitHub]

  Branch: refs/heads/issue/1638-normal-flip
  Home:   https://github.com/PDAL/PDAL
  Commit: 7427d98305325803ec3825addcb3589b90e4485d
      https://github.com/PDAL/PDAL/commit/7427d98305325803ec3825addcb3589b90e4485d
  Author: Bradley J Chambers <brad.chambers at gmail.com>
  Date:   2017-08-04 (Fri, 04 Aug 2017)

  Changed paths:
    M filters/NormalFilter.cpp
    M filters/NormalFilter.hpp

  Log Message:
  -----------
  Change normal flipping options

Users must choose between always_up or setting an explicit viewpoint (or
neither). always_up simply means that if a normal has a negative Z value, it
will be flipped. Viewpoints no longer have any defaults; users wishing to use
it must specify X, Y, and Z coordinates.


  Commit: ea6f1871eb28487113f9097c8ffe605c58d50e11
      https://github.com/PDAL/PDAL/commit/ea6f1871eb28487113f9097c8ffe605c58d50e11
  Author: Bradley J Chambers <brad.chambers at gmail.com>
  Date:   2017-08-04 (Fri, 04 Aug 2017)

  Changed paths:
    M filters/CropFilter.cpp
    M filters/CropFilter.hpp
    M filters/NormalFilter.cpp
    M filters/NormalFilter.hpp
    A filters/private/Point.cpp
    A filters/private/Point.hpp
    R filters/private/crop/Point.cpp
    R filters/private/crop/Point.hpp

  Log Message:
  -----------
  Share private Point class between Normal and Crop filters

It was desirable to have the Normal filter viewpoint option specified in a
manner consistent with other PDAL filters. The Crop filter already accepts a
point as WKT or GeoJSON. We use the same class to specify the viewpoint now.


  Commit: 288bbef661e4d9a89f6dc37e53027a275e574e84
      https://github.com/PDAL/PDAL/commit/288bbef661e4d9a89f6dc37e53027a275e574e84
  Author: Bradley J Chambers <brad.chambers at gmail.com>
  Date:   2017-08-04 (Fri, 04 Aug 2017)

  Changed paths:
    M doc/stages/filters.normal.rst

  Log Message:
  -----------
  Update the Normal documentation once again

Reflect recent changes to viewpoint and always_up options.


Compare: https://github.com/PDAL/PDAL/compare/b18fb4213756...288bbef661e4