[pdal-commits] [PDAL/PDAL] 71d96c: Provide for normal flipping

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/PDAL/PDAL
  Commit: 71d96c9ca1a2c04cfc56202785d6d66b296c6685
      https://github.com/PDAL/PDAL/commit/71d96c9ca1a2c04cfc56202785d6d66b296c6685
  Author: Bradley J Chambers <brad.chambers at gmail.com>
  Date:   2017-08-03 (Thu, 03 Aug 2017)

  Changed paths:
    M filters/NormalFilter.cpp
    M filters/NormalFilter.hpp

  Log Message:
  -----------
  Provide for normal flipping

User can always set a preferred viewpoint by providing X, Y, and Z coordinates.
If a viewpoint coordinate is not provided, it will be replaced as follows.

* X and Y will default to the midpoint of the X/Y extents
* Z will default to the maximum Z plus 1000

Normals are flipped when the dot product of the normal and the vector between
the current point and the viewpoint is less than zero.


  Commit: b18fb42137562d1c05bb3c6378fe1cdd8717f164
      https://github.com/PDAL/PDAL/commit/b18fb42137562d1c05bb3c6378fe1cdd8717f164
  Author: Bradley J Chambers <brad.chambers at gmail.com>
  Date:   2017-08-03 (Thu, 03 Aug 2017)

  Changed paths:
    M doc/stages/filters.normal.rst

  Log Message:
  -----------
  Update the normal docs to discuss normal flipping


  Commit: 7427d98305325803ec3825addcb3589b90e4485d
      https://github.com/PDAL/PDAL/commit/7427d98305325803ec3825addcb3589b90e4485d
  Author: Bradley J Chambers <brad.chambers at gmail.com>
  Date:   2017-08-04 (Fri, 04 Aug 2017)

  Changed paths:
    M filters/NormalFilter.cpp
    M filters/NormalFilter.hpp

  Log Message:
  -----------
  Change normal flipping options

Users must choose between always_up or setting an explicit viewpoint (or
neither). always_up simply means that if a normal has a negative Z value, it
will be flipped. Viewpoints no longer have any defaults; users wishing to use
it must specify X, Y, and Z coordinates.


  Commit: ea6f1871eb28487113f9097c8ffe605c58d50e11
      https://github.com/PDAL/PDAL/commit/ea6f1871eb28487113f9097c8ffe605c58d50e11
  Author: Bradley J Chambers <brad.chambers at gmail.com>
  Date:   2017-08-04 (Fri, 04 Aug 2017)

  Changed paths:
    M filters/CropFilter.cpp
    M filters/CropFilter.hpp
    M filters/NormalFilter.cpp
    M filters/NormalFilter.hpp
    A filters/private/Point.cpp
    A filters/private/Point.hpp
    R filters/private/crop/Point.cpp
    R filters/private/crop/Point.hpp

  Log Message:
  -----------
  Share private Point class between Normal and Crop filters

It was desirable to have the Normal filter viewpoint option specified in a
manner consistent with other PDAL filters. The Crop filter already accepts a
point as WKT or GeoJSON. We use the same class to specify the viewpoint now.


  Commit: 288bbef661e4d9a89f6dc37e53027a275e574e84
      https://github.com/PDAL/PDAL/commit/288bbef661e4d9a89f6dc37e53027a275e574e84
  Author: Bradley J Chambers <brad.chambers at gmail.com>
  Date:   2017-08-04 (Fri, 04 Aug 2017)

  Changed paths:
    M doc/stages/filters.normal.rst

  Log Message:
  -----------
  Update the Normal documentation once again

Reflect recent changes to viewpoint and always_up options.


  Commit: 5c906237e58defae09b3527e0a048e13e6c4827d
      https://github.com/PDAL/PDAL/commit/5c906237e58defae09b3527e0a048e13e6c4827d
  Author: Bradley J Chambers <brad.chambers at gmail.com>
  Date:   2017-08-04 (Fri, 04 Aug 2017)

  Changed paths:
    M filters/CropFilter.cpp
    M filters/CropFilter.hpp
    M filters/NormalFilter.cpp
    M filters/NormalFilter.hpp
    M filters/private/Point.cpp
    M filters/private/Point.hpp

  Log Message:
  -----------
  Point still needs to be in a separate namespace


  Commit: 64f9af0827a4524b215361043555e3080c474376
      https://github.com/PDAL/PDAL/commit/64f9af0827a4524b215361043555e3080c474376
  Author: chambbj <brad.chambers at gmail.com>
  Date:   2017-08-08 (Tue, 08 Aug 2017)

  Changed paths:
    M doc/stages/filters.normal.rst
    M filters/CropFilter.cpp
    M filters/CropFilter.hpp
    M filters/NormalFilter.cpp
    M filters/NormalFilter.hpp
    A filters/private/Point.cpp
    A filters/private/Point.hpp
    R filters/private/crop/Point.cpp
    R filters/private/crop/Point.hpp

  Log Message:
  -----------
  Merge pull request #1639 from PDAL/issue/1638-normal-flip

Provide for normal flipping


Compare: https://github.com/PDAL/PDAL/compare/7444ce21b77c...64f9af0827a4