[pdal-commits] [PDAL/PDAL] e881b5: Refactor compiler settings to target-based assignm...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/PDAL/PDAL
  Commit: e881b581e3b91a928105d67db44c567f3b6d1afe
      https://github.com/PDAL/PDAL/commit/e881b581e3b91a928105d67db44c567f3b6d1afe
  Author: Pete Gadomski <pete.gadomski at gmail.com>
  Date:   2017-06-22 (Thu, 22 Jun 2017)

  Changed paths:
    M cmake/macros.cmake
    M cmake/unix_compiler_options.cmake
    M cmake/win32_compiler_options.cmake
    M dimbuilder/CMakeLists.txt
    M vendor/arbiter/CMakeLists.txt

  Log Message:
  -----------
  Refactor compiler settings to target-based assignment (#1613)

* Fix indentation

Three? Mreh?

* Remove unused cmake variables

* Rename CXX_STANDARD to PDAL_CXX_STANDARD

Since we allow CMake 2.8.12, we can't rely on CXX_STANDARD to do
anything. Renaming the variable ensures that we aren't implicitly
relying on some CXX_STANDARD behaviors when developing on CMake 3.0+.

* Update compiler options to be (mostly) targeted

Using directory-specific or global CMake variables prevents downstream
projects from easily picking up necessary (or useful) compiler settings.
This patch converts most (but not all) uses of `CXX_FLAGS` and friends
to `target_compile_options` and `target_compile_definitions`. Some
global variables are left, usually with comments on why they make sense.

This patch applies this changes for both *nix and Windoze systems.

Fixes #1608.