[pdal-commits] [PDAL/PDAL] d239f8: Configure targets to link libxml2 only if found (#...

GitHub noreply at github.com
Thu Aug 16 12:46:43 PDT 2018


  Branch: refs/heads/master
  Home:   https://github.com/PDAL/PDAL
  Commit: d239f8a1569dff0a5daa47923942cd55ca65e6e3
      https://github.com/PDAL/PDAL/commit/d239f8a1569dff0a5daa47923942cd55ca65e6e3
  Author: Mateusz Loskot <mateusz at loskot.net>
  Date:   2018-08-16 (Thu, 16 Aug 2018)

  Changed paths:
    M CMakeLists.txt
    M cmake/libxml2.cmake

  Log Message:
  -----------
  Configure targets to link libxml2 only if found (#2133)

Although according to the docs libxml2 is an optional dependency, main
target unconditionally uses LIBXML2_INCLUDE_DIR and LIBXML2_LIBRARIES
which are flagged as -NOTFOUND. That is not valid value for target_*
commands.
This makes libxml2 a required dependency leading to CMake configuration
errors, if not found.

Remove Ilvis2Reader.cpp from sources if libxml2 if not found.



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.


More information about the pdal-commits mailing list