<html dir="ltr">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" id="owaParaStyle"></style>
</head>
<body fpstyle="1" ocsi="0">
<div style="direction: ltr;font-family: Tahoma;color: #000000;font-size: 10pt;">I just rebased to grab yesterday's commits to master. It looks like the build is still broken, although the issues seem to have changed.
<div><br>
</div>
<div>Just giving you guys a heads up.</div>
<div><br>
</div>
<div>- Whitney</div>
<div style="font-family: Times New Roman; color: #000000; font-size: 16px">
<hr tabindex="-1">
<div id="divRpF775160" style="direction: ltr;"><font face="Tahoma" size="2" color="#000000"><b>From:</b> pdal-bounces@lists.osgeo.org [pdal-bounces@lists.osgeo.org] on behalf of OMeara, Whitney [WOMeara@Radiantblue.com]<br>
<b>Sent:</b> Tuesday, September 23, 2014 10:03 AM<br>
<b>To:</b> pdal@lists.osgeo.org<br>
<b>Subject:</b> [pdal] Master not compiling in Visual Studio<br>
</font><br>
</div>
<div></div>
<div>
<div style="direction:ltr; font-family:Tahoma; color:#000000; font-size:10pt">Hey everyone,
<div><br>
</div>
<div>My name is Whitney. I worked with Brad Chambers a little bit on some PCL stuff a few months ago which was tangentially related to PDAL. I'm currently working on creating a Geowave reader and writer for PDAL. I had been working off of a slightly older
branch, but yesterday I finally rebased with master. </div>
<div><br>
</div>
<div>Anyway, I'm emailing the list because the latest code in master doesn't build in Visual Studio. I included a list of the issues I encountered and my workarounds.</div>
<div><br>
</div>
<div>Issues:</div>
<div>
<ul style="font-family:Tahoma; font-size:10pt">
<li>MetadataNodeImpl - 2 components to this issue
<ul>
<li><b>Issue 1</b>: In the sanitize method, this style of initialization is not supported in Visual C++<br>
std::vector<std::string> to_replace = {";", ":", " ", "'", "\""};</li><li><b>Issue 2</b>: For some reason, Visual C++ is not happy about moving the private constructor for MetadataNodeImpl to Metadata.cpp<br>
<span style="font-size:10pt"><br>
<b>Fix</b>: Fixed both issues by removing the sanitize method, moving the constructor back to the header the way it originally was, and adding a one-line sanitize method in the constructor after initialization:<br>
</span><span style="font-size:10pt">std::replace_if(m_name.begin(), m_name.end(), boost::is_any_of(";: '\""), '_');<br>
<br>
</span></li></ul>
</li><li>PointBufferTest.cpp - 2 issues
<ul>
<li><b>Issue 1</b>: Visual C++ wants a const declaration for NUM_PTS<br>
<br>
<span style="font-size:10pt"><b>Fix</b>: const point_count_t NUM_PTS = 1000000;</span></li><li><span style="font-size:10pt"><b>Issue 2</b>: random() is seemingly not available in Visual C++<br>
<br>
<b>Fix</b>: rand() works as a replacement<br>
<br>
</span></li></ul>
</li><li>BpfReader.[hpp,cpp]
<ul>
<li>Visual C++ is not happy about Charbuf being used in BpfReader.hpp.</li><li>Only complains when trying to link seekoff and seekpos into BPFTest.</li><li>If the Charbuf variable is removed from BpfReader.hpp, and relocated to BpfReader.cpp, the error goes away.</li><li>This issue has really stumped me. I don't have a good solution...</li></ul>
</li></ul>
<div>These fixes work for me at the moment, but if you guys have a better way of resolving the issues, I'll be happy to pick up your changes the next time I rebase. I should also point out that I haven't taken the time to make sure my fixes work in Linux.</div>
</div>
<div><br>
</div>
<div>If you have any questions, let me know.</div>
<div><br>
</div>
<div>Thanks, </div>
<div>Whitney O'Meara</div>
</div>
</div>
</div>
</div>
</body>
</html>