<div dir="ltr"><div>Hi<br><br></div>can anybody give a hint a about "nitro". I get some cmake errors:<br><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Apr 20, 2016 at 6:32 AM, Stefan Ziegler <span dir="ltr"><<a href="mailto:stefan.ziegler.de@gmail.com" target="_blank">stefan.ziegler.de@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><div>Similar mistake again:<br><br>[ 39%] Built target pdal_plugin_filter_statisticaloutlier<br>[ 39%] Built target pdal_plugin_filter_voxelgrid<span class=""><br>[ 39%] Building CXX object plugins/pcl/CMakeFiles/pdal_plugin_kernel_view.dir/kernel/ViewKernel.cpp.o<br>/home/stefan/sources/pdal/plugins/pcl/kernel/ViewKernel.cpp: In member function ‘virtual int pdal::ViewKernel::execute()’:<br></span>/home/stefan/sources/pdal/plugins/pcl/kernel/ViewKernel.cpp:137:35: error: ‘setCommonOptions’ was not declared in this scope<br>     setCommonOptions(readerOptions);<br>                                   ^<span class=""><br>make[2]: *** [plugins/pcl/CMakeFiles/pdal_plugin_kernel_view.dir/kernel/ViewKernel.cpp.o] Error 1<br>make[1]: *** [plugins/pcl/CMakeFiles/pdal_plugin_kernel_view.dir/all] Error 2<br>make: *** [all] Error 2<br></span>stefan@inflexible:~/sources/pdal/build$ <br><br></div>regards<span class="HOEnZb"><font color="#888888"><br></font></span></div><span class="HOEnZb"><font color="#888888">Stefan <br></font></span></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Apr 15, 2016 at 4:58 PM, Andrew Bell <span dir="ltr"><<a href="mailto:andrew.bell.ia@gmail.com" target="_blank">andrew.bell.ia@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote"><div><div>On Fri, Apr 15, 2016 at 1:23 AM, Mateusz Loskot <span dir="ltr"><<a href="mailto:mateusz@loskot.net" target="_blank">mateusz@loskot.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><span>On 15 April 2016 at 08:11, Stefan Ziegler <<a href="mailto:stefan.ziegler.de@gmail.com" target="_blank">stefan.ziegler.de@gmail.com</a>> wrote:<br>
><br>
> /home/stefan/sources/pdal/plugins/pcl/kernel/ViewKernel.cpp:139:54: note:<br>
> candidate is:<br>
> In file included from<br>
> /home/stefan/sources/pdal/plugins/pcl/kernel/ViewKernel.hpp:38:0,<br>
>                  from<br>
> /home/stefan/sources/pdal/plugins/pcl/kernel/ViewKernel.cpp:35:<br>
> /home/stefan/sources/pdal/include/pdal/Kernel.hpp:81:12: note: pdal::Stage&<br>
> pdal::Kernel::makeReader(const string&, std::string)<br>
>      Stage& makeReader(const std::string& inputFile, std::string driver);<br>
>             ^<br>
> /home/stefan/sources/pdal/include/pdal/Kernel.hpp:81:12: note:   candidate<br>
> expects 2 arguments, 1 provided<br>
> make[2]: ***<br>
> [plugins/pcl/CMakeFiles/pdal_plugin_kernel_view.dir/kernel/ViewKernel.cpp.o]<br>
> Error 1<br>
> make[1]: *** [plugins/pcl/CMakeFiles/pdal_plugin_kernel_view.dir/all] Error<br>
> 2<br>
> make: *** [all] Error 2<br>
<br>
</span>It looks like PCL plugin is missing update related to this change<br>
<a href="https://github.com/PDAL/PDAL/commit/2b2eeba95906f5a96fab88d88fb0a0fae59397df" rel="noreferrer" target="_blank">https://github.com/PDAL/PDAL/commit/2b2eeba95906f5a96fab88d88fb0a0fae59397df</a><br>
<br>
Perhaps it will be enough to patch the<br>
pdal/plugins/pcl/kernel/ViewKernel.cpp:139<br>
<br>
Stage& readerStage(Kernel::makeReader(m_inputFile));<br>
<br>
to read<br>
<br>
Stage& readerStage(Kernel::makeReader("kernels.view", m_inputFile));<br></blockquote><div><br></div></div></div><div>Brad told me nobody was using the PCL viewer.  I guess that's incorrect :)</div><div><br></div><div>The change should be to:</div><div><br></div><div>Stage& readerStage(Kernel::makeReader("m_inputFile, ""));<br></div><div><br></div><div>I'll make the change in master.</div><span><font color="#888888"><div><br></div></font></span></div><span><font color="#888888">-- <br><div>Andrew Bell<br><a href="mailto:andrew.bell.ia@gmail.com" target="_blank">andrew.bell.ia@gmail.com</a></div>
</font></span></div></div>
</blockquote></div><br></div>
</div></div></blockquote></div><br></div>