<br><br><div class="gmail_quote">On Fri, Mar 22, 2013 at 4:49 AM, Stephen Woodbridge <span dir="ltr"><<a href="mailto:woodbri@swoodbridge.com" target="_blank">woodbri@swoodbridge.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="im">On 3/21/2013 3:08 PM, Stephen Woodbridge wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi all,<br>
<br>
I am review the existing pgRouting SQL functions and in<br>
routing_core_wrappers.sql we have a function:<br>
<br>
add_vertices_geometry(geom_<u></u>table)<br>
</blockquote>
<br></div>
Add to this:<br>
<br>
update_cost_from_distance(<u></u>geom_table)</blockquote><div><br></div><div><br></div><div>I would say: remove everything that is a) not documented and b) not used.</div><div>It's good to post it hear or make a list of removed functions in the Wiki,so someone, who uses this, can say "stop" or we can reference the list of removals in the release notes.</div>
<div><br></div><div>It could be that these functions came from pgDijkstra already, if they were not added later.</div><div>Anyway, let's remove unused stuff that makes maintenance harder.</div><div><br></div><div>Daniel</div>
<div><br></div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5"><br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
I don't see it referenced anywhere so I assume this is some utility<br>
function that somebody added for some purpose.<br>
<br>
Any objections to removing this?<br>
<br>
My goal here is the following:<br>
<br>
1. review and decruft existing SQL<br>
2. relocate functions into the folders that they belong to<br>
3. refactor the code and/or standardize function calling arguments<br>
4. add pgr_ prefixes to all the pgRouting functions<br>
5. add comments and documentation to the SQL<br>
<br>
Thanks,<br>
-Steve<br>
______________________________<u></u>_________________<br>
pgrouting-dev mailing list<br>
<a href="mailto:pgrouting-dev@lists.osgeo.org" target="_blank">pgrouting-dev@lists.osgeo.org</a><br>
<a href="http://lists.osgeo.org/mailman/listinfo/pgrouting-dev" target="_blank">http://lists.osgeo.org/<u></u>mailman/listinfo/pgrouting-dev</a><br>
</blockquote>
<br>
______________________________<u></u>_________________<br>
pgrouting-dev mailing list<br>
<a href="mailto:pgrouting-dev@lists.osgeo.org" target="_blank">pgrouting-dev@lists.osgeo.org</a><br>
<a href="http://lists.osgeo.org/mailman/listinfo/pgrouting-dev" target="_blank">http://lists.osgeo.org/<u></u>mailman/listinfo/pgrouting-dev</a><br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><span style="font-family:arial,sans-serif;font-size:13px;border-collapse:collapse">Georepublic UG & Georepublic Japan<br>eMail: <a href="mailto:daniel.kastl@georepublic.de" style="color:rgb(66,99,171)" target="_blank">daniel.kastl@georepublic.de</a><br>
Web: <a href="http://georepublic.de/" style="color:rgb(66,99,171)" target="_blank">http://georepublic.de</a></span>