<div dir="ltr"><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">Hello all<br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">I made a rewrite of the original TRSP (no changes for vias, no changes for points)</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">Its not complete (converting the graph to boost graph its still missing)</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">Branch is here:<br><a href="https://github.com/cvvergara/pgrouting/tree/rewritte-trsp2">https://github.com/cvvergara/pgrouting/tree/rewritte-trsp2</a><br><br><br>you can compare the original C code <br><a href="https://github.com/cvvergara/pgrouting/blob/rewritte-trsp2/src/trsp/trsp.c">https://github.com/cvvergara/pgrouting/blob/rewritte-trsp2/src/trsp/trsp.c</a><br>with the new code C code<br><a href="https://github.com/cvvergara/pgrouting/blob/rewritte-trsp2/src/trsp/new_trsp.c">https://github.com/cvvergara/pgrouting/blob/rewritte-trsp2/src/trsp/new_trsp.c</a></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">The old driver file:</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><a href="https://github.com/cvvergara/pgrouting/blob/rewritte-trsp2/src/trsp/trsp_core.cpp">https://github.com/cvvergara/pgrouting/blob/rewritte-trsp2/src/trsp/trsp_core.cpp</a></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">The new driver file:</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><a href="https://github.com/cvvergara/pgrouting/blob/rewritte-trsp2/src/trsp/trsp_driver.cpp">https://github.com/cvvergara/pgrouting/blob/rewritte-trsp2/src/trsp/trsp_driver.cpp</a><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">And the old C++ code<br><a href="https://github.com/cvvergara/pgrouting/blob/rewritte-trsp2/src/trsp/GraphDefinition.cpp">https://github.com/cvvergara/pgrouting/blob/rewritte-trsp2/src/trsp/GraphDefinition.cpp</a><br>with the new C++ code<br><a href="https://github.com/cvvergara/pgrouting/blob/rewritte-trsp2/src/trsp/edgeInfo.cpp">https://github.com/cvvergara/pgrouting/blob/rewritte-trsp2/src/trsp/edgeInfo.cpp</a><br><a href="https://github.com/cvvergara/pgrouting/blob/rewritte-trsp2/src/trsp/rule.cpp">https://github.com/cvvergara/pgrouting/blob/rewritte-trsp2/src/trsp/rule.cpp</a><br><a href="https://github.com/cvvergara/pgrouting/blob/rewritte-trsp2/src/trsp/pgr_trspHandler.cpp">https://github.com/cvvergara/pgrouting/blob/rewritte-trsp2/src/trsp/pgr_trspHandler.cpp</a><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">With these changes:</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">- pointers are no longer used (no leaks)</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">- the code is more readable (so I think), <br></div><div style="font-family:arial,helvetica,sans-serif" class="gmail_default">- ​I has the one to one, one to many, many to one and many to many versions:<br><a href="https://github.com/cvvergara/pgrouting/blob/rewritte-trsp2/sql/trsp/trsp.sql">https://github.com/cvvergara/pgrouting/blob/rewritte-trsp2/sql/trsp/trsp.sql</a>​</div><div style="font-family:arial,helvetica,sans-serif" class="gmail_default">they all call this function:<br></div><div style="font-family:arial,helvetica,sans-serif" class="gmail_default"><a href="https://github.com/cvvergara/pgrouting/blob/rewritte-trsp2/sql/trsp/_trsp.sql">https://github.com/cvvergara/pgrouting/blob/rewritte-trsp2/sql/trsp/_trsp.sql</a></div><div style="font-family:arial,helvetica,sans-serif" class="gmail_default">- The sql files for the postgres (not underscored functions):</div><div style="font-family:arial,helvetica,sans-serif" class="gmail_default"><a href="https://github.com/cvvergara/pgrouting/blob/rewritte-trsp2/sql/trsp/trsp_V2.2.sql">https://github.com/cvvergara/pgrouting/blob/rewritte-trsp2/sql/trsp/trsp_V2.2.sql</a></div><div style="font-family:arial,helvetica,sans-serif" class="gmail_default"><a href="https://github.com/cvvergara/pgrouting/blob/rewritte-trsp2/sql/trsp/viaVertices_v2.2.sql">https://github.com/cvvergara/pgrouting/blob/rewritte-trsp2/sql/trsp/viaVertices_v2.2.sql</a></div><div style="font-family:arial,helvetica,sans-serif" class="gmail_default">Use the new _pgr_trsp where is appropriate</div><div style="font-family:arial,helvetica,sans-serif" class="gmail_default"><br></div><div style="font-family:arial,helvetica,sans-serif" class="gmail_default">- sorry no documentation yet, just the queries results on these notes are updated<br></div><div style="font-family:arial,helvetica,sans-serif" class="gmail_default">  <a href="https://github.com/cvvergara/pgrouting/tree/rewritte-trsp2/doc/trsp">https://github.com/cvvergara/pgrouting/tree/rewritte-trsp2/doc/trsp</a></div><div style="font-family:arial,helvetica,sans-serif" class="gmail_default">  (I haven't gone through the text of the notes to update the text based on the results)</div><div style="font-family:arial,helvetica,sans-serif" class="gmail_default"><br></div><div style="font-family:arial,helvetica,sans-serif" class="gmail_default"></div><div style="font-family:arial,helvetica,sans-serif" class="gmail_default">- The sql functions are still underscored because the missing part of the rewrite</div><div style="font-family:arial,helvetica,sans-serif" class="gmail_default"> - Its not complete (converting the graph to boost graph its still missing)</div><div style="font-family:arial,helvetica,sans-serif" class="gmail_default"><br></div><div style="font-family:arial,helvetica,sans-serif" class="gmail_default">For those who are using one way or another the pgr_trsp(one to one) version If you can give these a try, and see if you find any issue about it.</div><div style="font-family:arial,helvetica,sans-serif" class="gmail_default"><br></div><div style="font-family:arial,helvetica,sans-serif" class="gmail_default">I will be merging to develop next monday up to this changes</div><div style="font-family:arial,helvetica,sans-serif" class="gmail_default"><br></div><div style="font-family:arial,helvetica,sans-serif" class="gmail_default">So any comments would be greatly appreciated.<br></div><div style="font-family:arial,helvetica,sans-serif" class="gmail_default"><br></div><div style="font-family:arial,helvetica,sans-serif" class="gmail_default">I am normally on gitter<br></div><div style="font-family:arial,helvetica,sans-serif" class="gmail_default"><a href="https://gitter.im/pgRouting/pgrouting">https://gitter.im/pgRouting/pgrouting</a></div><div style="font-family:arial,helvetica,sans-serif" class="gmail_default"><br></div><div style="font-family:arial,helvetica,sans-serif" class="gmail_default">Vicky<br></div><br>-- <br><div class="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><pre>Georepublic UG (haftungsbeschränkt)
Salzmannstraße 44, 
81739 München, Germany

Vicky Vergara
Operations Research

eMail: vicky@<a href="http://georepublic.de" target="_blank">georepublic.de</a>
Web: <a href="https://georepublic.info" target="_blank">https://georepublic.info</a>

Tel: +49 (089) 4161 7698-1
Fax: +49 (089) 4161 7698-9

Commercial register: Amtsgericht München, HRB 181428
CEO: Daniel Kastl

<span></span></pre></div></div></div></div></div></div></div></div></div></div></div></div></div></div></div></div></div></div></div></div>
</div>