<div dir="ltr"><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">I support Cayetanos comment,<br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">If any tests are to be done, do them on the new code, not on code with python3 otherwise it will be valuable time used in something its really not needed.<br><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">BTW, some of the bugs might come from pgRouting itself, for example in trsp, and you can not do much about that.<br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">The plug in if used with pgRouting version 2.0, the majority of the bugs (because the results are wrong) come from pgRouting and again you can not do anything about that.<br><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">Regards<br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">Vicky<br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Mar 22, 2018 at 6:41 PM, Aasheesh Tiwari <span dir="ltr"><<a href="mailto:aasheesht50@gmail.com" target="_blank">aasheesht50@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hi Cayetano,<div><br><div>Since there are no tests for pgRouting plugin so first we will have to build tests in python 2 for the existing plugin code . This will allow us to check whether our test coverage is checking every aspect of the code initially. Later we will port these tests to python 3 and test whether changes made to code like python 2 to 3, PyQt4 to PyQt5 etc. are working , and does not have any regression on code. Maybe I am missing something, please let me know.</div></div></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Mar 22, 2018 at 2:00 PM, Cayetano Benavent <span dir="ltr"><<a href="mailto:cayetano.benavent@geographica.gs" target="_blank">cayetano.benavent@<wbr>geographica.gs</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hi Asheesh,<div><br></div><div>The proposal looks good to me. However, I propose to change this sentence (page 4):</div><div><ul><li>"Port the tests from python 2 to python 3 . Resolve any errors"</li></ul><div>Currently there are no tests in PgRoutingLayer so you can not port from Python 2, you need to build all the tests directly in Python 3.</div></div><div><br></div><div>I have no further comment.<br></div><div><br></div><div>Thanks,</div></div><div class="gmail_extra"><br clear="all"><div><div class="m_8069567949016617285m_5523862807542534478gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div style="font-family:Helvetica,arial,sans-serif;font-size:18px;padding:20px 5px 10px 0px"><div dir="ltr" style="font-family:arial,sans-serif;font-size:12.8000001907349px"><b style="font-size:12.8000001907349px;font-family:Helvetica,arial,sans-serif;color:rgb(0,0,0)">Cayetano Benavent<br></b><font style="font-size:12.8000001907349px;font-family:Helvetica,arial,sans-serif" color="#000000">GIS Analyst</font></div><div dir="ltr" style="font-family:arial,sans-serif;font-size:12.8000001907349px"><span style="font-size:12.8000001907349px;font-family:Helvetica,arial,sans-serif"><span style="color:rgb(0,0,0);font-size:12px"><br></span><font color="#000000"><a href="tel:%2B34%20954%20095%20876" value="+34954701157" style="color:rgb(17,85,204)" target="_blank">+34 954 095 876</a></font><font style="color:rgb(80,0,80);font-size:12.8000001907349px" face="Helvetica, arial, sans-serif"><span style="font-size:12px"><br></span></font></span><span style="font-family:Helvetica,arial,sans-serif;font-size:12px;color:rgb(0,0,0)"><a href="http://www.geographica.gs/" style="color:rgb(17,85,204)" target="_blank">www.geographica.gs</a></span></div></div><div style="padding:10px 5px 20px 0px"></div></div></div></div></div></div></div></div></div></div></div></div>
<br><div class="gmail_quote"><div><div class="m_8069567949016617285h5">2018-03-19 9:54 GMT+01:00 Aasheesh Tiwari <span dir="ltr"><<a href="mailto:aasheesht50@gmail.com" target="_blank">aasheesht50@gmail.com</a>></span>:<br></div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div class="m_8069567949016617285h5"><div dir="ltr">Hi all,<div>
<div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:12.8px;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration-style:initial;text-decoration-color:initial;background-color:rgb(255,255,255)">I am Aasheesh Tiwari from India. Currently, I am pursuing Masters in Geoinformatics from CSRE , Indian Institute of Technology Bombay (IITB). I have my bachelors in Computer Science.I have keen interest in learning opensource geospatial technologies.</div><div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:12.8px;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration-style:initial;text-decoration-color:initial;background-color:rgb(255,255,255)"><br></div><div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:12.8px;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration-style:initial;text-decoration-color:initial;background-color:rgb(255,255,255)">I apologise for late communication in this mailing list . But i have been interacting with community members on Gitter platform . I introduced my project idea to them and based on their inputs I have drafted a proposal .</div><div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:12.8px;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration-style:initial;text-decoration-color:initial;background-color:rgb(255,255,255)"><br></div><div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:12.8px;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration-style:initial;text-decoration-color:initial;background-color:rgb(255,255,255)">My GSoC project idea is to make the pgRoutingLayer plugin compatible with the new version of QGIS and add functionality for the proposed functions scheduled for next major release.</div><div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:12.8px;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration-style:initial;text-decoration-color:initial;background-color:rgb(255,255,255)">Below is the link to my proposal , kindly review my proposal and suggest whether my approach is right.</div><div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:12.8px;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration-style:initial;text-decoration-color:initial;background-color:rgb(255,255,255)"><br></div><br class="m_8069567949016617285m_5523862807542534478m_-1950645079748102952gmail-Apple-interchange-newline">
<a href="https://docs.google.com/document/d/1T2a0xRr683vDpgVYUQrv23qS8zhhyDSnYkaze7OXu2w/edit?usp=sharing" target="_blank">https://docs.google.com/docume<wbr>nt/d/1T2a0xRr683vDpgVYUQrv23qS<wbr>8zhhyDSnYkaze7OXu2w/edit?usp=s<wbr>haring</a><br></div></div>
<br></div></div>______________________________<wbr>_________________<br>
pgrouting-dev mailing list<br>
<a href="mailto:pgrouting-dev@lists.osgeo.org" target="_blank">pgrouting-dev@lists.osgeo.org</a><br>
<a href="https://lists.osgeo.org/mailman/listinfo/pgrouting-dev" rel="noreferrer" target="_blank">https://lists.osgeo.org/mailma<wbr>n/listinfo/pgrouting-dev</a><br></blockquote></div><br></div>
<br>______________________________<wbr>_________________<br>
pgrouting-dev mailing list<br>
<a href="mailto:pgrouting-dev@lists.osgeo.org" target="_blank">pgrouting-dev@lists.osgeo.org</a><br>
<a href="https://lists.osgeo.org/mailman/listinfo/pgrouting-dev" rel="noreferrer" target="_blank">https://lists.osgeo.org/mailma<wbr>n/listinfo/pgrouting-dev</a><br></blockquote></div><br></div>
</div></div><br>______________________________<wbr>_________________<br>
pgrouting-dev mailing list<br>
<a href="mailto:pgrouting-dev@lists.osgeo.org">pgrouting-dev@lists.osgeo.org</a><br>
<a href="https://lists.osgeo.org/mailman/listinfo/pgrouting-dev" rel="noreferrer" target="_blank">https://lists.osgeo.org/<wbr>mailman/listinfo/pgrouting-dev</a><br></blockquote></div><br><br clear="all"><br>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><pre>Georepublic UG (haftungsbeschränkt)
Salzmannstraße 44,
81739 München, Germany
Vicky Vergara
Operations Research
eMail: vicky@<a href="http://georepublic.de" target="_blank">georepublic.de</a>
Web: <a href="https://georepublic.info" target="_blank">https://georepublic.info</a>
Tel: +49 (089) 4161 7698-1
Fax: +49 (089) 4161 7698-9
Commercial register: Amtsgericht München, HRB 181428
CEO: Daniel Kastl
<span></span></pre></div></div></div></div></div></div></div></div></div></div></div></div></div></div></div></div></div></div></div></div>
</div>