<div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr">Hi all,<div><br></div><div>Works I have done:</div><div>- I've updated develop branch because it was very outdated (now is paired with master).</div><div>- I've changed base branch (now is develop) for PR to merge all the works for QGIS3 version: <a href="https://github.com/pgRouting/pgRoutingLayer/pull/82" target="_blank">https://github.com/pgRouting/pgRoutingLayer/pull/82</a></div><div>- I've created "gsoc2018" tag with all the works derived from GSOC 2018 by Aasheesh Tiwari past summer: <a href="https://github.com/pgRouting/pgRoutingLayer/tree/gsoc2018" target="_blank">https://github.com/pgRouting/pgRoutingLayer/tree/gsoc2018</a></div><div><br></div><div>In several days we remove python3 branch, we will merge <a href="https://github.com/pgRouting/pgRoutingLayer/pull/82" target="_blank">PR#82</a> and we will create v3.0.0-alpha1 version (without pgr_DijkstraCost).</div><div>Regarding to DijkstraCost function, I will try to review it again to include in v3.0.0-alpha2 version (now I understand his utility in QGIS :) ).</div><div><br></div><div>It is important understand several things to do a better planning of pgRoutingLayer future:</div><div>- QGIS2 is developed entirely with Python 2.</div><div>- QGIS3 is developed entirely with Python 3 and PyQGIS API is very different to QGIS2.</div><div>- Python 2 EOL (end of life) is very near (Python 2 will be retired in 1 year) (<a href="https://pythonclock.org/" target="_blank">https://pythonclock.org/</a> and <a href="https://www.python.org/dev/peps/pep-0373/" target="_blank">https://www.python.org/dev/peps/pep-0373/</a>).</div><div><br></div><div>Taking in consideration this information we should not spend time to code in Python 2 so we only can develop in one direction: QGIS3.</div><div>Last pgRoutingLayer version for QGIS2 should be 2.2 (actually this is the last version uploaded to QGIS plugin hub).</div><div><br></div><div>QGIS3 is very (very) superior to QGIS2 (most of his core has been rewrited) so if you can migrate version (2 to 3) you should do. I can help you if you do not know how to migrate version (it is very easy in all operative systems).</div><div><br></div><div>We are very near to have a QGIS3 version! </div><div><br></div><div>Regards,<br clear="all"><div><div dir="ltr" class="m_-4445112569876891028gmail-m_-3767885213702201630gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div style="font-family:Helvetica,arial,sans-serif;font-size:18px;padding:20px 5px 10px 0px"><div dir="ltr" style="font-family:arial,sans-serif;font-size:12.8px"><b style="font-size:12.8px;font-family:Helvetica,arial,sans-serif;color:rgb(0,0,0)">Cayetano Benavent<br></b><font color="#000000" style="font-size:12.8px;font-family:Helvetica,arial,sans-serif">Head of Data</font></div><div dir="ltr" style="font-family:arial,sans-serif;font-size:12.8px"><span style="font-size:12.8px;font-family:Helvetica,arial,sans-serif"><span style="color:rgb(0,0,0);font-size:12px"><br></span><font color="#000000"><a href="tel:%2B34%20954%20095%20876" value="+34954701157" style="color:rgb(17,85,204)" target="_blank">+34 954 095 876</a></font><font face="Helvetica, arial, sans-serif" style="color:rgb(80,0,80);font-size:12.8px"><span style="font-size:12px"><br></span></font></span><span style="font-family:Helvetica,arial,sans-serif;font-size:12px;color:rgb(0,0,0)"><a href="http://www.geographica.gs/" style="color:rgb(17,85,204)" target="_blank">www.geographica.gs</a></span></div></div><div style="padding:10px 5px 20px 0px"></div></div></div></div></div></div></div></div></div></div></div></div></div></div><br></div></div></div></div></div></div></div><br><div class="gmail_quote"><div dir="ltr">El mié., 3 oct. 2018 a las 17:01, Vicky Vergara (<<a href="mailto:vicky@georepublic.de" target="_blank">vicky@georepublic.de</a>>) escribió:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">Hi Cayetano</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">Please Merge first the branch to "develop" branch.</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"> And clean the repository</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">send a mail to this list about the branches that will be deleted,</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">wait 3 or 4 days for people to double check that no "important" work will be deleted.<br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">Make sure that the tag that contains the GSoC students work was created. <br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">(and the tag has as last commit, the last commit of the student during the program)</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">I really don't remember if I taged his work, we never continue work on a students branch,<br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"> that branch has to remain intact when the GoC program is over that contains the students work and his work only.</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">By cleaning the repo:<br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">When people clone or update their fork, they would only get master and develop branch.</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">master has pgRoutingLayer v2.2.0 and branch develop has v3.0.0-dev</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">Because the version is a "major" change  we have to go thru the following phases:</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"> v3.0.0-alpha (v3.0.0-alpha1 if needed see bellow)<br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">v3.0.0-beta</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">v3.0.0-rc</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">etc.</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br></div>Use that versioning numbering<span class="gmail_default" style="font-family:arial,helvetica,sans-serif"> to create the following branches & tags</span><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">v3.0.0-alpha1  Includes all the functions that are coded</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">v3.0.0-alpha2  Remove function(s) that is(are)  well-known to have issues (issues must be documented on the issue list)<br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">or</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">v3.0.0-alpha Include only the functions that supposedly work well</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">or</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">v3.0.0-alpha1 Includes only pgr_dijkstra</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">v3.0.0-alpha2 Includes also pgr_dijkstraCost<br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">etc ...</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">I like third option best because also work on documentation has to be done.</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">So make users documentation of pgr_dijkstra and make the alpha with only that function<br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">So gradually documentation and functionality come in an alpha<br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br></div><div style="font-family:arial,helvetica,sans-serif" class="gmail_default">I know version pgRoutingLayer v3.0.0 will use python3 what I dont know, is which versions of QGIS it will work.</div><div style="font-family:arial,helvetica,sans-serif" class="gmail_default">The version v2.0 didn't handle the functions with the "pgr_" is that going to remain the same?</div><div style="font-family:arial,helvetica,sans-serif" class="gmail_default">Which versions of pgRouting  will it work with?</div><div style="font-family:arial,helvetica,sans-serif" class="gmail_default">I guess you removed all the deprecated functions, so for example, and kept for example</div><div style="font-family:arial,helvetica,sans-serif" class="gmail_default">for 2.1: pgr_dijkstra, pgr_drivingDistance and pgr_KSP</div><div style="font-family:arial,helvetica,sans-serif" class="gmail_default">Maybe, many users (like me) have QGIS 2.18</div><div style="font-family:arial,helvetica,sans-serif" class="gmail_default">Some instructions about testing the phases would be needed.</div><div style="font-family:arial,helvetica,sans-serif" class="gmail_default"></div><div style="font-family:arial,helvetica,sans-serif" class="gmail_default"><br></div><div style="font-family:arial,helvetica,sans-serif" class="gmail_default"><br></div><div style="font-family:arial,helvetica,sans-serif" class="gmail_default">About initial decisions of what can be included:<br></div><div style="font-family:arial,helvetica,sans-serif" class="gmail_default">Now that we are starting a new major</div><div style="font-family:arial,helvetica,sans-serif" class="gmail_default">one thing is I learned is don't include what does not work</div><div style="font-family:arial,helvetica,sans-serif" class="gmail_default"></div><div style="font-family:arial,helvetica,sans-serif" class="gmail_default"><br></div><div style="font-family:arial,helvetica,sans-serif" class="gmail_default">In our case, besides pgRoutingLayer code correctness, we depend on the correctness of pgRouting :</div><div style="font-family:arial,helvetica,sans-serif" class="gmail_default"></div><div style="font-family:arial,helvetica,sans-serif" class="gmail_default"></div><div style="font-family:arial,helvetica,sans-serif" class="gmail_default"></div><div style="font-family:arial,helvetica,sans-serif" class="gmail_default"></div><div style="font-family:arial,helvetica,sans-serif" class="gmail_default"></div></div><div dir="ltr"><div style="font-family:arial,helvetica,sans-serif" class="gmail_default"><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">About withPoints & all proposed functions</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><a href="https://docs.pgrouting.org/2.6/en/proposed.html#stable" target="_blank">https://docs.pgrouting.org/2.6/en/proposed.html#stable</a></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">There is a warning. and some detected issues:</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><a href="https://github.com/pgRouting/pgrouting/issues?q=is%3Aopen+is%3Aissue+label%3AwithPoints" target="_blank">https://github.com/pgRouting/pgrouting/issues?q=is%3Aopen+is%3Aissue+label%3AwithPoints</a></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">About experimental functions:</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><a href="https://docs.pgrouting.org/2.6/en/proposed.html#experimental-functions" target="_blank">https://docs.pgrouting.org/2.6/en/proposed.html#experimental-functions</a></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br></div></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">About pgr_dijkstraCost in QGiS I use it (to generate the image) here:<br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><a href="https://workshop.pgrouting.org/2.5.0/en/chapters/shortest_path.html#exercise-5-many-pedestrians-going-to-different-destinations-returning-aggregate-costs" target="_blank">https://workshop.pgrouting.org/2.5.0/en/chapters/shortest_path.html#exercise-5-many-pedestrians-going-to-different-destinations-returning-aggregate-costs</a></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">compare VS</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><a href="https://workshop.pgrouting.org/2.5.0/en/chapters/shortest_path.html#exercise-4-many-pedestrians-going-to-different-destinations" target="_blank">https://workshop.pgrouting.org/2.5.0/en/chapters/shortest_path.html#exercise-4-many-pedestrians-going-to-different-destinations</a></div><div style="font-family:arial,helvetica,sans-serif" class="gmail_default">It gives a different perspective of the results of pgr_dijkstra<br></div><br><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">As reference:</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"> This is the latest pgRouting documentation<br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><a href="https://docs.pgrouting.org/2.6/en/index.htm" target="_blank">https://docs.pgrouting.org/2.6/en/index.htm</a></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"> This is the pgRouting 3.0.0-dev documentation (to be released on September 2019)<br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><a href="https://docs.pgrouting.org/dev/en/index.html" target="_blank">https://docs.pgrouting.org/dev/en/index.html</a></div></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">Lots of things to plan</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">:)<br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">Regards</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">Vicky<br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br></div></div></div></div></div></div></div></div></div><br><div class="gmail_quote"><div dir="ltr">On Tue, Oct 2, 2018 at 7:32 PM Cayetano Benavent <<a href="mailto:cayetano.benavent@geographica.gs" target="_blank">cayetano.benavent@geographica.gs</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr">Hi all,<div><br></div><div><div>I have finally cleaned code and fixed last bugs in python3 branch from pgRoutingLayer with all the work done by student Aasheesh Tiwari (@AasheeshT) this summer in GSOC.</div><div>I would like to merge python3 branch with master and upload a QGIS3 version. I've tested this code and it is working well in QGIS3 although there is still a lot of work to do :)</div><div><br></div><div><div>It is important to note that I've removed several functions (what I really did is comment access from GUI):</div><div>- WithPoints family: these functions don't work well because they were a very last addition in GSOC. We will add this code when Aasheesh (or somebody) fixes them.</div><div>- TSP euclidean: This function is not working properly (before GSOC this function does not work well). I think is more useful to add pgr_TSP in the future that fix euclidean version.</div><div>- DijkstraCost: This function is not working properly and I don't undestand very well the purpose of this function in QGIS.</div></div><div><br></div><div>Deprecated functions were also removed (kdijkstra_path and kdijkstra_cost) but in this case we removed all the code.</div><div><br></div><div>Thanks,<br clear="all"><div><div dir="ltr" class="m_-4445112569876891028m_-3767885213702201630m_-2516336683141096486m_-4353498952507857176gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div style="font-family:Helvetica,arial,sans-serif;font-size:18px;padding:20px 5px 10px 0px"><div dir="ltr" style="font-family:arial,sans-serif;font-size:12.8px"><b style="font-size:12.8px;font-family:Helvetica,arial,sans-serif;color:rgb(0,0,0)">Cayetano Benavent<br></b><font color="#000000" style="font-size:12.8px;font-family:Helvetica,arial,sans-serif">Head of Data</font></div><div dir="ltr" style="font-family:arial,sans-serif;font-size:12.8px"><span style="font-size:12.8px;font-family:Helvetica,arial,sans-serif"><span style="color:rgb(0,0,0);font-size:12px"><br></span><font color="#000000"><a href="tel:%2B34%20954%20095%20876" value="+34954701157" style="color:rgb(17,85,204)" target="_blank">+34 954 095 876</a></font><font face="Helvetica, arial, sans-serif" style="color:rgb(80,0,80);font-size:12.8px"><span style="font-size:12px"><br></span></font></span><span style="font-family:Helvetica,arial,sans-serif;font-size:12px;color:rgb(0,0,0)"><a href="http://www.geographica.gs/" style="color:rgb(17,85,204)" target="_blank">www.geographica.gs</a></span></div></div><div style="padding:10px 5px 20px 0px"></div></div></div></div></div></div></div></div></div></div></div></div></div></div></div></div></div></div></div></div></div></div>
_______________________________________________<br>
pgrouting-dev mailing list<br>
<a href="mailto:pgrouting-dev@lists.osgeo.org" target="_blank">pgrouting-dev@lists.osgeo.org</a><br>
<a href="https://lists.osgeo.org/mailman/listinfo/pgrouting-dev" rel="noreferrer" target="_blank">https://lists.osgeo.org/mailman/listinfo/pgrouting-dev</a></blockquote></div><br clear="all"><br>-- <br><div dir="ltr" class="m_-4445112569876891028m_-3767885213702201630m_-2516336683141096486gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><pre>Georepublic UG (haftungsbeschränkt)
Salzmannstraße 44, 
81739 München, Germany

Vicky Vergara
Operations Research

eMail: vicky@<a href="http://georepublic.de" target="_blank">georepublic.de</a>
Web: <a href="https://georepublic.info" target="_blank">https://georepublic.info</a>

Tel: +49 (089) 4161 7698-1
Fax: +49 (089) 4161 7698-9

Commercial register: Amtsgericht München, HRB 181428
CEO: Daniel Kastl

<span></span></pre></div></div></div></div></div></div></div></div></div></div></div></div></div></div></div></div></div></div></div></div>
_______________________________________________<br>
pgrouting-dev mailing list<br>
<a href="mailto:pgrouting-dev@lists.osgeo.org" target="_blank">pgrouting-dev@lists.osgeo.org</a><br>
<a href="https://lists.osgeo.org/mailman/listinfo/pgrouting-dev" rel="noreferrer" target="_blank">https://lists.osgeo.org/mailman/listinfo/pgrouting-dev</a></blockquote></div>