[postgis-devel] relief of dependency on postgresql sources

Markus Schaber schabi at logix-tt.com
Sat May 28 08:09:55 PDT 2005


Hi, Alex,

Your patch really is a great work that will remove some mess from
developers and packagers.

Just a very small cosmetic change to the jdbc2 Makefile change:

> @@ -128,6 +116,7 @@
>  
>  # include version numbers from central repository
>  include ../Version.config
> +include ../Makefile.config
>  VERSION=$(JDBC_MAJOR_VERSION)_$(JDBC_MINOR_VERSION)_$(JDBC_MICRO_VERSION)
>  VERSIONPATH=$(BUILD)/org/postgis
>  VERSIONTARGET=$(VERSIONPATH)/version.properties

Could this be change to something like:

>- # include version numbers from central repository
>+ # include version numbers and configuration from central repository
>  include ../Version.config
> +include ../Makefile.config
> +
>  VERSION=$(JDBC_MAJOR_VERSION)_$(JDBC_MINOR_VERSION)_$(JDBC_MICRO_VERSION)
>  VERSIONPATH=$(BUILD)/org/postgis
>  VERSIONTARGET=$(VERSIONPATH)/version.properties

Btw, did you test whether the jdbc2 jars still build selfcontained, i.
E. from a fresh checkout that did not have any configure/autoconf run in
the toplevel directory?

For people that just want to compile the java client libs and to get the
.jar files, it should be possible to do so without setting up the
environment needed for the autoconf system.

Thanks,
Markus



More information about the postgis-devel mailing list