[postgis-devel] Re: pgsql sources dependency relief ([tgl at sss.pgh.pa.us: Re: [HACKERS] FreeBSD broke with autoconf-based build])

[alex bodnaru]

hi strk,

i have to refresh my memory, of course, but AFAIR, the pgxs was mainly
makefile.shlib from current postgresql, and we wanted to have this
facility available to older postgresql than 8.0.

as you can see, makefile.global provides the information for our
environment, including files locations (which you didn't want to take
from postgresql), and system characteristics.

in my opinion, we should configure and include the makefile.global from
the same postgresql we are building for: one makefile.global for each
postgresql version.
the main problem is (i found in debian packaging), that the original
makefile.global is also including makefile.global.in, configure, and
configure.in, which amounts, for all supported versions, to a quarter of
the whole postgis source.

i might have some time to take a deeper look this weekend.

alex

strk at refractions.net wrote:
> On Wed, Nov 02, 2005 at 03:00:03AM +0200, alex bodnaru wrote:
> 
>>hi,
>>
>>we dropped the dependency on the entire postgresql source tree, and we
>>should add step by step things that turn to be missing.
>>
>>though i have no freebsd machine, i can't test it, but please try to
>>copy the "elf" related stuff from the postgresql configure and
>>configure.in to our respective files.
> 
> 
> I did this already, and it worked fine.
> I was just concerned about the need to use Makefile.global
> as well as Makefile.shlib, as this is what Tom sais it's done
> by pgxs
> 
> --strk;
> 
> 
>>alex
>>
>>strk at refractions.net wrote:
>>
>>>Comments from Tom Lane about how wrong we're doing things.
>>>Alex, do you see quick solutions ?
>>>
>>>--strk;
>>>
>>>----- Forwarded message from Tom Lane <tgl at sss.pgh.pa.us> -----
>>>
>>>Date: Tue, 01 Nov 2005 12:28:26 -0500
>>>From: Tom Lane <tgl at sss.pgh.pa.us>
>>>Subject: Re: [HACKERS] FreeBSD broke with autoconf-based build 
>>>To: strk at refractions.net
>>>Cc: pgsql-hackers at postgresql.org
>>>
>>>strk at refractions.net writes:
>>>
>>>
>>>>We'll have to add a check for ELF_SYSTEM in our own configure script.
>>>>Wouldn't this be a problem for pgxs-compiled modules as well ?
>>>
>>>
>>>No, because they import the PG installation's Makefile.global.  If you
>>>are importing Makefile.shlib and not Makefile.global, you are doing
>>>things seriously wrong.
>>>
>>>			regards, tom lane
>>>
>>>----- End forwarded message -----
>>>
>>
>>_______________________________________________
>>postgis-devel mailing list
>>postgis-devel at postgis.refractions.net
>>http://postgis.refractions.net/mailman/listinfo/postgis-devel
> 
> _______________________________________________
> postgis-devel mailing list
> postgis-devel at postgis.refractions.net
> http://postgis.refractions.net/mailman/listinfo/postgis-devel
>