[postgis-devel] AsKML cleanups patch

[Mark Cave-Ayland]

On Sun, 2007-12-02 at 00:56 -0800, Eduin Carrillo wrote:
> Hi folks,
> 
> I've made an update to KML routines mainly to get sync with latest AsGML changes. Additionally, some cleanups have been done:
> * Removed references to SRS handling (only EPSG:4326 here)
> * Removed getSRSbySRID()
> * Corrected Id and Log CVS tags
> 
> Please let me know if tests are ok
> 
> Thanks


Hi Eduin,

Thanks for the patch. I like the idea of bringing the KML routines in
sync with the GML routines, however a couple of things I have noticed in
the patch are:


- By adding a version number/precision parameter to AsKML(), you also
need to change lwpostgis.sql.in to reflect these changes.

- There are still references to GML rather than KML in your patch.

- SVN doesn't use CVS-style $Log/$Id tags, so you don't need to change
these at all.

- There is no documentation patch to reflect the new function
parameters.


Also, are we 100% sure we can drop all SRIDs except 4326 from the KML
output? What does the official KML documentation say about this?


HTH,

Mark.

-- 
ILande - Open Source Consultancy
http://www.ilande.co.uk