[postgis-devel] Issue 89 in postgis: transform() grid-shift 2nd chance logic defective

[codesite-noreply at google.com]

Comment #1 on issue 89 by mark.cav... at siriusit.co.uk: transform()  
grid-shift 2nd chance logic defective
http://code.google.com/p/postgis/issues/detail?id=89

Hi William,

Thanks for submitting the patch with your bug report above. My main  
question is that
you state "The logic handling this situation is located in the
transform_point() function of lwgeom_transform.c but seems outdated with
respect to how recent versions of proj.4 handle the situation" but the new  
method of
handling is not clear - can you point towards some documentation?

I'm also a little surprised by the existing logic to try again without the  
grid shift
information - surely we should simple return NULL in the case where the
transformation is invalid?

Also another minor note: if you submit a patch, could you submit in either  
unified
(-u) or context (-c) format? It just makes it easier to review on sight  
without
application.


ATB,

Mark.



--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings