[postgis-devel] Issue 35 in postgis: Comments on Postgis Functions

[Obe, Regina]

Paul,
You must have been reading my mind when you selectively picked this one and the proj one to not comment about.
 
Regarding this I have been looking at Dane's submission and as Paul mentioned, off list, its not good to add any more dependencies than we need to.  This would require adding Python and Python's pgsql library to use his source.
 
My main gripe with it is that it requires a postgis_template db to be loaded to build the comments.  It seems the main reason for that is to look up the arg signature in the procname which would seem to be unnecessary if our argument list in the documents could be mapped to the postgresql function signature.
 
In many cases they do or almost do.  But we have cases like
 
ST_MakePolygon(linestring, [linestring[]])
 
which if we changed to
 
ST_MakePolygon(linestring geometry, linestrings geometry[])
ST_MakePolygon(linestring)
 
would work.
 
the only issue I can think of are these functions with multi-signatures
ST_AddPoint(linestring, point, [<position>])
 
I personally would prefer see it listed twice as
ST_AddPoint(linestring geometry, point geometry)
 
ST_AddPoint(linestring geometry, point geometry, position integer)
 
since I'm not convinced non-programmers don't find that nomenclature confusing.
 
then I'm thinking we can generate the postgis_comments.sql.in from a simple
 
postgis_comments.xsl  file that parses the postgis.xml thus not needing another dependency.
 
Although I could very well be trivializing the simplicity of this.
 
Does anyone have issues with me changing the doc accordingly.  
 
Thanks,
Regina
 
 

________________________________

From: postgis-devel-bounces at postgis.refractions.net on behalf of codesite-noreply at google.com
Sent: Thu 7/3/2008 5:47 PM
To: postgis-devel at postgis.refractions.net
Subject: [postgis-devel] Issue 35 in postgis: Comments on Postgis Functions



Issue 35: Comments on Postgis Functions
http://code.google.com/p/postgis/issues/detail?id=35

Comment #2 by pwramsey3:
(No comment was entered for this change.)


Issue attribute updates:
        Labels: -Type-Defect Type-Enhancement

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
_______________________________________________
postgis-devel mailing list
postgis-devel at postgis.refractions.net
http://postgis.refractions.net/mailman/listinfo/postgis-devel




-----------------------------------------
The substance of this message, including any attachments, may be
confidential, legally privileged and/or exempt from disclosure
pursuant to Massachusetts law. It is intended
solely for the addressee. If you received this in error, please
contact the sender and delete the material from any computer.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osgeo.org/pipermail/postgis-devel/attachments/20080706/1d2062a9/attachment.html>