[postgis-devel] More dump comments

[Obe, Regina]

Mark,

Thanks -- 
No haven't tested that far but I will.

What about the fact that the function  TupleDescGetSlot(tupdesc); is
listed as a deprecated function in PostgreSQL.  I suspect it has been
deprecated for a while, but I would need to verify that.

-----Original Message-----
From: postgis-devel-bounces at postgis.refractions.net
[mailto:postgis-devel-bounces at postgis.refractions.net] On Behalf Of Mark
Cave-Ayland
Sent: Friday, February 27, 2009 10:10 AM
To: PostGIS Development Discussion
Subject: Re: [postgis-devel] More dump comments

Obe, Regina wrote:

> I guess no one knows the answer to the below 2 questions
> 
> In LWGeom_dump and LWGEOM_dump_rings
> 
> We do this
> 
>                 /* allocate a slot for a tuple with this tupdesc */
>                 slot = TupleDescGetSlot(tupdesc);
> 
>                 /* allocate a slot for a tuple with this tupdesc */
>                 slot = TupleDescGetSlot(tupdesc);
> 
> Is there a reason for setting this twice?

I haven't looked at it in any detail, but it looks like a typo to me. If

you remove one of them, does it pass both regression and the garden test

in SVN trunk?

Assuming that everything still works after this, feel free to commit 
this to trunk.


ATB,

Mark.

-- 
Mark Cave-Ayland - Senior Technical Architect
PostgreSQL - PostGIS
Sirius Corporation plc - control through freedom
http://www.siriusit.co.uk
t: +44 870 608 0063
_______________________________________________
postgis-devel mailing list
postgis-devel at postgis.refractions.net
http://postgis.refractions.net/mailman/listinfo/postgis-devel
-----------------------------------------
The substance of this message, including any attachments, may be
confidential, legally privileged and/or exempt from disclosure
pursuant to Massachusetts law. It is intended
solely for the addressee. If you received this in error, please
contact the sender and delete the material from any computer.