[postgis-devel] Re: [PostGIS] #192: Broken configuration of regression tests

[PostGIS]

#192: Broken configuration of regression tests
-----------------------+----------------------------------------------------
  Reporter:  mloskot   |       Owner:  pramsey
      Type:  defect    |      Status:  new    
  Priority:  critical  |   Milestone:         
 Component:  postgis   |     Version:         
Resolution:            |    Keywords:         
-----------------------+----------------------------------------------------
Comment (by robe):

 Okay I looked at this and get the same error.  There appear to be two
 problems here one is in regress/run_test and the other I believe is in
 regress/Makefile.in.

 Both introduced in r4131

 Problem 1: It appears to be the change introduced in regress/run_test at
 r4131. I'm not sure what that section does so don't want to mess with it.
 So if I revert run_test, I get passed that. postgis_lib_version();

 Though the tests go thru, I then get a syntax error.

 Problem 2:  Is it my imagination that check is running twice now?  I'm
 running PostgreSQL 8.2 on OpenSUSE.  Anyrate -- check goes thru and fails
 with 11 out of 42 tests.  I suspect the fail is because of a typo
 introduced somewhere or a missing ; in the generated SQL. I'm guessing

         $(shell USE_VERSION=$(POSTGIS_PGSQL_VERSION)
 USE_PATH=$(PGSQL_BINDIR) ./run_test $(TESTS))

 is the culprit but then again I have no clue what that is saying.


 at first I thought it was maybe r4040 but taking that out did not fix
 things -- Note to PSC :
 Kevin I see you put in a cryptic IF check to support PostgreSQL 8.1 users.
 I think we decided for 1.4 we are NOT going to support PostgreSQL 8.1
 users so the  DROP IF EXISTS you suggested would be more legible.  version
 1.3 will be the last version to support 8.1 users.  Though that is vaguely
 fuzzy in my head so maybe I was the only one in that conversation.
 Perhaps we should make that official somewhere if we can all agree on
 that..

-- 
Ticket URL: <http://trac.osgeo.org/postgis/ticket/192#comment:3>
PostGIS <http://trac.osgeo.org/postgis/>
PostGIS