[postgis-devel] [PostGIS] #198: shp2pgsql gives bad output on bad input

[PostGIS]

#198: shp2pgsql gives bad output on bad input
----------------------+-----------------------------------------------------
  Reporter:  pramsey  |       Owner:  mcayland     
      Type:  defect   |      Status:  new          
  Priority:  medium   |   Milestone:  postgis 1.4.0
 Component:  postgis  |     Version:  trunk        
Resolution:           |    Keywords:               
----------------------+-----------------------------------------------------
Old description:

> Using the building_oops data from #167, you get I get the following
> output:
>
> {{{
> Heron-2:buildings_oops pramsey$ shp2pgsql buildings_oops.shp b
> Shapefile type: PolygonZ
> Postgis type: MULTIPOLYGON[4]
> SET STANDARD_CONFORMING_STRINGS TO ON;
> BEGIN;
> CREATE TABLE "b" (gid serial PRIMARY KEY,
> "layer" varchar(254),
> "elevation" numeric,
> "shape_leng" numeric,
> "shape_area" numeric);
> SELECT AddGeometryColumn('','b','the_geom','-1','MULTIPOLYGON',4);
> ERROR: geometry requires more points
> INSERT INTO "b" ("layer","elevation","shape_leng","shape_area",the_geom)
> VALUES
> ('S-BUILDING','1384.22300000','0.00000000000','0.00000000000',Heron-2:buildings_oops
> pramsey$
> }}}
> Again, I re-iterate, that we should not be doing validity checking in the
> loader.

New description:

 Using the building_oops data from #167, I get the following output:

 {{{
 Heron-2:buildings_oops pramsey$ shp2pgsql buildings_oops.shp b
 Shapefile type: PolygonZ
 Postgis type: MULTIPOLYGON[4]
 SET STANDARD_CONFORMING_STRINGS TO ON;
 BEGIN;
 CREATE TABLE "b" (gid serial PRIMARY KEY,
 "layer" varchar(254),
 "elevation" numeric,
 "shape_leng" numeric,
 "shape_area" numeric);
 SELECT AddGeometryColumn('','b','the_geom','-1','MULTIPOLYGON',4);
 ERROR: geometry requires more points
 INSERT INTO "b" ("layer","elevation","shape_leng","shape_area",the_geom)
 VALUES
 ('S-BUILDING','1384.22300000','0.00000000000','0.00000000000',Heron-2:buildings_oops
 pramsey$
 }}}
 Again, I re-iterate, that we should not be doing validity checking in the
 loader.

-- 
Ticket URL: <http://trac.osgeo.org/postgis/ticket/198#comment:2>
PostGIS <http://trac.osgeo.org/postgis/>
PostGIS