[postgis-devel] New Distance Review

[nicklas.aven at jordogskog.no]

ok, I will try to complement the documentation. As Paus says I can put the algoritm description in the wiki. Do you want more from that Mark. There has become some more to describe like this subgeometry handling that I only described with a few words in #231. I will also write down a list of what I have done and why. How to give evidence for the testing I don't know. Some tests I have put in the regression tests. I have thought about making som sort of theme with descriptions about what functions is called at what situation but I guess doxygen satisfies most of that need if the code gets into the trunk. And just a comment about Pauls last post.The new algoritm as implemented in the spike is used when geometries bboxes doesn't overlap and no of the geometries is a point.Maybe it shouldn't be used for lines and polygons with just a few vertexes. I haven't really tested but it seems to be faster in most cases. It would be possible to use the new algoritm on one of the geometrie!
 s and iterate every vertex on the other, but I don't think that is worth the effort. I'll get backNo peace to expect Paul :-)  /Nicklas

2009-11-07 Paul Ramsey wrote:

My understanding is that the code is pretty modular and only activates
>for the particular large geometry cases it performs well for. Perhaps
>Niklas could put his .doc explanation, which is good, into the wiki
>where it's more webbly accessed. I'll be looking for a number of CUnit
>tests that run and compare both methods on a variety of inputs.
>
>p.
>
>On Sat, Nov 7, 2009 at 3:03 AM, Mark Cave-Ayland
> wrote:
>> Paul Ramsey wrote:
>>
>>> Niklas,
>>> I'm going to start reviewing your distance work on Monday, speak now
>>> or forever hold your peace :)
>>> P.
>>
>> I don't think reading the code will be a problem - my main concern is the
>> lack of documentation for the algorithm changes. I'd like to see better
>> documentation of the changes present in Niklas' spike (new algorithm
>> descriptions and reason for change, clear evidence of testing) before
>> agreeing to commit.
>>
>>
>> ATB,
>>
>> Mark.
>>
>> --
>> Mark Cave-Ayland - Senior Technical Architect
>> PostgreSQL - PostGIS
>> Sirius Corporation plc - control through freedom
>> http://www.siriusit.co.uk
>> t: +44 870 608 0063
>>
>> Sirius Labs: http://www.siriusit.co.uk/labs
>> _______________________________________________
>> postgis-devel mailing list
>> postgis-devel at postgis.refractions.net
>> http://postgis.refractions.net/mailman/listinfo/postgis-devel
>>
>_______________________________________________
>postgis-devel mailing list
>postgis-devel at postgis.refractions.net
>http://postgis.refractions.net/mailman/listinfo/postgis-devel
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osgeo.org/pipermail/postgis-devel/attachments/20091107/10e2ac87/attachment.html>