[postgis-devel] current_parser_check_flags

[Paul Ramsey]

Except you say the checks are now 100% enforced in 1.5...
Oh, and we relaxed the parser over time because people were getting
i-can-put-it-in-but-cant-get-it-out errors...
Double oh, probably we aren't seeing more bug reports because most of
the people loading junk data were loading them through the shape
loader and the wkb parser still has the checks in place.
Hum hum hum. Regina, keeper of the torch of consistency?
P.

On Thu, Oct 21, 2010 at 7:27 AM, Paul Ramsey <pramsey at opengeo.org> wrote:
> OK, whew, so I'm not insane :)
> Don't bother fixing it, since I'm replacing that parser. I'll go back
> to an earlier revision to do my reading.
> P.
>
> On Thu, Oct 21, 2010 at 4:49 AM, Mark Cave-Ayland
> <mark.cave-ayland at siriusit.co.uk> wrote:
>> Paul Ramsey wrote:
>>
>>> I'm slowly working through getting a new WKT-to-LWGEOM parser in
>>> place, and the first steps are the longest, as I have to replicate the
>>> behaviour and API of the current parser... so having got to the point
>>> of extracting location information and handling error conditions I'm
>>> now looking at the parser check flags. And strangely, though I can see
>>> quite clearly where the current_parser_check_flags global is set at
>>> the start of the parse phase, I cannot see anywhere thereafter that
>>> refers to the value of that global. I would, looking at the code, say
>>> the checks are being ignored, if not for the fact that I can run SQL
>>> and actually see them being applied... so: how does this work? Mark?
>>> (Strictly speaking, I don't need to know how the current stuff works
>>> in order to make my stuff enforce the checks, but I don't like being
>>> ignorant in this way.)
>>>
>>> P.
>>
>> What the heck? The checks have been totally removed?!
>>
>> ...goes and looks back over the SVN history...
>>
>> OMG. It looks like the entire set of checks got hosed when Mark re-merged
>> his parser changes back into trunk (and 1.5) here:
>>
>> http://trac.osgeo.org/postgis/changeset/3821/trunk/liblwgeom/lwgparse.c
>>
>> This merge is just plain wrong in that it ignores all of the passed flags
>> and appears to enforce all checks regardless :(
>>
>>
>> ATB,
>>
>> Mark.
>>
>> --
>> Mark Cave-Ayland - Senior Technical Architect
>> PostgreSQL - PostGIS
>> Sirius Corporation plc - control through freedom
>> http://www.siriusit.co.uk
>> t: +44 870 608 0063
>>
>> Sirius Labs: http://www.siriusit.co.uk/labs
>> _______________________________________________
>> postgis-devel mailing list
>> postgis-devel at postgis.refractions.net
>> http://postgis.refractions.net/mailman/listinfo/postgis-devel
>>
>