[postgis-devel] GML3 output signatures

[Sandro Santilli]

On Tue, Feb 22, 2011 at 12:39:39PM +0100, Olivier Courtin wrote:
> 
> On Feb 22, 2011, at 12:30 PM, Sandro Santilli wrote:
> 
> >On Tue, Feb 22, 2011 at 10:43:35AM +0100, Olivier Courtin wrote:
> >
> >>Hum after have a look on the code, i understand the aim.
> >>And yes it's fine to me to have only a single bitfield on the  
> >>prototype.
> >
> >Patch is ready.
> >https://github.com/strk/postgis/commit/64a1fe427b902f304814cf757f0cc83282180931
> >
> >Passes cunit and sql regression tests.
> 
> Looks good to me (even if not tested)
> 
> >I'm wondering if I should change the name of the LW_GML_IS_DIMS flag:
> >
> >https://github.com/strk/postgis/commit/64a1fe427b902f304814cf757f0cc83282180931 
> >#L1R1791
> 
> Could be for the SRS part (to be more precise)
> but don't get the SKIP part (or you have to revert al the tests)

My mistake (I've updated the comment).
The flag is indeed for _including_, not _skipping_, the srsDimension attribute.

https://github.com/strk/postgis/commit/d0134f16be7f11203d9ca610a24822b53c23ac00#L0L1790


--strk;

  ()   Free GIS & Flash consultant/developer
  /\   http://strk.keybit.net/services.html