[postgis-devel] Build warnings on trunk: "array subscript is above array bounds"

[Sandro Santilli]

On Fri, May 31, 2013 at 08:59:38AM +0100, Mark Cave-Ayland wrote:
> On 25/05/13 19:39, Mark Cave-Ayland wrote:
> 
> >I had a bit of a play with this over the afternoon, and whilst this
> >approach halved the number of warnings, it didn't eliminate all of them.
> >In order to solve the problem in its entirety, I had to cast to an
> >intermediate typedef with a larger float[] range.
> >
> >I've tested the attached patch and get a full regression pass with it
> >applied; I've also confirmed that if I alter the macro dimension offsets
> >in both the original and this version, then the resulting diffs match
> >exactly with or without this patch attached which makes me reasonably
> >confident that it's accessing the correct offsets within the underlying
> >GIDX float array.
> >
> >Sandro/Paul - can you review and test at your end?
> 
> Ping? Or is no news good news?

+1 for me to push this into current trunk.
I think it's important to get a warning-free build before 2.1.0 goes final.

--strk;