[postgis-devel] Contributing via pull requests (was: "Gsoc weekly report 4": Implement sp-gist) clustering in PostGIS and cartoDB

[Sandro Santilli]

Mohit, I've added some inline comments on your commit.
Can it be you accidentally added two files that should not be
there at all (duplication of PostgreSQL internals) ? 

I hope you can cleanup those changes so it's easier to review them.
Please remove anything which is not necessary and possibly provide
a recipe to test the use of the new index.

--strk;

On Wed, Jun 25, 2014 at 05:06:28PM +0200, Sandro Santilli wrote:
> On Wed, Jun 25, 2014 at 04:57:44PM +0530, mohit kumar wrote:
> > Hi sandro,
> > I have forked the postgis repository at
> > https://github.com/mohitkharb/postgis and am creating a pull request but
> > its not happening.
> 
> What does it mean "its not happening" ?
> 
> Forget the pull request, I'll look at your commit directly:
> https://github.com/mohitkharb/postgis/commit/d0d87512
> https://github.com/mohitkharb/postgis/commit/d0d87512.patch
> 
> Report the above urls in the trac ticket please, for review.
> 
> --strk;